| Message ID | 20230213194819.608-1-quic_jesszhan@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Move TE setup to prepare_for_kickoff() | expand |
On 13/02/2023 21:48, Jessica Zhang wrote: > Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() > functions in both MDP4 and DPU drivers. > > Changes in V2: > - Added changes to remove empty prepare_commit() functions > > Changes in V3: > - Reordered "drm/msm/dpu: Move TE setup to prepare_for_kickoff()" for > clarity > - Fixed spelling mistakes and wording issues > - Picked up "Reviewed-by" tags for patches [2/4] and [4/4] Is it just me or patch 4/4 is missing? Patchwork also hasn't seen it: https://patchwork.freedesktop.org/series/113967/ If you can send it with the proper in-reply-to (set to 20230213194819.608-1-quic_jesszhan@quicinc.com), that would be great. > > Jessica Zhang (4): > drm/msm/dpu: Move TE setup to prepare_for_kickoff() > drm/msm: Check for NULL before calling prepare_commit() > drm/msm/dpu: Remove empty prepare_commit() function > drm/msm/mdp4: Remove empty prepare_commit() function > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 19 ----------------- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 ------- > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 10 ++++++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 21 ------------------- > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 ----- > drivers/gpu/drm/msm/msm_atomic.c | 3 ++- > 6 files changed, 9 insertions(+), 56 deletions(-) >
On 2/13/2023 1:51 PM, Dmitry Baryshkov wrote: > On 13/02/2023 21:48, Jessica Zhang wrote: >> Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() >> functions in both MDP4 and DPU drivers. >> >> Changes in V2: >> - Added changes to remove empty prepare_commit() functions >> >> Changes in V3: >> - Reordered "drm/msm/dpu: Move TE setup to prepare_for_kickoff()" for >> clarity >> - Fixed spelling mistakes and wording issues >> - Picked up "Reviewed-by" tags for patches [2/4] and [4/4] > > Is it just me or patch 4/4 is missing? Patchwork also hasn't seen it: > https://patchwork.freedesktop.org/series/113967/ > Yes, not sure what happened there. Even i couldnt see it. We have posted in-reply-to now. > If you can send it with the proper in-reply-to (set to > 20230213194819.608-1-quic_jesszhan@quicinc.com), that would be great. > >> >> Jessica Zhang (4): >> drm/msm/dpu: Move TE setup to prepare_for_kickoff() >> drm/msm: Check for NULL before calling prepare_commit() >> drm/msm/dpu: Remove empty prepare_commit() function >> drm/msm/mdp4: Remove empty prepare_commit() function >> >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 19 ----------------- >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 ------- >> .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 10 ++++++--- >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 21 ------------------- >> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 ----- >> drivers/gpu/drm/msm/msm_atomic.c | 3 ++- >> 6 files changed, 9 insertions(+), 56 deletions(-) >> >
On 14/02/2023 02:01, Abhinav Kumar wrote: > > > On 2/13/2023 1:51 PM, Dmitry Baryshkov wrote: >> On 13/02/2023 21:48, Jessica Zhang wrote: >>> Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() >>> functions in both MDP4 and DPU drivers. >>> >>> Changes in V2: >>> - Added changes to remove empty prepare_commit() functions >>> >>> Changes in V3: >>> - Reordered "drm/msm/dpu: Move TE setup to prepare_for_kickoff()" for >>> clarity >>> - Fixed spelling mistakes and wording issues >>> - Picked up "Reviewed-by" tags for patches [2/4] and [4/4] >> >> Is it just me or patch 4/4 is missing? Patchwork also hasn't seen it: >> https://patchwork.freedesktop.org/series/113967/ >> > > Yes, not sure what happened there. Even i couldnt see it. > > We have posted in-reply-to now. It was received properly now, thank you!. > >> If you can send it with the proper in-reply-to (set to >> 20230213194819.608-1-quic_jesszhan@quicinc.com), that would be great. >> >>> >>> Jessica Zhang (4): >>> drm/msm/dpu: Move TE setup to prepare_for_kickoff() >>> drm/msm: Check for NULL before calling prepare_commit() >>> drm/msm/dpu: Remove empty prepare_commit() function >>> drm/msm/mdp4: Remove empty prepare_commit() function >>> >>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 19 ----------------- >>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 ------- >>> .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 10 ++++++--- >>> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 21 ------------------- >>> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 ----- >>> drivers/gpu/drm/msm/msm_atomic.c | 3 ++- >>> 6 files changed, 9 insertions(+), 56 deletions(-) >>> >>
On Mon, 13 Feb 2023 11:48:15 -0800, Jessica Zhang wrote: > Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() > functions in both MDP4 and DPU drivers. > > Changes in V2: > - Added changes to remove empty prepare_commit() functions > > Changes in V3: > - Reordered "drm/msm/dpu: Move TE setup to prepare_for_kickoff()" for > clarity > - Fixed spelling mistakes and wording issues > - Picked up "Reviewed-by" tags for patches [2/4] and [4/4] > > [...] Applied, thanks! [1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff() https://gitlab.freedesktop.org/lumag/msm/-/commit/dd7904e0f824 [2/4] drm/msm: Check for NULL before calling prepare_commit() https://gitlab.freedesktop.org/lumag/msm/-/commit/63c3df12d13a [3/4] drm/msm/dpu: Remove empty prepare_commit() function https://gitlab.freedesktop.org/lumag/msm/-/commit/f4d83f101233 [4/4] drm/msm/mdp4: Remove empty prepare_commit() function https://gitlab.freedesktop.org/lumag/msm/-/commit/191604898585 Best regards,