| Message ID | 20230213213104.78443-2-ahalaney@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency | expand |
On Mon, Feb 13, 2023 at 6:31 PM Andrew Halaney <ahalaney@redhat.com> wrote: > > The property is named snps,reset-gpio. Update the name accordingly so > the corresponding phy is reset. > > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Reviewed-by: Fabio Estevam <festevam@gmail.com>
On 13/02/2023 22:31, Andrew Halaney wrote: > The property is named snps,reset-gpio. Update the name accordingly so > the corresponding phy is reset. > > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- > arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > index 1bcf228a22b8..b6d7c2526131 100644 > --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > @@ -121,7 +121,7 @@ &eqos { > phy-handle = <ðphy0>; > nvmem-cells = <&fec_mac1>; > nvmem-cell-names = "mac-address"; > - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; > + snps,reset-gpio = <&pca6416_1 2 GPIO_ACTIVE_LOW>; I don't think it's correct change. This property is deprecated. Also uses old, deprecated suffix gpio. Best regards, Krzysztof
On Tue, Feb 14, 2023 at 09:12:36AM +0100, Krzysztof Kozlowski wrote: > On 13/02/2023 22:31, Andrew Halaney wrote: > > The property is named snps,reset-gpio. Update the name accordingly so > > the corresponding phy is reset. > > > > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > > --- > > arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > > index 1bcf228a22b8..b6d7c2526131 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts > > @@ -121,7 +121,7 @@ &eqos { > > phy-handle = <ðphy0>; > > nvmem-cells = <&fec_mac1>; > > nvmem-cell-names = "mac-address"; > > - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; > > + snps,reset-gpio = <&pca6416_1 2 GPIO_ACTIVE_LOW>; > > I don't think it's correct change. This property is deprecated. Also > uses old, deprecated suffix gpio. > I mentally grandfathered this in, but after your comment realized it shouldn't be. I'll post a v2 with the reset handled in the phy node directly. Thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts index 1bcf228a22b8..b6d7c2526131 100644 --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts @@ -121,7 +121,7 @@ &eqos { phy-handle = <ðphy0>; nvmem-cells = <&fec_mac1>; nvmem-cell-names = "mac-address"; - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; + snps,reset-gpio = <&pca6416_1 2 GPIO_ACTIVE_LOW>; snps,reset-delays-us = <10 20 200000>; status = "okay";
The property is named snps,reset-gpio. Update the name accordingly so the corresponding phy is reset. Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)