| Message ID | 20230215174353.37097-2-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/timer/i8254: Un-inline and simplify IRQs | expand |
On 2/15/23 07:43, Philippe Mathieu-Daudé wrote: > Avoid when refactoring unrelated headers: > > hw/timer/hpet.c:776:39: error: array has incomplete element type 'Property' (aka 'struct Property') > static Property hpet_device_properties[] = { > ^ > hw/timer/hpet.c:777:5: error: implicit declaration of function 'DEFINE_PROP_UINT8' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS), > ^ > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > hw/timer/hpet.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c > index 9520471be2..214d6a0501 100644 > --- a/hw/timer/hpet.c > +++ b/hw/timer/hpet.c > @@ -30,6 +30,7 @@ > #include "qapi/error.h" > #include "qemu/error-report.h" > #include "qemu/timer.h" > +#include "hw/qdev-properties.h" > #include "hw/timer/hpet.h" > #include "hw/sysbus.h" > #include "hw/rtc/mc146818rtc.h" Acked-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 9520471be2..214d6a0501 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -30,6 +30,7 @@ #include "qapi/error.h" #include "qemu/error-report.h" #include "qemu/timer.h" +#include "hw/qdev-properties.h" #include "hw/timer/hpet.h" #include "hw/sysbus.h" #include "hw/rtc/mc146818rtc.h"
Avoid when refactoring unrelated headers: hw/timer/hpet.c:776:39: error: array has incomplete element type 'Property' (aka 'struct Property') static Property hpet_device_properties[] = { ^ hw/timer/hpet.c:777:5: error: implicit declaration of function 'DEFINE_PROP_UINT8' is invalid in C99 [-Werror,-Wimplicit-function-declaration] DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS), ^ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/timer/hpet.c | 1 + 1 file changed, 1 insertion(+)