| Message ID | 20230214001906.1477370-1-matthew.d.roper@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/xelpmp: Consider GSI offset when doing MCR lookups | expand |
On Tue, Feb 14, 2023 at 04:35:26AM +0000, Patchwork wrote: > == Series Details == > > Series: drm/i915/xelpmp: Consider GSI offset when doing MCR lookups > URL : https://patchwork.freedesktop.org/series/113978/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_12734_full -> Patchwork_113978v1_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_113978v1_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_113978v1_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/index.html > > Participating hosts (11 -> 9) > ------------------------------ > > Missing (2): shard-rkl0 shard-tglu-9 > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_113978v1_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@kms_fbcon_fbt@fbc-suspend: > - shard-apl: [PASS][1] -> [ABORT][2] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html Looks like a problem communicating with the monitor; not related to the GT MCR change here. Matt > > > Known issues > ------------ > > Here are the changes found in Patchwork_113978v1_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs: > - shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271]) > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-glk9/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs.html > > * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: > - shard-glk: [PASS][4] -> [FAIL][5] ([i915#72]) > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html > > * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions: > - shard-apl: [PASS][6] -> [FAIL][7] ([i915#2346]) > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html > - shard-glk: [PASS][8] -> [FAIL][9] ([i915#2346]) > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html > > > #### Possible fixes #### > > * igt@fbdev@unaligned-read: > - {shard-tglu}: [SKIP][10] ([i915#2582]) -> [PASS][11] > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-tglu-6/igt@fbdev@unaligned-read.html > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-tglu-1/igt@fbdev@unaligned-read.html > > * igt@feature_discovery@psr2: > - {shard-rkl}: [SKIP][12] ([i915#658]) -> [PASS][13] > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-2/igt@feature_discovery@psr2.html > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-6/igt@feature_discovery@psr2.html > > * igt@gem_exec_endless@dispatch@bcs0: > - {shard-rkl}: [SKIP][14] ([i915#6247]) -> [PASS][15] > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-5/igt@gem_exec_endless@dispatch@bcs0.html > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-1/igt@gem_exec_endless@dispatch@bcs0.html > > * igt@gem_exec_fair@basic-throttle@rcs0: > - shard-glk: [FAIL][16] ([i915#2842]) -> [PASS][17] +2 similar issues > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html > > * igt@gem_exec_reloc@basic-write-gtt: > - {shard-rkl}: [SKIP][18] ([i915#3281]) -> [PASS][19] +1 similar issue > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-3/igt@gem_exec_reloc@basic-write-gtt.html > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-5/igt@gem_exec_reloc@basic-write-gtt.html > > * igt@gem_tiled_partial_pwrite_pread@writes-after-reads: > - {shard-rkl}: [SKIP][20] ([i915#3282]) -> [PASS][21] > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-3/igt@gem_tiled_partial_pwrite_pread@writes-after-reads.html > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-5/igt@gem_tiled_partial_pwrite_pread@writes-after-reads.html > > * igt@gen9_exec_parse@valid-registers: > - {shard-rkl}: [SKIP][22] ([i915#2527]) -> [PASS][23] > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-3/igt@gen9_exec_parse@valid-registers.html > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-5/igt@gen9_exec_parse@valid-registers.html > > * igt@i915_hangman@engine-engine-error@bcs0: > - {shard-rkl}: [SKIP][24] ([i915#6258]) -> [PASS][25] > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-5/igt@i915_hangman@engine-engine-error@bcs0.html > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-2/igt@i915_hangman@engine-engine-error@bcs0.html > > * igt@i915_pm_rc6_residency@rc6-idle@bcs0: > - {shard-dg1}: [FAIL][26] ([i915#3591]) -> [PASS][27] > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html > > * igt@i915_pm_rpm@dpms-lpsp: > - {shard-rkl}: [SKIP][28] ([i915#1397]) -> [PASS][29] > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-3/igt@i915_pm_rpm@dpms-lpsp.html > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html > > * igt@i915_pm_rps@engine-order: > - shard-apl: [FAIL][30] ([i915#6537]) -> [PASS][31] > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-apl7/igt@i915_pm_rps@engine-order.html > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-apl2/igt@i915_pm_rps@engine-order.html > > * igt@kms_big_fb@linear-32bpp-rotate-0: > - {shard-rkl}: [SKIP][32] ([i915#1845] / [i915#4098]) -> [PASS][33] +10 similar issues > [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-3/igt@kms_big_fb@linear-32bpp-rotate-0.html > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-6/igt@kms_big_fb@linear-32bpp-rotate-0.html > > * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: > - shard-apl: [FAIL][34] ([i915#2346]) -> [PASS][35] > [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html > > * igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-hdmi-a1-hdmi-a2: > - shard-glk: [FAIL][36] ([i915#2122]) -> [PASS][37] > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-glk3/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-hdmi-a1-hdmi-a2.html > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-glk3/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-hdmi-a1-hdmi-a2.html > > * igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2: > - shard-glk: [FAIL][38] ([i915#79]) -> [PASS][39] > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html > > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt: > - {shard-tglu}: [SKIP][40] ([i915#1849]) -> [PASS][41] +3 similar issues > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-tglu-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html > > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: > - {shard-rkl}: [SKIP][42] ([i915#1849] / [i915#4098]) -> [PASS][43] +9 similar issues > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html > > * igt@kms_plane@plane-position-hole@pipe-b-planes: > - {shard-rkl}: [SKIP][44] ([i915#1849]) -> [PASS][45] +1 similar issue > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-2/igt@kms_plane@plane-position-hole@pipe-b-planes.html > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-6/igt@kms_plane@plane-position-hole@pipe-b-planes.html > > * igt@kms_psr@no_drrs: > - {shard-rkl}: [SKIP][46] ([i915#1072]) -> [PASS][47] > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-2/igt@kms_psr@no_drrs.html > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-6/igt@kms_psr@no_drrs.html > > * igt@kms_universal_plane@universal-plane-pipe-b-sanity: > - {shard-tglu}: [SKIP][48] ([fdo#109274]) -> [PASS][49] +1 similar issue > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-tglu-6/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-tglu-1/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html > > * igt@kms_vblank@pipe-c-ts-continuation-suspend: > - {shard-tglu}: [SKIP][50] ([i915#1845] / [i915#7651]) -> [PASS][51] +11 similar issues > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-tglu-6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-tglu-1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html > > * igt@prime_vgem@basic-write: > - {shard-rkl}: [SKIP][52] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][53] > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12734/shard-rkl-3/igt@prime_vgem@basic-write.html > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/shard-rkl-5/igt@prime_vgem@basic-write.html > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 > [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 > [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 > [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 > [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 > [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 > [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 > [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303 > [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 > [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 > [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313 > [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 > [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 > [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 > [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 > [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 > [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 > [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 > [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 > [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644 > [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 > [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 > [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 > [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 > [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 > [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 > [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 > [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 > [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 > [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 > [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 > [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 > [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902 > [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 > [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 > [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 > [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 > [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 > [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 > [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 > [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 > [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 > [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 > [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 > [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 > [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 > [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 > [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 > [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 > [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 > [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 > [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 > [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 > [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 > [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 > [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 > [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 > [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 > [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 > [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536 > [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 > [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 > [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 > [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 > [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 > [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 > [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 > [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 > [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 > [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 > [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 > [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804 > [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 > [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 > [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404 > [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 > [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 > [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 > [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 > [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 > [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 > [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 > [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 > [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 > [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 > [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 > [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 > [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 > [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 > [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 > [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 > [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 > [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 > [i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879 > [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881 > [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 > [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 > [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 > [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 > [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 > [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 > [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 > [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439 > [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 > [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 > [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723 > [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 > [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227 > [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230 > [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 > [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 > [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252 > [i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258 > [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335 > [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 > [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 > [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 > [i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537 > [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 > [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 > [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 > [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 > [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953 > [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 > [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 > [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128 > [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 > [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294 > [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 > [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 > [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582 > [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651 > [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 > [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701 > [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707 > [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 > [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 > [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 > [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 > [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949 > [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957 > [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975 > [i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018 > > > Build changes > ------------- > > * Linux: CI_DRM_12734 -> Patchwork_113978v1 > > CI-20190529: 20190529 > CI_DRM_12734: ffa7027c353c6821636559f42584dd11f527b0e0 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_113978v1: ffa7027c353c6821636559f42584dd11f527b0e0 @ git://anongit.freedesktop.org/gfx-ci/linux > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/index.html
> -----Original Message----- > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Matt > Roper > Sent: Monday, February 13, 2023 4:19 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: [PATCH] drm/i915/xelpmp: Consider GSI offset when doing MCR > lookups > > MCR range tables use the final MMIO offset of a register (including the > 0x380000 GSI offset when applicable). Since the i915_mcr_reg_t passed > as a parameter during steering lookup does not include the GSI offset, > we need to add it back in for GSI registers before searching the tables. > > Fixes: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT") LGTM, Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > index a4a8b8bc5737..03632df27de3 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > @@ -561,12 +561,15 @@ static bool reg_needs_read_steering(struct intel_gt > *gt, > i915_mcr_reg_t reg, > enum intel_steering_type type) > { > - const u32 offset = i915_mmio_reg_offset(reg); > + u32 offset = i915_mmio_reg_offset(reg); > const struct intel_mmio_range *entry; > > if (likely(!gt->steering_table[type])) > return false; > > + if (IS_GSI_REG(offset)) > + offset += gt->uncore->gsi_offset; > + > for (entry = gt->steering_table[type]; entry->end; entry++) { > if (offset >= entry->start && offset <= entry->end) > return true; > -- > 2.39.1
On Wed, Feb 15, 2023 at 11:48:13AM -0800, Sripada, Radhakrishna wrote: > > > > -----Original Message----- > > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Matt > > Roper > > Sent: Monday, February 13, 2023 4:19 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > Subject: [PATCH] drm/i915/xelpmp: Consider GSI offset when doing MCR > > lookups > > > > MCR range tables use the final MMIO offset of a register (including the > > 0x380000 GSI offset when applicable). Since the i915_mcr_reg_t passed > > as a parameter during steering lookup does not include the GSI offset, > > we need to add it back in for GSI registers before searching the tables. > > > > Fixes: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT") > > LGTM, > Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> Thanks, applied to drm-intel-gt-next. Matt > > > Signed-off-by: Matt Roper <matthew.d.roper@intel.com> > > --- > > drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > index a4a8b8bc5737..03632df27de3 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > @@ -561,12 +561,15 @@ static bool reg_needs_read_steering(struct intel_gt > > *gt, > > i915_mcr_reg_t reg, > > enum intel_steering_type type) > > { > > - const u32 offset = i915_mmio_reg_offset(reg); > > + u32 offset = i915_mmio_reg_offset(reg); > > const struct intel_mmio_range *entry; > > > > if (likely(!gt->steering_table[type])) > > return false; > > > > + if (IS_GSI_REG(offset)) > > + offset += gt->uncore->gsi_offset; > > + > > for (entry = gt->steering_table[type]; entry->end; entry++) { > > if (offset >= entry->start && offset <= entry->end) > > return true; > > -- > > 2.39.1 >
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c index a4a8b8bc5737..03632df27de3 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c @@ -561,12 +561,15 @@ static bool reg_needs_read_steering(struct intel_gt *gt, i915_mcr_reg_t reg, enum intel_steering_type type) { - const u32 offset = i915_mmio_reg_offset(reg); + u32 offset = i915_mmio_reg_offset(reg); const struct intel_mmio_range *entry; if (likely(!gt->steering_table[type])) return false; + if (IS_GSI_REG(offset)) + offset += gt->uncore->gsi_offset; + for (entry = gt->steering_table[type]; entry->end; entry++) { if (offset >= entry->start && offset <= entry->end) return true;
MCR range tables use the final MMIO offset of a register (including the 0x380000 GSI offset when applicable). Since the i915_mcr_reg_t passed as a parameter during steering lookup does not include the GSI offset, we need to add it back in for GSI registers before searching the tables. Fixes: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT") Signed-off-by: Matt Roper <matthew.d.roper@intel.com> --- drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)