| Message ID | 20230215203711.6293-3-bage@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Enable hwlock on Allwinner A64 | expand |
On Wed, 15 Feb 2023 21:37:07 +0100 Bastian Germann <bage@debian.org> wrote: Hi, > The dt-bindings tools will compile the yaml dt examples > and this prevents an error about this node not existing. This needs to be part of patch 1/5, otherwise it will break bisecting. Just squash the two patches together. Cheers, Andre > Signed-off-by: Bastian Germann <bage@debian.org> > --- > .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > index 01b1bbb3061f..38478dad8b25 100644 > --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > @@ -48,5 +48,6 @@ examples: > reg = <0x01c18000 0x1000>; > clocks = <&ccu CLK_BUS_SPINLOCK>; > resets = <&ccu RST_BUS_SPINLOCK>; > + #hwlock-cells = <1>; > }; > ...
Am 15.02.23 um 21:40 schrieb Andre Przywara: > On Wed, 15 Feb 2023 21:37:07 +0100 > Bastian Germann <bage@debian.org> wrote: > > Hi, > >> The dt-bindings tools will compile the yaml dt examples >> and this prevents an error about this node not existing. > > This needs to be part of patch 1/5, otherwise it will break > bisecting. Just squash the two patches together. Is this also okay with 1/5 already being applied in linux-next? > > Cheers, > Andre > >> Signed-off-by: Bastian Germann <bage@debian.org> >> --- >> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml >> index 01b1bbb3061f..38478dad8b25 100644 >> --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml >> +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml >> @@ -48,5 +48,6 @@ examples: >> reg = <0x01c18000 0x1000>; >> clocks = <&ccu CLK_BUS_SPINLOCK>; >> resets = <&ccu RST_BUS_SPINLOCK>; >> + #hwlock-cells = <1>; >> }; >> ... >
On Wed, 15 Feb 2023 21:43:50 +0100 Bastian Germann <bage@debian.org> wrote: > Am 15.02.23 um 21:40 schrieb Andre Przywara: > > On Wed, 15 Feb 2023 21:37:07 +0100 > > Bastian Germann <bage@debian.org> wrote: > > > > Hi, > > > >> The dt-bindings tools will compile the yaml dt examples > >> and this prevents an error about this node not existing. > > > > This needs to be part of patch 1/5, otherwise it will break > > bisecting. Just squash the two patches together. > > Is this also okay with 1/5 already being applied in linux-next? The idea of -next is to spot those things before they cause problems. I don't know if it's already too late, let's see what Bjorn says (see the other mail). You could either send a totally separate fix patch (outside of a series), or a new series with the correct patch. But for now let's wait how this ends up. Cheers, Andre > > > > > Cheers, > > Andre > > > >> Signed-off-by: Bastian Germann <bage@debian.org> > >> --- > >> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > >> index 01b1bbb3061f..38478dad8b25 100644 > >> --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > >> +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > >> @@ -48,5 +48,6 @@ examples: > >> reg = <0x01c18000 0x1000>; > >> clocks = <&ccu CLK_BUS_SPINLOCK>; > >> resets = <&ccu RST_BUS_SPINLOCK>; > >> + #hwlock-cells = <1>; > >> }; > >> ... > > >
On 15/02/2023 21:37, Bastian Germann wrote: > The dt-bindings tools will compile the yaml dt examples > and this prevents an error about this node not existing. > > Signed-off-by: Bastian Germann <bage@debian.org> > --- > .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> so Bjorn can fix his tree. Can be also squashed with original one. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index 01b1bbb3061f..38478dad8b25 100644 --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -48,5 +48,6 @@ examples: reg = <0x01c18000 0x1000>; clocks = <&ccu CLK_BUS_SPINLOCK>; resets = <&ccu RST_BUS_SPINLOCK>; + #hwlock-cells = <1>; }; ...
The dt-bindings tools will compile the yaml dt examples and this prevents an error about this node not existing. Signed-off-by: Bastian Germann <bage@debian.org> --- .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 1 + 1 file changed, 1 insertion(+)