| Message ID | 20230214210117.23123-3-jesse.brandeburg@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3ba0bf47edf955d6f52fdb16b54acd1932cb9445 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/core: commmon prints for promisc | expand |
On Tue, 2023-02-14 at 13:01 -0800, Jesse Brandeburg wrote: > The kernel stack can be more consistent by printing the IFF_PROMISC > aka promiscuous enable/disable messages with the standard netdev_info > message which can include bus and driver info as well as the device. > > typical command usage from user space looks like: > ip link set eth0 promisc <on|off> > > But lots of utilities such as bridge, tcpdump, etc put the interface into > promiscuous mode. > > old message: > [ 406.034418] device eth0 entered promiscuous mode > [ 408.424703] device eth0 left promiscuous mode > > new message: > [ 406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode > [ 408.424715] ice 0000:17:00.0 eth0: left promiscuous mode > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > I'm unsure about this one because it's changing a long standard kernel > message to a slightly different format. I think the new way looks better > and has more information. I guess the relevant question here is if such kind of messages are somewhat implicitly part of uAPI. AFAIK the answer is "no", at least for info-level msg, so the patch LGTM. Thanks, Paolo
diff --git a/net/core/dev.c b/net/core/dev.c index ad1e6482e1c1..357081b0113c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -8321,9 +8321,8 @@ static int __dev_set_promiscuity(struct net_device *dev, int inc, bool notify) } } if (dev->flags != old_flags) { - pr_info("device %s %s promiscuous mode\n", - dev->name, - dev->flags & IFF_PROMISC ? "entered" : "left"); + netdev_info(dev, "%s promiscuous mode\n", + dev->flags & IFF_PROMISC ? "entered" : "left"); if (audit_enabled) { current_uid_gid(&uid, &gid); audit_log(audit_context(), GFP_ATOMIC,
The kernel stack can be more consistent by printing the IFF_PROMISC aka promiscuous enable/disable messages with the standard netdev_info message which can include bus and driver info as well as the device. typical command usage from user space looks like: ip link set eth0 promisc <on|off> But lots of utilities such as bridge, tcpdump, etc put the interface into promiscuous mode. old message: [ 406.034418] device eth0 entered promiscuous mode [ 408.424703] device eth0 left promiscuous mode new message: [ 406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode [ 408.424715] ice 0000:17:00.0 eth0: left promiscuous mode Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- I'm unsure about this one because it's changing a long standard kernel message to a slightly different format. I think the new way looks better and has more information. --- net/core/dev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)