| Message ID | 20230214084206.1412423-1-horatiu.vultur@microchip.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: lan966x: Use automatic selection of VCAP rule actionset | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote: > Now the VCAP API automatically selects the action set, therefore is > not needed to be hardcoded anymore to hardcode the action in the > lan966x. Therefore remove this. The commit message needs some attention here. While at it - instead of saying "now" could you provide the commit reference? E.g. "Since commit $hash ("$title") the VCAP API...".
The 02/15/2023 21:30, Jakub Kicinski wrote: Hi Jakub, > > On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote: > > Now the VCAP API automatically selects the action set, therefore is > > not needed to be hardcoded anymore to hardcode the action in the > > lan966x. Therefore remove this. > > The commit message needs some attention here. > While at it - instead of saying "now" could you provide the commit > reference? E.g. "Since commit $hash ("$title") the VCAP API...". I will update this in the next version. Thanks for the feedback!
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c index bd10a71897418..f960727ecaeec 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c @@ -261,8 +261,6 @@ static int lan966x_tc_flower_add(struct lan966x_port *port, 0); err |= vcap_rule_add_action_u32(vrule, VCAP_AF_MASK_MODE, LAN966X_PMM_REPLACE); - err |= vcap_set_rule_set_actionset(vrule, - VCAP_AFS_BASE_TYPE); if (err) goto out;
Now the VCAP API automatically selects the action set, therefore is not needed to be hardcoded anymore to hardcode the action in the lan966x. Therefore remove this. Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> --- drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c | 2 -- 1 file changed, 2 deletions(-)