| Message ID | 20230217155838.848403-3-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a93af4677e8c3db24eeeb0498bee83b6b7e341fe |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: sc7180-trogdor-pazquel360: drop incorrect RT5682S VBAT-supply | expand |
On 17.02.2023 16:58, Krzysztof Kozlowski wrote: > Device node names should be generic and bindings expect certain pattern > for RPMh regulator nodes. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > I was fixing these in other boards, but missed SC7280. Previous > (applied) set: > https://lore.kernel.org/r/20230127114347.235963-4-krzysztof.kozlowski@linaro.org > --- > arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 ++-- > 5 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > index 1185141f348e..afae7f46b050 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts > @@ -27,7 +27,7 @@ chosen { > }; > > &apps_rsc { > - pmg1110-regulators { > + regulators-2 { > compatible = "qcom,pmg1110-rpmh-regulators"; > qcom,pmic-id = "k"; > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts > index 4e0b013e25f4..df39a64da923 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts > @@ -40,7 +40,7 @@ vreg_edp_bl_crd: vreg-edp-bl-crd-regulator { > /* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */ > > &apps_rsc { > - pmg1110-regulators { > + regulators-2 { > compatible = "qcom,pmg1110-rpmh-regulators"; > qcom,pmic-id = "k"; > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > index ba64316b4427..15222e92e3f5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > @@ -25,7 +25,7 @@ chosen { > }; > > &apps_rsc { > - pmr735a-regulators { > + regulators-2 { > compatible = "qcom,pmr735a-rpmh-regulators"; > qcom,pmic-id = "e"; > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 8b5293e7fd2a..8ebcf763b3c7 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -184,7 +184,7 @@ codec { > }; > > &apps_rsc { > - pm7325-regulators { > + regulators-0 { > compatible = "qcom,pm7325-rpmh-regulators"; > qcom,pmic-id = "b"; > > @@ -279,7 +279,7 @@ vreg_l19b_1p8: ldo19 { > }; > }; > > - pm8350c-regulators { > + regulators-1 { > compatible = "qcom,pm8350c-rpmh-regulators"; > qcom,pmic-id = "c"; > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi > index 88204f794ccb..cb0cc2ba2fa3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi > @@ -87,7 +87,7 @@ &apps_rsc { > * are left out of here since they are managed elsewhere. > */ > > - pm7325-regulators { > + regulators-0 { > compatible = "qcom,pm7325-rpmh-regulators"; > qcom,pmic-id = "b"; > > @@ -188,7 +188,7 @@ vreg_l19b_1p8: ldo19 { > }; > }; > > - pm8350c-regulators { > + regulators-1 { > compatible = "qcom,pm8350c-rpmh-regulators"; > qcom,pmic-id = "c"; >
Hi, On Fri, Feb 17, 2023 at 7:58 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Device node names should be generic and bindings expect certain pattern > for RPMh regulator nodes. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I was fixing these in other boards, but missed SC7280. Previous > (applied) set: > https://lore.kernel.org/r/20230127114347.235963-4-krzysztof.kozlowski@linaro.org > --- > arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++-- > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 ++-- > 5 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts index 1185141f348e..afae7f46b050 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts @@ -27,7 +27,7 @@ chosen { }; &apps_rsc { - pmg1110-regulators { + regulators-2 { compatible = "qcom,pmg1110-rpmh-regulators"; qcom,pmic-id = "k"; diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts index 4e0b013e25f4..df39a64da923 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts @@ -40,7 +40,7 @@ vreg_edp_bl_crd: vreg-edp-bl-crd-regulator { /* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */ &apps_rsc { - pmg1110-regulators { + regulators-2 { compatible = "qcom,pmg1110-rpmh-regulators"; qcom,pmic-id = "k"; diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts index ba64316b4427..15222e92e3f5 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts @@ -25,7 +25,7 @@ chosen { }; &apps_rsc { - pmr735a-regulators { + regulators-2 { compatible = "qcom,pmr735a-rpmh-regulators"; qcom,pmic-id = "e"; diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 8b5293e7fd2a..8ebcf763b3c7 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -184,7 +184,7 @@ codec { }; &apps_rsc { - pm7325-regulators { + regulators-0 { compatible = "qcom,pm7325-rpmh-regulators"; qcom,pmic-id = "b"; @@ -279,7 +279,7 @@ vreg_l19b_1p8: ldo19 { }; }; - pm8350c-regulators { + regulators-1 { compatible = "qcom,pm8350c-rpmh-regulators"; qcom,pmic-id = "c"; diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi index 88204f794ccb..cb0cc2ba2fa3 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -87,7 +87,7 @@ &apps_rsc { * are left out of here since they are managed elsewhere. */ - pm7325-regulators { + regulators-0 { compatible = "qcom,pm7325-rpmh-regulators"; qcom,pmic-id = "b"; @@ -188,7 +188,7 @@ vreg_l19b_1p8: ldo19 { }; }; - pm8350c-regulators { + regulators-1 { compatible = "qcom,pm8350c-rpmh-regulators"; qcom,pmic-id = "c";
Device node names should be generic and bindings expect certain pattern for RPMh regulator nodes. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- I was fixing these in other boards, but missed SC7280. Previous (applied) set: https://lore.kernel.org/r/20230127114347.235963-4-krzysztof.kozlowski@linaro.org --- arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 2 +- arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 2 +- arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++-- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-)