| Message ID | 20230217105017.21057-1-michal.swiatkowski@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8173c2f9a1a4a5afcf465a62bc8b616c1fef252d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1] ice: properly alloc ICE_VSI_LB | expand |
From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Date: Fri, 17 Feb 2023 11:50:17 +0100 > Devlink reload patchset introduced regression. ICE_VSI_LB wasn't > taken into account when doing default allocation. Fix it by adding a > case for ICE_VSI_LB in ice_vsi_alloc_def(). > > Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") > Reported-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> > Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com> Too late for 'net-final' PR which did hit the main tree already and I believe there won't be any more until 6.2 is out, so expect it in 6.2.1 only :s > --- > drivers/net/ethernet/intel/ice/ice_lib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c > index 5e81f7ae252c..3c41ebfc23d8 100644 > --- a/drivers/net/ethernet/intel/ice/ice_lib.c > +++ b/drivers/net/ethernet/intel/ice/ice_lib.c > @@ -627,6 +627,7 @@ ice_vsi_alloc_def(struct ice_vsi *vsi, struct ice_channel *ch) > vsi->next_base_q = ch->base_q; > break; > case ICE_VSI_VF: > + case ICE_VSI_LB: > break; > default: > ice_vsi_free_arrays(vsi); Thanks, Olek
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 17 Feb 2023 11:50:17 +0100 you wrote: > Devlink reload patchset introduced regression. ICE_VSI_LB wasn't > taken into account when doing default allocation. Fix it by adding a > case for ICE_VSI_LB in ice_vsi_alloc_def(). > > Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") > Reported-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> > Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > > [...] Here is the summary with links: - [net-next,v1] ice: properly alloc ICE_VSI_LB https://git.kernel.org/netdev/net-next/c/8173c2f9a1a4 You are awesome, thank you!
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index 5e81f7ae252c..3c41ebfc23d8 100644 --- a/drivers/net/ethernet/intel/ice/ice_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_lib.c @@ -627,6 +627,7 @@ ice_vsi_alloc_def(struct ice_vsi *vsi, struct ice_channel *ch) vsi->next_base_q = ch->base_q; break; case ICE_VSI_VF: + case ICE_VSI_LB: break; default: ice_vsi_free_arrays(vsi);
Devlink reload patchset introduced regression. ICE_VSI_LB wasn't taken into account when doing default allocation. Fix it by adding a case for ICE_VSI_LB in ice_vsi_alloc_def(). Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") Reported-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> --- drivers/net/ethernet/intel/ice/ice_lib.c | 1 + 1 file changed, 1 insertion(+)