| Message ID | 20230201140417.89195-5-benjamin.mugnier@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: st-vgxy61: Power up sequence fixes | expand |
Hi Benjamin,
On Wed, Feb 01, 2023 at 03:04:17PM +0100, Benjamin Mugnier wrote:
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
I know this is a simple patch, but please add a commit message nonetheless.
Not having one produces a checkpatch.pl warning. Did you use it? :-)
Hi Sakari, On 2/14/23 00:01, Sakari Ailus wrote: > Hi Benjamin, > > On Wed, Feb 01, 2023 at 03:04:17PM +0100, Benjamin Mugnier wrote: >> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > > I know this is a simple patch, but please add a commit message nonetheless. > > Not having one produces a checkpatch.pl warning. Did you use it? :-) > It's even worse, I remember using checkpatch.pl on the source file directly but not on commits, so I missed it :'( I apologize. Here is the long commit message: tx_from_ep's for loop uses '5' as bound, while in fact it refers to the number of polarities. Replace it by VGXY61_NB_POLARITIES for factorization. Can you apply it directly to your tree, or do you want me to send a v2 with this fix? Thanks a ton.
diff --git a/drivers/media/i2c/st-vgxy61.c b/drivers/media/i2c/st-vgxy61.c index 2988ba60be94..33ff2cf20fbf 100644 --- a/drivers/media/i2c/st-vgxy61.c +++ b/drivers/media/i2c/st-vgxy61.c @@ -1546,7 +1546,7 @@ static int vgxy61_tx_from_ep(struct vgxy61_dev *sensor, sensor->nb_of_lane = l_nb; dev_dbg(&client->dev, "tx uses %d lanes", l_nb); - for (i = 0; i < 5; i++) { + for (i = 0; i < VGXY61_NB_POLARITIES; i++) { dev_dbg(&client->dev, "log2phy[%d] = %d\n", i, log2phy[i]); dev_dbg(&client->dev, "phy2log[%d] = %d\n", i, phy2log[i]); dev_dbg(&client->dev, "polarity[%d] = %d\n", i, polarities[i]);
Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> --- drivers/media/i2c/st-vgxy61.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)