[bpf-next,v2,0/7] Add support for kptrs in more BPF maps

Message

Kumar Kartikeya Dwivedi Feb. 21, 2023, 8:06 p.m. UTC

This set adds support for kptrs in percpu hashmaps, percpu LRU hashmaps,
and local storage maps (covering sk, cgrp, task, inode). There are also
minor miscellaneous cleanups rolled in, unrelated to the set, that I
collected over time. Feel free to drop them, they have been
intentionally placed after the kptr support to ease partial application
of the series.

Tests are expanded to test more existing maps at runtime and also test
the code path for the local storage maps (which is shared by all
implementations).

A question for reviewers is what the position of the BPF runtime should
be on dealing with reference cycles that can be created by BPF programs
at runtime using this additional support. For instance, one can store
the kptr of the task in its own task local storage, creating a cycle
which prevents destruction of task local storage. Cycles can be formed
using arbitrarily long kptr ownership chains. Therefore, just preventing
storage of such kptrs in some maps is not a sufficient solution, and is
more likely to hurt usability.

There is precedence in existing runtimes which promise memory safety,
like Rust, where reference cycles and memory leaks are permitted.
However, traditionally the safety guarantees of BPF have been stronger.
Thus, more discussion and thought is invited on this topic to ensure we
cover all usage aspects.

Changelog:
----------
v1 -> v2
v1: https://lore.kernel.org/bpf/[e-mail]

 * Simplify selftests, fix a couple of bugs

Kumar Kartikeya Dwivedi (7):
  bpf: Support kptrs in percpu hashmap and percpu LRU hashmap
  bpf: Support kptrs in local storage maps
  bpf: Annotate data races in bpf_local_storage
  bpf: Remove unused MEM_ALLOC | PTR_TRUSTED checks
  bpf: Fix check_reg_type for PTR_TO_BTF_ID
  bpf: Wrap register invalidation with a helper
  selftests/bpf: Add more tests for kptrs in maps

 kernel/bpf/bpf_local_storage.c                |  51 ++-
 kernel/bpf/hashtab.c                          |  59 +--
 kernel/bpf/syscall.c                          |   8 +-
 kernel/bpf/verifier.c                         |  65 ++--
 .../selftests/bpf/prog_tests/map_kptr.c       | 122 ++++--
 tools/testing/selftests/bpf/progs/map_kptr.c  | 353 +++++++++++++++---
 6 files changed, 540 insertions(+), 118 deletions(-)


base-commit: 951bce29c8988209cc359e1fa35a4aaa35542fd5

Comments

[e-mail] Feb. 22, 2023, 9 p.m. UTC | #1

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <[e-mail]>:

On Tue, 21 Feb 2023 21:06:39 +0100 you wrote:
> This set adds support for kptrs in percpu hashmaps, percpu LRU hashmaps,
> and local storage maps (covering sk, cgrp, task, inode). There are also
> minor miscellaneous cleanups rolled in, unrelated to the set, that I
> collected over time. Feel free to drop them, they have been
> intentionally placed after the kptr support to ease partial application
> of the series.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2,1/7] bpf: Support kptrs in percpu hashmap and percpu LRU hashmap
    (no matching commit)
  - [bpf-next,v2,2/7] bpf: Support kptrs in local storage maps
    (no matching commit)
  - [bpf-next,v2,3/7] bpf: Annotate data races in bpf_local_storage
    https://git.kernel.org/bpf/bpf-next/c/0a09a2f933c7
  - [bpf-next,v2,4/7] bpf: Remove unused MEM_ALLOC | PTR_TRUSTED checks
    https://git.kernel.org/bpf/bpf-next/c/521d3c0a1730
  - [bpf-next,v2,5/7] bpf: Fix check_reg_type for PTR_TO_BTF_ID
    https://git.kernel.org/bpf/bpf-next/c/da03e43a8c50
  - [bpf-next,v2,6/7] bpf: Wrap register invalidation with a helper
    https://git.kernel.org/bpf/bpf-next/c/dbd8d22863e8
  - [bpf-next,v2,7/7] selftests/bpf: Add more tests for kptrs in maps
    (no matching commit)

You are awesome, thank you!