[v5,0/2] Bluetooth: btrtl: add support for the RTL8723CS

Message

Bastian Germann Feb. 12, 2023, 12:41 p.m. UTC

Pinebook uses RTL8723CS for WiFi and bluetooth. Unfortunately, RTL8723CS
has broken BT-4.1 support, so it requires a quirk.

Add a quirk and wire up 8723CS support in btrtl.
I was asked for a btmon output without the quirk;
however, using the chip without the quirk ends up in a bad state with
"Opcode 0x c77 failed: -56" (HCI_OP_READ_SYNC_TRAIN_PARAMS) on training.
A btmon output with the quirk active was already sent by Vasily.

v1 of this series was sent in July 2020 by Vasily Khoruzhick.
I have tested it to work on the Pinebook.

Changelog:
v2:
   * Rebase
   * Add uart-has-rtscts to device tree as requested by reviewer
v3:
   * Drop the device tree as it was split out and is already integrated.
   * Rename the quirk as requested by reviewer Marcel Holtmann
v4:
   * Use skb_pull_data as requested by reviewer Luiz Augusto von Dentz
v5:
   * Make use of skb_pull_data's length check

Vasily Khoruzhick (2):
  Bluetooth: Add new quirk for broken local ext features page 2
  Bluetooth: btrtl: add support for the RTL8723CS

 drivers/bluetooth/btrtl.c   | 120 ++++++++++++++++++++++++++++++++++--
 drivers/bluetooth/btrtl.h   |   5 ++
 drivers/bluetooth/hci_h5.c  |   4 ++
 include/net/bluetooth/hci.h |   7 +++
 net/bluetooth/hci_event.c   |   4 +-
 5 files changed, 135 insertions(+), 5 deletions(-)

Comments

Bastian Germann Feb. 22, 2023, 10:44 p.m. UTC | #1

Am 12.02.23 um 13:41 schrieb Bastian Germann:
> v1 of this series was sent in July 2020 by Vasily Khoruzhick.
> I have tested it to work on the Pinebook.
> 
> Changelog:
> v2:
>     * Rebase
>     * Add uart-has-rtscts to device tree as requested by reviewer
> v3:
>     * Drop the device tree as it was split out and is already integrated.
>     * Rename the quirk as requested by reviewer Marcel Holtmann
> v4:
>     * Use skb_pull_data as requested by reviewer Luiz Augusto von Dentz
> v5:
>     * Make use of skb_pull_data's length check

I have addressed every comment.
Would you please consider integrating this 2.5 years old series?