| Message ID | 20230224175756.180480-1-pctammela@mojatatu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 70b9ebae63ce7e6f9911bdfbcf47a6d18f24159a |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <stephen@networkplumber.org>: On Fri, 24 Feb 2023 14:57:56 -0300 you wrote: > It should sit within the TCA_ACT_TAB hierarchy, otherwise the access to > tb is out of bounds: > ./tc action ls action csum > total acts 1 > > action order 0: csum (?empty) action pass > index 1 ref 1 bind 0 > not_in_hw > Segmentation fault (core dumped) > > [...] Here is the summary with links: - [iproute2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=70b9ebae63ce You are awesome, thank you!
diff --git a/tc/m_action.c b/tc/m_action.c index 0400132c..6c91af2c 100644 --- a/tc/m_action.c +++ b/tc/m_action.c @@ -586,7 +586,7 @@ int print_action(struct nlmsghdr *n, void *arg) open_json_object(NULL); tc_dump_action(fp, tb[TCA_ACT_TAB], tot_acts ? *tot_acts:0, false); - print_ext_msg(tb); + print_ext_msg(&tb[TCA_ACT_TAB]); close_json_object(); return 0;
It should sit within the TCA_ACT_TAB hierarchy, otherwise the access to tb is out of bounds: ./tc action ls action csum total acts 1 action order 0: csum (?empty) action pass index 1 ref 1 bind 0 not_in_hw Segmentation fault (core dumped) Fixes: 60359956 ("tc: add new attr TCA_EXT_WARN_MSG") Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: Pedro Tammela <pctammela@mojatatu.com> --- tc/m_action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)