| Message ID | 20230222005228.158661-3-tony.obrien@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (adt7475) Fixes for acoustics and hysteresis | expand |
On Wed, Feb 22, 2023 at 01:52:28PM +1300, Tony O'Brien wrote: > The wrong bits are masked in the hysteresis register; indices 0 and 2 > should zero bits [7:4] and preserve bits [3:0], and index 1 should zero > bits [3:0] and preserve bits [7:4]. > > Fixes: 1c301fc5394f ("hwmon: Add a driver for the ADT7475 hardware monitoring chip") > Signed-off-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz> Applied. Thanks, Guenter
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c index 77222c35a38e..6e4c92b500b8 100644 --- a/drivers/hwmon/adt7475.c +++ b/drivers/hwmon/adt7475.c @@ -488,10 +488,10 @@ static ssize_t temp_store(struct device *dev, struct device_attribute *attr, val = (temp - val) / 1000; if (sattr->index != 1) { - data->temp[HYSTERSIS][sattr->index] &= 0xF0; + data->temp[HYSTERSIS][sattr->index] &= 0x0F; data->temp[HYSTERSIS][sattr->index] |= (val & 0xF) << 4; } else { - data->temp[HYSTERSIS][sattr->index] &= 0x0F; + data->temp[HYSTERSIS][sattr->index] &= 0xF0; data->temp[HYSTERSIS][sattr->index] |= (val & 0xF); }
The wrong bits are masked in the hysteresis register; indices 0 and 2 should zero bits [7:4] and preserve bits [3:0], and index 1 should zero bits [3:0] and preserve bits [7:4]. Fixes: 1c301fc5394f ("hwmon: Add a driver for the ADT7475 hardware monitoring chip") Signed-off-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz> --- Changes in v2: - Patch headline changed. - Removed erroneous fix for clamping the hysteresis value. It should be an absolute value and not a relative value. drivers/hwmon/adt7475.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)