| Message ID | MA0PR01MB7145D1E9382C7F91197B259FFFA99@MA0PR01MB7145.INDPRD01.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM64: dts: debix model-a: enable hdmi | expand |
Hi Hardevsinh,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on linus/master next-20230225]
[cannot apply to v6.2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hardevsinh-Palaniya/ARM64-dts-debix-model-a-enable-hdmi/20230225-222532
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link: https://lore.kernel.org/r/MA0PR01MB7145D1E9382C7F91197B259FFFA99%40MA0PR01MB7145.INDPRD01.PROD.OUTLOOK.COM
patch subject: [PATCH] ARM64: dts: debix model-a: enable hdmi
config: arm64-randconfig-r014-20230222 (https://download.01.org/0day-ci/archive/20230225/202302252343.4lnZcpLX-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db89896bbbd2251fff457699635acbbedeead27f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/169f8a9904944622235b3485702d64ac942af621
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Hardevsinh-Palaniya/ARM64-dts-debix-model-a-enable-hdmi/20230225-222532
git checkout 169f8a9904944622235b3485702d64ac942af621
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302252343.4lnZcpLX-lkp@intel.com/
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts:49.1-15 Label or path irqsteer_hdmi not found
>> Error: arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts:53.1-15 Label or path hdmi_blk_ctrl not found
>> Error: arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts:57.1-11 Label or path hdmi_pavi not found
>> Error: arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts:61.1-6 Label or path hdmi not found
>> Error: arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts:65.1-9 Label or path hdmiphy not found
>> Error: arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts:69.1-8 Label or path lcdif1 not found
>> Error: arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts:77.1-8 Label or path lcdif3 not found
FATAL ERROR: Syntax error parsing input tree
On 25/02/2023 15:25, Hardevsinh Palaniya wrote: > From: HardevSinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > Date: Sat, 25 Feb 2023 19:38:20 +0530 > Subject: [PATCH] arm64: dts: debix model-a: enable hdmi Your patch is corrupted... See above. > > Enable HDMI support for Polyhex Debix Model A Board Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). > > Signed-off-by: HardevSinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > index 2876d18f2a38..bc2515113ae3 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > @@ -45,6 +45,43 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > }; > }; > > + No need for two blank lines, but one. > +&irqsteer_hdmi { > + status = "okay"; > +}; > + > +&hdmi_blk_ctrl { > + status = "okay"; > +}; > + > +&hdmi_pavi { > + status = "okay"; > +}; > + > +&hdmi { > + status = "okay"; > +}; > + > +&hdmiphy { > + status = "okay"; > +}; > + > +&lcdif1 { > + status = "okay"; > +}; > + > +&lcdif2 { > + status = "okay"; > +}; > + > +&lcdif3 { > + status = "okay"; > + > + thres-low = <1 2>; /* (FIFO * 1 / 2) */ > + thres-high = <3 4>; /* (FIFO * 3 / 4) */ > +}; > + > + Same problem. > &A53_0 { > cpu-supply = <&buck2>; > }; Best regards, Krzysztof
Hi, thanks for your patch, please see my comments below. On 23-02-25, Krzysztof Kozlowski wrote: > On 25/02/2023 15:25, Hardevsinh Palaniya wrote: > > From: HardevSinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > > Date: Sat, 25 Feb 2023 19:38:20 +0530 > > Subject: [PATCH] arm64: dts: debix model-a: enable hdmi > > Your patch is corrupted... See above. > > > > > Enable HDMI support for Polyhex Debix Model A Board > > Use subject prefixes matching the subsystem (which you can get for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching). > > > > > Signed-off-by: HardevSinh Palaniya <hardevsinh.palaniya@siliconsignals.io> > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > > index 2876d18f2a38..bc2515113ae3 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts > > @@ -45,6 +45,43 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > > }; > > }; > > > > + > > No need for two blank lines, but one. > > > > +&irqsteer_hdmi { > > + status = "okay"; > > +}; > > + > > +&hdmi_blk_ctrl { > > + status = "okay"; > > +}; > > + > > +&hdmi_pavi { > > + status = "okay"; > > +}; > > + > > +&hdmi { > > + status = "okay"; > > +}; > > + > > +&hdmiphy { > > + status = "okay"; > > +}; > > + > > +&lcdif1 { > > + status = "okay"; > > +}; > > + > > +&lcdif2 { > > + status = "okay"; > > +}; > > + > > +&lcdif3 { > > + status = "okay"; > > + > > + thres-low = <1 2>; /* (FIFO * 1 / 2) */ > > + thres-high = <3 4>; /* (FIFO * 3 / 4) */ Isn't this a downstream property? Regards, Marco > > +}; > > + > > + > > Same problem. > > > &A53_0 { > > cpu-supply = <&buck2>; > > }; > > Best regards, > Krzysztof > > >
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts index 2876d18f2a38..bc2515113ae3 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts @@ -45,6 +45,43 @@ reg_usdhc2_vmmc: regulator-usdhc2 { }; }; + +&irqsteer_hdmi { + status = "okay"; +}; + +&hdmi_blk_ctrl { + status = "okay"; +}; + +&hdmi_pavi { + status = "okay"; +}; + +&hdmi { + status = "okay"; +}; + +&hdmiphy { + status = "okay"; +}; + +&lcdif1 { + status = "okay"; +}; + +&lcdif2 { + status = "okay"; +}; + +&lcdif3 { + status = "okay"; + + thres-low = <1 2>; /* (FIFO * 1 / 2) */ + thres-high = <3 4>; /* (FIFO * 3 / 4) */ +}; + + &A53_0 { cpu-supply = <&buck2>; };