| Message ID | 20230226053953.4681-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drivers: select REGMAP instead of depending on it | expand |
Hi Randy, On 2/26/23 06:39, Randy Dunlap wrote: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > REGMAP is selected 94 times and is depended on 11 times in > current linux-next. Eliminate the uses of "depends on" by > converting them to "select". Thank you for your work on this. Mixing of depends on vs select is a real problem with many Kconfig symbols. > [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it > [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it > [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it > [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it > [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it > [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it > [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it > [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it For patch 5/8 and 6/8, do you want me to merge them through the pdx86 (platform-drivers-x86) tree, or do you plan to merge this whole series in one go through some other tree? If you plan to merge the whole series through some other tree, here is my acked by for doing so for 5/8 and 6/8: Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > > diffstat: > drivers/char/ipmi/Kconfig | 3 ++- > drivers/clk/Kconfig | 2 +- > drivers/gpio/Kconfig | 2 +- > drivers/leds/Kconfig | 2 +- > drivers/platform/mellanox/Kconfig | 9 ++++----- > drivers/platform/x86/Kconfig | 3 ++- > drivers/thermal/intel/Kconfig | 3 ++- > drivers/tty/serial/8250/Kconfig | 3 ++- > 8 files changed, 15 insertions(+), 12 deletions(-) > > Cc: Andrew Jeffery <andrew@aj.id.au> > Cc: Corey Minyard <minyard@acm.org> > Cc: openipmi-developer@lists.sourceforge.net > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Riku Voipio <riku.voipio@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: linux-clk@vger.kernel.org > Cc: Michael Walle <michael@walle.cc> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: linux-gpio@vger.kernel.org > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Lee Jones <lee@kernel.org> > Cc: linux-leds@vger.kernel.org > Cc: Darren Hart <dvhart@infradead.org> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Michael Shych <michaelsh@nvidia.com> > Cc: Mark Gross <markgross@kernel.org> > Cc: Vadim Pasternak <vadimp@nvidia.com> > Cc: platform-driver-x86@vger.kernel.org > Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com> > Cc: Bin Gao <bin.gao@intel.com> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Amit Kucheria <amitk@kernel.org> > Cc: linux-pm@vger.kernel.org > Cc: Oskar Senft <osk@google.com> > Cc: linux-serial@vger.kernel.org >
On 2/27/23 01:31, Hans de Goede wrote: > Hi Randy, > > On 2/26/23 06:39, Randy Dunlap wrote: >> REGMAP is a hidden (not user visible) symbol. Users cannot set it >> directly thru "make *config", so drivers should select it instead of >> depending on it if they need it. >> >> Consistently using "select" or "depends on" can also help reduce >> Kconfig circular dependency issues. >> >> REGMAP is selected 94 times and is depended on 11 times in >> current linux-next. Eliminate the uses of "depends on" by >> converting them to "select". > > Thank you for your work on this. Mixing of depends on vs select > is a real problem with many Kconfig symbols. > >> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it >> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it >> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it >> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it >> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it >> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it >> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it >> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it > > For patch 5/8 and 6/8, do you want me to merge them through the pdx86 > (platform-drivers-x86) tree, or do you plan to merge this whole series > in one go through some other tree? Hi Hans, Please merge them thru the pdx86 tree. Thanks. > If you plan to merge the whole series through some other tree, > here is my acked by for doing so for 5/8 and 6/8: > > Acked-by: Hans de Goede <hdegoede@redhat.com> > > Regards, > > Hans > > > > >> >> diffstat: >> drivers/char/ipmi/Kconfig | 3 ++- >> drivers/clk/Kconfig | 2 +- >> drivers/gpio/Kconfig | 2 +- >> drivers/leds/Kconfig | 2 +- >> drivers/platform/mellanox/Kconfig | 9 ++++----- >> drivers/platform/x86/Kconfig | 3 ++- >> drivers/thermal/intel/Kconfig | 3 ++- >> drivers/tty/serial/8250/Kconfig | 3 ++- >> 8 files changed, 15 insertions(+), 12 deletions(-) >> >> Cc: Andrew Jeffery <andrew@aj.id.au> >> Cc: Corey Minyard <minyard@acm.org> >> Cc: openipmi-developer@lists.sourceforge.net >> Cc: Arnd Bergmann <arnd@arndb.de> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Riku Voipio <riku.voipio@linaro.org> >> Cc: Stephen Boyd <sboyd@kernel.org> >> Cc: Michael Turquette <mturquette@baylibre.com> >> Cc: linux-clk@vger.kernel.org >> Cc: Michael Walle <michael@walle.cc> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Bartosz Golaszewski <brgl@bgdev.pl> >> Cc: linux-gpio@vger.kernel.org >> Cc: Dan Murphy <dmurphy@ti.com> >> Cc: Pavel Machek <pavel@ucw.cz> >> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> >> Cc: Lee Jones <lee@kernel.org> >> Cc: linux-leds@vger.kernel.org >> Cc: Darren Hart <dvhart@infradead.org> >> Cc: Hans de Goede <hdegoede@redhat.com> >> Cc: Michael Shych <michaelsh@nvidia.com> >> Cc: Mark Gross <markgross@kernel.org> >> Cc: Vadim Pasternak <vadimp@nvidia.com> >> Cc: platform-driver-x86@vger.kernel.org >> Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com> >> Cc: Bin Gao <bin.gao@intel.com> >> Cc: Zhang Rui <rui.zhang@intel.com> >> Cc: "Rafael J. Wysocki" <rafael@kernel.org> >> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> >> Cc: Amit Kucheria <amitk@kernel.org> >> Cc: linux-pm@vger.kernel.org >> Cc: Oskar Senft <osk@google.com> >> Cc: linux-serial@vger.kernel.org >> >
Hi, On 2/27/23 17:07, Randy Dunlap wrote: > > > On 2/27/23 01:31, Hans de Goede wrote: >> Hi Randy, >> >> On 2/26/23 06:39, Randy Dunlap wrote: >>> REGMAP is a hidden (not user visible) symbol. Users cannot set it >>> directly thru "make *config", so drivers should select it instead of >>> depending on it if they need it. >>> >>> Consistently using "select" or "depends on" can also help reduce >>> Kconfig circular dependency issues. >>> >>> REGMAP is selected 94 times and is depended on 11 times in >>> current linux-next. Eliminate the uses of "depends on" by >>> converting them to "select". >> >> Thank you for your work on this. Mixing of depends on vs select >> is a real problem with many Kconfig symbols. >> >>> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it >>> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it >>> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it >>> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it >>> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it >>> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it >>> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it >>> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it >> >> For patch 5/8 and 6/8, do you want me to merge them through the pdx86 >> (platform-drivers-x86) tree, or do you plan to merge this whole series >> in one go through some other tree? > > Hi Hans, > Please merge them thru the pdx86 tree. Ok, I've applied patch 5/8 + 6/8 to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I'll rebase that branch once 6.3-rc1 is out and then push the rebased patch to the fixes branch and include it in my next 6.3 fixes pull-req to Linus. Regards, Hans >>> >>> diffstat: >>> drivers/char/ipmi/Kconfig | 3 ++- >>> drivers/clk/Kconfig | 2 +- >>> drivers/gpio/Kconfig | 2 +- >>> drivers/leds/Kconfig | 2 +- >>> drivers/platform/mellanox/Kconfig | 9 ++++----- >>> drivers/platform/x86/Kconfig | 3 ++- >>> drivers/thermal/intel/Kconfig | 3 ++- >>> drivers/tty/serial/8250/Kconfig | 3 ++- >>> 8 files changed, 15 insertions(+), 12 deletions(-) >>> >>> Cc: Andrew Jeffery <andrew@aj.id.au> >>> Cc: Corey Minyard <minyard@acm.org> >>> Cc: openipmi-developer@lists.sourceforge.net >>> Cc: Arnd Bergmann <arnd@arndb.de> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>> Cc: Riku Voipio <riku.voipio@linaro.org> >>> Cc: Stephen Boyd <sboyd@kernel.org> >>> Cc: Michael Turquette <mturquette@baylibre.com> >>> Cc: linux-clk@vger.kernel.org >>> Cc: Michael Walle <michael@walle.cc> >>> Cc: Linus Walleij <linus.walleij@linaro.org> >>> Cc: Bartosz Golaszewski <brgl@bgdev.pl> >>> Cc: linux-gpio@vger.kernel.org >>> Cc: Dan Murphy <dmurphy@ti.com> >>> Cc: Pavel Machek <pavel@ucw.cz> >>> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> >>> Cc: Lee Jones <lee@kernel.org> >>> Cc: linux-leds@vger.kernel.org >>> Cc: Darren Hart <dvhart@infradead.org> >>> Cc: Hans de Goede <hdegoede@redhat.com> >>> Cc: Michael Shych <michaelsh@nvidia.com> >>> Cc: Mark Gross <markgross@kernel.org> >>> Cc: Vadim Pasternak <vadimp@nvidia.com> >>> Cc: platform-driver-x86@vger.kernel.org >>> Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com> >>> Cc: Bin Gao <bin.gao@intel.com> >>> Cc: Zhang Rui <rui.zhang@intel.com> >>> Cc: "Rafael J. Wysocki" <rafael@kernel.org> >>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> >>> Cc: Amit Kucheria <amitk@kernel.org> >>> Cc: linux-pm@vger.kernel.org >>> Cc: Oskar Senft <osk@google.com> >>> Cc: linux-serial@vger.kernel.org >>> >> >