| Message ID | Y/yQ+kk/cQdXKBLw@kili (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net/mlx5: E-Switch, Fix an Oops in error handling code | expand |
On 27/02/2023 13:16, Dan Carpenter wrote: > The error handling dereferences "vport". There is nothing we can do if > it is an error pointer except returning the error code. > > Fixes: 133dcfc577ea ("net/mlx5: E-Switch, Alloc and free unique metadata for match") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c > index d55775627a47..50d2ea323979 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c > @@ -364,8 +364,7 @@ int mlx5_esw_acl_ingress_vport_metadata_update(struct mlx5_eswitch *esw, u16 vpo > > if (WARN_ON_ONCE(IS_ERR(vport))) { > esw_warn(esw->dev, "vport(%d) invalid!\n", vport_num); > - err = PTR_ERR(vport); > - goto out; > + return PTR_ERR(vport); > } > > esw_acl_ingress_ofld_rules_destroy(esw, vport); thanks Reviewed-by: Roi Dayan <roid@nvidia.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c index d55775627a47..50d2ea323979 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c @@ -364,8 +364,7 @@ int mlx5_esw_acl_ingress_vport_metadata_update(struct mlx5_eswitch *esw, u16 vpo if (WARN_ON_ONCE(IS_ERR(vport))) { esw_warn(esw->dev, "vport(%d) invalid!\n", vport_num); - err = PTR_ERR(vport); - goto out; + return PTR_ERR(vport); } esw_acl_ingress_ofld_rules_destroy(esw, vport);
The error handling dereferences "vport". There is nothing we can do if it is an error pointer except returning the error code. Fixes: 133dcfc577ea ("net/mlx5: E-Switch, Alloc and free unique metadata for match") Signed-off-by: Dan Carpenter <error27@gmail.com> --- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)