| Message ID | 20230227185907.569154-1-wse@tuxedocomputers.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix "Input: i8042 - add TUXEDO devices to i8042 quirk tables for partial fix" | expand |
Hi Werner, On 2/27/23 19:59, Werner Sembach wrote: > This is a continuation of > https://lore.kernel.org/linux-input/20220708161005.1251929-3-wse@tuxedocomputers.com/ > > That fix did fix the keyboard not responding at all sometimes after resume, > but at the price of it being laggy for some time after boot. Additionally > setting atkbd.reset removes that lag. > > This patch comes in 2 parts: The first one adds a quirk to atkbd to set > atkbd.reset and the second one then applies that and the i8042 quirks to > the affected devices. Can you please rework this series so that the quirk based setting of the "atkbd.reset" equivalent on the kernel commandline becomes another SERIO_QUIRK_* flag and avoid the duplication of the DMI ids? Regards, Hans
Am 28.02.23 um 09:41 schrieb Hans de Goede: > Hi Werner, > > On 2/27/23 19:59, Werner Sembach wrote: >> This is a continuation of >> https://lore.kernel.org/linux-input/20220708161005.1251929-3-wse@tuxedocomputers.com/ >> >> That fix did fix the keyboard not responding at all sometimes after resume, >> but at the price of it being laggy for some time after boot. Additionally >> setting atkbd.reset removes that lag. >> >> This patch comes in 2 parts: The first one adds a quirk to atkbd to set >> atkbd.reset and the second one then applies that and the i8042 quirks to >> the affected devices. > Can you please rework this series so that the quirk based setting of > the "atkbd.reset" equivalent on the kernel commandline becomes another > SERIO_QUIRK_* flag and avoid the duplication of the DMI ids? I'm not sure how to cleanly do this, since atkbd is an own module? Kind Regards, Werner > > Regards, > > Hans > > >
Am 27.02.23 um 19:59 schrieb Werner Sembach: > This is a continuation of > https://lore.kernel.org/linux-input/20220708161005.1251929-3-wse@tuxedocomputers.com/ > > That fix did fix the keyboard not responding at all sometimes after resume, > but at the price of it being laggy for some time after boot. Additionally > setting atkbd.reset removes that lag. > > This patch comes in 2 parts: The first one adds a quirk to atkbd to set > atkbd.reset and the second one then applies that and the i8042 quirks to > the affected devices. > > Somehow, for my testing last week these patches seemed work, but now i still see occasional laggy keyboard after boot. So sadly the atkbd_reset quirk didn't fix the issue after all.
Hi, On 3/1/23 17:57, Werner Sembach wrote: > > Am 27.02.23 um 19:59 schrieb Werner Sembach: >> This is a continuation of >> https://lore.kernel.org/linux-input/20220708161005.1251929-3-wse@tuxedocomputers.com/ >> >> That fix did fix the keyboard not responding at all sometimes after resume, >> but at the price of it being laggy for some time after boot. Additionally >> setting atkbd.reset removes that lag. >> >> This patch comes in 2 parts: The first one adds a quirk to atkbd to set >> atkbd.reset and the second one then applies that and the i8042 quirks to >> the affected devices. >> >> > Somehow, for my testing last week these patches seemed work, but now i still see occasional laggy keyboard after boot. So sadly the atkbd_reset quirk didn't fix the issue after all. Ok, well I guess that also resolves the discussion about trying to avoid the duplicate DMI table entries. FWIW I did not realize that the other quirk was in another module and I don't have a good answer how to solve this in a way that avoids adding the DMI matches twice. Regards, Hans