| Message ID | 1677533800-3125-1-git-send-email-quic_khsieh@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/msm/disp/dpu: fix sc7280_pp base offset | expand |
On 2/27/2023 1:36 PM, Kuogee Hsieh wrote: > At sc7280, pingpong block is used to management the dither effects > to reduce distortion at panel. Currently pingpong-0 base offset is > wrongly set at 0x59000. This mistake will not cause system to crash. > However it will make dither not work. This patch correct sc7280 ping > pong-0 block base offset. > > Changes in v2: > -- add more details info n regrading of pingpong block at commit text > > Fixes: 591e34a091d1 ("drm/msm/disp/dpu1: add support for display for SC7280 target") > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index 7deffc9f9..286437e 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > @@ -1707,7 +1707,7 @@ static const struct dpu_pingpong_cfg sm8350_pp[] = { > }; > > static const struct dpu_pingpong_cfg sc7280_pp[] = { > - PP_BLK("pingpong_0", PINGPONG_0, 0x59000, 0, sc7280_pp_sblk, -1, -1), > + PP_BLK("pingpong_0", PINGPONG_0, 0x69000, 0, sc7280_pp_sblk, -1, -1), > PP_BLK("pingpong_1", PINGPONG_1, 0x6a000, 0, sc7280_pp_sblk, -1, -1), > PP_BLK("pingpong_2", PINGPONG_2, 0x6b000, 0, sc7280_pp_sblk, -1, -1), > PP_BLK("pingpong_3", PINGPONG_3, 0x6c000, 0, sc7280_pp_sblk, -1, -1),
On 27/02/2023 23:36, Kuogee Hsieh wrote: > At sc7280, pingpong block is used to management the dither effects > to reduce distortion at panel. Currently pingpong-0 base offset is > wrongly set at 0x59000. This mistake will not cause system to crash. > However it will make dither not work. This patch correct sc7280 ping > pong-0 block base offset. > > Changes in v2: > -- add more details info n regrading of pingpong block at commit text > > Fixes: 591e34a091d1 ("drm/msm/disp/dpu1: add support for display for SC7280 target") > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Mon, 27 Feb 2023 13:36:40 -0800, Kuogee Hsieh wrote: > At sc7280, pingpong block is used to management the dither effects > to reduce distortion at panel. Currently pingpong-0 base offset is > wrongly set at 0x59000. This mistake will not cause system to crash. > However it will make dither not work. This patch correct sc7280 ping > pong-0 block base offset. > > Changes in v2: > -- add more details info n regrading of pingpong block at commit text > > [...] Applied, thanks! [1/1] drm/msm/disp/dpu: fix sc7280_pp base offset https://gitlab.freedesktop.org/drm/msm/-/commit/ce68153edb5b Best regards,
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index 7deffc9f9..286437e 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -1707,7 +1707,7 @@ static const struct dpu_pingpong_cfg sm8350_pp[] = { }; static const struct dpu_pingpong_cfg sc7280_pp[] = { - PP_BLK("pingpong_0", PINGPONG_0, 0x59000, 0, sc7280_pp_sblk, -1, -1), + PP_BLK("pingpong_0", PINGPONG_0, 0x69000, 0, sc7280_pp_sblk, -1, -1), PP_BLK("pingpong_1", PINGPONG_1, 0x6a000, 0, sc7280_pp_sblk, -1, -1), PP_BLK("pingpong_2", PINGPONG_2, 0x6b000, 0, sc7280_pp_sblk, -1, -1), PP_BLK("pingpong_3", PINGPONG_3, 0x6c000, 0, sc7280_pp_sblk, -1, -1),
At sc7280, pingpong block is used to management the dither effects to reduce distortion at panel. Currently pingpong-0 base offset is wrongly set at 0x59000. This mistake will not cause system to crash. However it will make dither not work. This patch correct sc7280 ping pong-0 block base offset. Changes in v2: -- add more details info n regrading of pingpong block at commit text Fixes: 591e34a091d1 ("drm/msm/disp/dpu1: add support for display for SC7280 target") Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)