| Message ID | 20230301095523.428461-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Enable GPU with DVFS support on MediaTek SoCs | expand |
Series looks good but from my understanding has a dependency on: [PATCH v4 00/12] Panfrost: Improve and add MediaTek SoCs support (https://lore.kernel.org/linux-mediatek/20230228102610.707605-1-angelogioacchino.delregno@collabora.com/) Did I get that right? Regards, Matthias On 01/03/2023 10:55, AngeloGioacchino Del Regno wrote: > Changes in v4: > - Added a fix for MT8192 Vgpu voltage constraints > - Changed constraints for MT8192 VSRAM-GPU to reflect the maximum > achievable voltage as per the actual vsram-vgpu relation constraint > > Changes in v3: > - Changed MT8186 compatibles for new bindings > - Added min/max voltage overrides for vgpu/vsram_gpu on > mt8183-pumpkin and evb as suggested by Chen-Yu > - Cosmetic fixes for "arm64: dts: mediatek: mt8192: Add GPU nodes" > > Changes in v2: > - Changed MT8186 to use only two power domains for the GPU. > > We finally have working GPU DVFS on MediaTek SoCs. > On Panfrost. > For real. > ...and the best part is that it's going upstream. > > In order to get GPU DVFS working, it was necessary to satisfy a > specific constraint (which is different, depending on the SoC) > between two regulators: GPU VCORE and GPU SRAM. > This was done through adding the mtk-regulator-coupler driver, > which transparently manages the voltage relation between these > two vregs, hence completely eliminating the need to manage these > regulators in the Panfrost driver; this solves the long standing > issue with devfreq+opp tables not supporting managing voltages > for two regulators per opp entry out of the box, due to which > we never got GPU DVFS on those SoCs, often locking them out to > a low GPU frequency. > > This changes. Right now! > > Tested on MT8192, MT8195 Chromebooks. > > This series depends on [1]. > > [1]: https://lore.kernel.org/lkml/20230228102704.708150-1-angelogioacchino.delregno@collabora.com/ > > Alyssa Rosenzweig (2): > arm64: dts: mediatek: mt8192: Add GPU nodes > arm64: dts: mediatek: mt8192-asurada: Enable GPU > > AngeloGioacchino Del Regno (16): > arm64: dts: mediatek: mt8183-kukui: Couple VGPU and VSRAM_GPU > regulators > arm64: dts: mediatek: mt8183-kukui: Override vgpu/vsram_gpu > constraints > arm64: dts: mediatek: mt8183: Remove second opp-microvolt entries from > gpu table > arm64: dts: mt8183-pumpkin: Couple VGPU and VSRAM_GPU regulators > arm64: dts: mediatek: mt8183-evb: Couple VGPU and VSRAM_GPU regulators > arm64: dts: mediatek: mt8183: Use mediatek,mt8183b-mali as GPU > compatible > arm64: dts: mediatek: mt8192: Add mfg_ref_sel clock to MFG0 domain > arm64: dts: mediatek: mt8192-asurada: Assign sram supply to MFG1 pd > arm64: dts: mediatek: mt8192-asurada: Fix voltage constraint for Vgpu > arm64: dts: mediatek: mt8192-asurada: Couple VGPU and VSRAM_OTHER > regulators > arm64: dts: mediatek: mt8195: Add mfg_core_tmp clock to MFG1 domain > arm64: dts: mt8195: Add panfrost node for Mali-G57 Valhall Natt GPU > arm64: dts: mediatek: mt8195-cherry: Enable Mali-G57 GPU > arm64: dts: mediatek: mt8186: Add GPU node > arm64: dts: mediatek: mt8183-pumpkin: Override vgpu/vsram_gpu > constraints > arm64: dts: mediatek: mt8183-evb: Override vgpu/vsram_gpu constraints > > Nícolas F. R. A. Prado (1): > arm64: dts: mediatek: mt8192-asurada: Add MFG0 domain supply > > arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 17 ++- > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 17 ++- > .../boot/dts/mediatek/mt8183-pumpkin.dts | 17 ++- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 34 ++--- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 17 +++ > .../boot/dts/mediatek/mt8192-asurada.dtsi | 24 +++- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 116 +++++++++++++++++- > .../boot/dts/mediatek/mt8195-cherry.dtsi | 5 + > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 95 +++++++++++++- > 9 files changed, 315 insertions(+), 27 deletions(-) >
Il 02/03/23 10:36, Matthias Brugger ha scritto: > Series looks good but from my understanding has a dependency on: > [PATCH v4 00/12] Panfrost: Improve and add MediaTek SoCs support > (https://lore.kernel.org/linux-mediatek/20230228102610.707605-1-angelogioacchino.delregno@collabora.com/) > > Did I get that right? > Yes you got it right - without the mentioned series, this one will do nothing at all (and will also fail binding checks, as the bindings are introduced in that other series). Cheers, Angelo > Regards, > Matthias > > On 01/03/2023 10:55, AngeloGioacchino Del Regno wrote: >> Changes in v4: >> - Added a fix for MT8192 Vgpu voltage constraints >> - Changed constraints for MT8192 VSRAM-GPU to reflect the maximum >> achievable voltage as per the actual vsram-vgpu relation constraint >> >> Changes in v3: >> - Changed MT8186 compatibles for new bindings >> - Added min/max voltage overrides for vgpu/vsram_gpu on >> mt8183-pumpkin and evb as suggested by Chen-Yu >> - Cosmetic fixes for "arm64: dts: mediatek: mt8192: Add GPU nodes" >> >> Changes in v2: >> - Changed MT8186 to use only two power domains for the GPU. >> >> We finally have working GPU DVFS on MediaTek SoCs. >> On Panfrost. >> For real. >> ...and the best part is that it's going upstream. >> >> In order to get GPU DVFS working, it was necessary to satisfy a >> specific constraint (which is different, depending on the SoC) >> between two regulators: GPU VCORE and GPU SRAM. >> This was done through adding the mtk-regulator-coupler driver, >> which transparently manages the voltage relation between these >> two vregs, hence completely eliminating the need to manage these >> regulators in the Panfrost driver; this solves the long standing >> issue with devfreq+opp tables not supporting managing voltages >> for two regulators per opp entry out of the box, due to which >> we never got GPU DVFS on those SoCs, often locking them out to >> a low GPU frequency. >> >> This changes. Right now! >> >> Tested on MT8192, MT8195 Chromebooks. >> >> This series depends on [1]. >> >> [1]: >> https://lore.kernel.org/lkml/20230228102704.708150-1-angelogioacchino.delregno@collabora.com/ >> >> Alyssa Rosenzweig (2): >> arm64: dts: mediatek: mt8192: Add GPU nodes >> arm64: dts: mediatek: mt8192-asurada: Enable GPU >> >> AngeloGioacchino Del Regno (16): >> arm64: dts: mediatek: mt8183-kukui: Couple VGPU and VSRAM_GPU >> regulators >> arm64: dts: mediatek: mt8183-kukui: Override vgpu/vsram_gpu >> constraints >> arm64: dts: mediatek: mt8183: Remove second opp-microvolt entries from >> gpu table >> arm64: dts: mt8183-pumpkin: Couple VGPU and VSRAM_GPU regulators >> arm64: dts: mediatek: mt8183-evb: Couple VGPU and VSRAM_GPU regulators >> arm64: dts: mediatek: mt8183: Use mediatek,mt8183b-mali as GPU >> compatible >> arm64: dts: mediatek: mt8192: Add mfg_ref_sel clock to MFG0 domain >> arm64: dts: mediatek: mt8192-asurada: Assign sram supply to MFG1 pd >> arm64: dts: mediatek: mt8192-asurada: Fix voltage constraint for Vgpu >> arm64: dts: mediatek: mt8192-asurada: Couple VGPU and VSRAM_OTHER >> regulators >> arm64: dts: mediatek: mt8195: Add mfg_core_tmp clock to MFG1 domain >> arm64: dts: mt8195: Add panfrost node for Mali-G57 Valhall Natt GPU >> arm64: dts: mediatek: mt8195-cherry: Enable Mali-G57 GPU >> arm64: dts: mediatek: mt8186: Add GPU node >> arm64: dts: mediatek: mt8183-pumpkin: Override vgpu/vsram_gpu >> constraints >> arm64: dts: mediatek: mt8183-evb: Override vgpu/vsram_gpu constraints >> >> Nícolas F. R. A. Prado (1): >> arm64: dts: mediatek: mt8192-asurada: Add MFG0 domain supply >> >> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 17 ++- >> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 17 ++- >> .../boot/dts/mediatek/mt8183-pumpkin.dts | 17 ++- >> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 34 ++--- >> arch/arm64/boot/dts/mediatek/mt8186.dtsi | 17 +++ >> .../boot/dts/mediatek/mt8192-asurada.dtsi | 24 +++- >> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 116 +++++++++++++++++- >> .../boot/dts/mediatek/mt8195-cherry.dtsi | 5 + >> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 95 +++++++++++++- >> 9 files changed, 315 insertions(+), 27 deletions(-) >>
On Thu, Mar 2, 2023 at 6:10 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 02/03/23 10:36, Matthias Brugger ha scritto: > > Series looks good but from my understanding has a dependency on: > > [PATCH v4 00/12] Panfrost: Improve and add MediaTek SoCs support > > (https://lore.kernel.org/linux-mediatek/20230228102610.707605-1-angelogioacchino.delregno@collabora.com/) > > > > Did I get that right? > > > > Yes you got it right - without the mentioned series, this one will do nothing > at all (and will also fail binding checks, as the bindings are introduced in > that other series). Please also let me test them on MT8183 and MT8186 before merging them. ChenYu
On 02/03/2023 11:11, Chen-Yu Tsai wrote: > On Thu, Mar 2, 2023 at 6:10 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Il 02/03/23 10:36, Matthias Brugger ha scritto: >>> Series looks good but from my understanding has a dependency on: >>> [PATCH v4 00/12] Panfrost: Improve and add MediaTek SoCs support >>> (https://lore.kernel.org/linux-mediatek/20230228102610.707605-1-angelogioacchino.delregno@collabora.com/) >>> >>> Did I get that right? >>> >> >> Yes you got it right - without the mentioned series, this one will do nothing >> at all (and will also fail binding checks, as the bindings are introduced in >> that other series). > > Please also let me test them on MT8183 and MT8186 before merging them. > Of course, I'll wait for your tested-by tags then. Thanks for testing! Matthias
On Thu, Mar 2, 2023 at 7:28 PM Matthias Brugger <matthias.bgg@gmail.com> wrote: > On 02/03/2023 11:11, Chen-Yu Tsai wrote: > > On Thu, Mar 2, 2023 at 6:10 PM AngeloGioacchino Del Regno > > <angelogioacchino.delregno@collabora.com> wrote: > >> > >> Il 02/03/23 10:36, Matthias Brugger ha scritto: > >>> Series looks good but from my understanding has a dependency on: > >>> [PATCH v4 00/12] Panfrost: Improve and add MediaTek SoCs support > >>> (https://lore.kernel.org/linux-mediatek/20230228102610.707605-1-angelogioacchino.delregno@collabora.com/) > >>> > >>> Did I get that right? > >>> > >> > >> Yes you got it right - without the mentioned series, this one will do nothing > >> at all (and will also fail binding checks, as the bindings are introduced in > >> that other series). > > > > Please also let me test them on MT8183 and MT8186 before merging them. > > > > Of course, I'll wait for your tested-by tags then. > Thanks for testing! Tested-by: Chen-Yu Tsai <wenst@chromium.org> on MT8183, MT8186, MT8192 and MT8195 Chromebooks. BTW, Angelo, I see that Panfrost keeps the GPU regulator enabled, but the power domains, and thus the SRAM regulator, get powered off when the GPU is not in use. There doesn't seem to be any damaging effects, but I worry about idle power consumption. ChenYu
Il 07/03/23 10:27, Chen-Yu Tsai ha scritto: > On Thu, Mar 2, 2023 at 7:28 PM Matthias Brugger <matthias.bgg@gmail.com> wrote: >> On 02/03/2023 11:11, Chen-Yu Tsai wrote: >>> On Thu, Mar 2, 2023 at 6:10 PM AngeloGioacchino Del Regno >>> <angelogioacchino.delregno@collabora.com> wrote: >>>> >>>> Il 02/03/23 10:36, Matthias Brugger ha scritto: >>>>> Series looks good but from my understanding has a dependency on: >>>>> [PATCH v4 00/12] Panfrost: Improve and add MediaTek SoCs support >>>>> (https://lore.kernel.org/linux-mediatek/20230228102610.707605-1-angelogioacchino.delregno@collabora.com/) >>>>> >>>>> Did I get that right? >>>>> >>>> >>>> Yes you got it right - without the mentioned series, this one will do nothing >>>> at all (and will also fail binding checks, as the bindings are introduced in >>>> that other series). >>> >>> Please also let me test them on MT8183 and MT8186 before merging them. >>> >> >> Of course, I'll wait for your tested-by tags then. >> Thanks for testing! > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > on MT8183, MT8186, MT8192 and MT8195 Chromebooks. > > BTW, Angelo, I see that Panfrost keeps the GPU regulator enabled, but > the power domains, and thus the SRAM regulator, get powered off when > the GPU is not in use. There doesn't seem to be any damaging effects, > but I worry about idle power consumption. > > ChenYu Yes I've seen that as well... and it's true there will be some unwanted small power leakage. Though, I would propose to do things step by step. Right now, as it is, the platform is fully stable... so let's get this in so that we estabilish a known working baseline... what I have in mind is, exactly: 1. Get Panfrost+DVFS working on current platforms; then 2. Resolve the GPU binning situation (eFuses -> opp-supported-hw) 3. Improve the power consumption (all GPU regulators off during suspend) Thanks for all the valuable testing and support! Cheers, Angelo
Il 07/03/23 10:27, Chen-Yu Tsai ha scritto: > On Thu, Mar 2, 2023 at 7:28 PM Matthias Brugger <matthias.bgg@gmail.com> wrote: >> On 02/03/2023 11:11, Chen-Yu Tsai wrote: >>> On Thu, Mar 2, 2023 at 6:10 PM AngeloGioacchino Del Regno >>> <angelogioacchino.delregno@collabora.com> wrote: >>>> >>>> Il 02/03/23 10:36, Matthias Brugger ha scritto: >>>>> Series looks good but from my understanding has a dependency on: >>>>> [PATCH v4 00/12] Panfrost: Improve and add MediaTek SoCs support >>>>> (https://lore.kernel.org/linux-mediatek/20230228102610.707605-1-angelogioacchino.delregno@collabora.com/) >>>>> >>>>> Did I get that right? >>>>> >>>> >>>> Yes you got it right - without the mentioned series, this one will do nothing >>>> at all (and will also fail binding checks, as the bindings are introduced in >>>> that other series). >>> >>> Please also let me test them on MT8183 and MT8186 before merging them. >>> >> >> Of course, I'll wait for your tested-by tags then. >> Thanks for testing! > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > on MT8183, MT8186, MT8192 and MT8195 Chromebooks. > Hello Matthias, The Panfrost driver patches were just queued to drm-misc-next [1], can you please pick this fully reviewed and fully tested series, so that we get them both to land at the same time? [1]: https://patchwork.kernel.org/comment/25265910/ Many thanks! Angelo
On 01/03/2023 10:55, AngeloGioacchino Del Regno wrote: > Changes in v4: > - Added a fix for MT8192 Vgpu voltage constraints > - Changed constraints for MT8192 VSRAM-GPU to reflect the maximum > achievable voltage as per the actual vsram-vgpu relation constraint > > Changes in v3: > - Changed MT8186 compatibles for new bindings > - Added min/max voltage overrides for vgpu/vsram_gpu on > mt8183-pumpkin and evb as suggested by Chen-Yu > - Cosmetic fixes for "arm64: dts: mediatek: mt8192: Add GPU nodes" > > Changes in v2: > - Changed MT8186 to use only two power domains for the GPU. > > We finally have working GPU DVFS on MediaTek SoCs. > On Panfrost. > For real. > ...and the best part is that it's going upstream. > > In order to get GPU DVFS working, it was necessary to satisfy a > specific constraint (which is different, depending on the SoC) > between two regulators: GPU VCORE and GPU SRAM. > This was done through adding the mtk-regulator-coupler driver, > which transparently manages the voltage relation between these > two vregs, hence completely eliminating the need to manage these > regulators in the Panfrost driver; this solves the long standing > issue with devfreq+opp tables not supporting managing voltages > for two regulators per opp entry out of the box, due to which > we never got GPU DVFS on those SoCs, often locking them out to > a low GPU frequency. > > This changes. Right now! > > Tested on MT8192, MT8195 Chromebooks. > Applied, thanks! > This series depends on [1]. > > [1]: https://lore.kernel.org/lkml/20230228102704.708150-1-angelogioacchino.delregno@collabora.com/ > > Alyssa Rosenzweig (2): > arm64: dts: mediatek: mt8192: Add GPU nodes > arm64: dts: mediatek: mt8192-asurada: Enable GPU > > AngeloGioacchino Del Regno (16): > arm64: dts: mediatek: mt8183-kukui: Couple VGPU and VSRAM_GPU > regulators > arm64: dts: mediatek: mt8183-kukui: Override vgpu/vsram_gpu > constraints > arm64: dts: mediatek: mt8183: Remove second opp-microvolt entries from > gpu table > arm64: dts: mt8183-pumpkin: Couple VGPU and VSRAM_GPU regulators > arm64: dts: mediatek: mt8183-evb: Couple VGPU and VSRAM_GPU regulators > arm64: dts: mediatek: mt8183: Use mediatek,mt8183b-mali as GPU > compatible > arm64: dts: mediatek: mt8192: Add mfg_ref_sel clock to MFG0 domain > arm64: dts: mediatek: mt8192-asurada: Assign sram supply to MFG1 pd > arm64: dts: mediatek: mt8192-asurada: Fix voltage constraint for Vgpu > arm64: dts: mediatek: mt8192-asurada: Couple VGPU and VSRAM_OTHER > regulators > arm64: dts: mediatek: mt8195: Add mfg_core_tmp clock to MFG1 domain > arm64: dts: mt8195: Add panfrost node for Mali-G57 Valhall Natt GPU > arm64: dts: mediatek: mt8195-cherry: Enable Mali-G57 GPU > arm64: dts: mediatek: mt8186: Add GPU node > arm64: dts: mediatek: mt8183-pumpkin: Override vgpu/vsram_gpu > constraints > arm64: dts: mediatek: mt8183-evb: Override vgpu/vsram_gpu constraints > > Nícolas F. R. A. Prado (1): > arm64: dts: mediatek: mt8192-asurada: Add MFG0 domain supply > > arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 17 ++- > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 17 ++- > .../boot/dts/mediatek/mt8183-pumpkin.dts | 17 ++- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 34 ++--- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 17 +++ > .../boot/dts/mediatek/mt8192-asurada.dtsi | 24 +++- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 116 +++++++++++++++++- > .../boot/dts/mediatek/mt8195-cherry.dtsi | 5 + > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 95 +++++++++++++- > 9 files changed, 315 insertions(+), 27 deletions(-) >
Changes in v4: - Added a fix for MT8192 Vgpu voltage constraints - Changed constraints for MT8192 VSRAM-GPU to reflect the maximum achievable voltage as per the actual vsram-vgpu relation constraint Changes in v3: - Changed MT8186 compatibles for new bindings - Added min/max voltage overrides for vgpu/vsram_gpu on mt8183-pumpkin and evb as suggested by Chen-Yu - Cosmetic fixes for "arm64: dts: mediatek: mt8192: Add GPU nodes" Changes in v2: - Changed MT8186 to use only two power domains for the GPU. We finally have working GPU DVFS on MediaTek SoCs. On Panfrost. For real. ...and the best part is that it's going upstream. In order to get GPU DVFS working, it was necessary to satisfy a specific constraint (which is different, depending on the SoC) between two regulators: GPU VCORE and GPU SRAM. This was done through adding the mtk-regulator-coupler driver, which transparently manages the voltage relation between these two vregs, hence completely eliminating the need to manage these regulators in the Panfrost driver; this solves the long standing issue with devfreq+opp tables not supporting managing voltages for two regulators per opp entry out of the box, due to which we never got GPU DVFS on those SoCs, often locking them out to a low GPU frequency. This changes. Right now! Tested on MT8192, MT8195 Chromebooks. This series depends on [1]. [1]: https://lore.kernel.org/lkml/20230228102704.708150-1-angelogioacchino.delregno@collabora.com/ Alyssa Rosenzweig (2): arm64: dts: mediatek: mt8192: Add GPU nodes arm64: dts: mediatek: mt8192-asurada: Enable GPU AngeloGioacchino Del Regno (16): arm64: dts: mediatek: mt8183-kukui: Couple VGPU and VSRAM_GPU regulators arm64: dts: mediatek: mt8183-kukui: Override vgpu/vsram_gpu constraints arm64: dts: mediatek: mt8183: Remove second opp-microvolt entries from gpu table arm64: dts: mt8183-pumpkin: Couple VGPU and VSRAM_GPU regulators arm64: dts: mediatek: mt8183-evb: Couple VGPU and VSRAM_GPU regulators arm64: dts: mediatek: mt8183: Use mediatek,mt8183b-mali as GPU compatible arm64: dts: mediatek: mt8192: Add mfg_ref_sel clock to MFG0 domain arm64: dts: mediatek: mt8192-asurada: Assign sram supply to MFG1 pd arm64: dts: mediatek: mt8192-asurada: Fix voltage constraint for Vgpu arm64: dts: mediatek: mt8192-asurada: Couple VGPU and VSRAM_OTHER regulators arm64: dts: mediatek: mt8195: Add mfg_core_tmp clock to MFG1 domain arm64: dts: mt8195: Add panfrost node for Mali-G57 Valhall Natt GPU arm64: dts: mediatek: mt8195-cherry: Enable Mali-G57 GPU arm64: dts: mediatek: mt8186: Add GPU node arm64: dts: mediatek: mt8183-pumpkin: Override vgpu/vsram_gpu constraints arm64: dts: mediatek: mt8183-evb: Override vgpu/vsram_gpu constraints Nícolas F. R. A. Prado (1): arm64: dts: mediatek: mt8192-asurada: Add MFG0 domain supply arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 17 ++- .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 17 ++- .../boot/dts/mediatek/mt8183-pumpkin.dts | 17 ++- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 34 ++--- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 17 +++ .../boot/dts/mediatek/mt8192-asurada.dtsi | 24 +++- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 116 +++++++++++++++++- .../boot/dts/mediatek/mt8195-cherry.dtsi | 5 + arch/arm64/boot/dts/mediatek/mt8195.dtsi | 95 +++++++++++++- 9 files changed, 315 insertions(+), 27 deletions(-)