[00/12] Q35 PCI host fixes and QOM cleanup

Message ID	20230214131441.101760-1-shentey@gmail.com (mailing list archive)
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> From: Bernhard Beschow <shentey@gmail.com> To: qemu-devel@nongnu.org Cc: Richard Henderson <richard.henderson@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Bernhard Beschow <shentey@gmail.com> Subject: [PATCH 00/12] Q35 PCI host fixes and QOM cleanup Date: Tue, 14 Feb 2023 14:14:29 +0100 Message-Id: <20230214131441.101760-1-shentey@gmail.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=shentey@gmail.com; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Series	Q35 PCI host fixes and QOM cleanup \| expand [00/12] Q35 PCI host fixes and QOM cleanup [01/12] hw/i386/pc_q35: Resolve redundant q35_host variable [02/12] hw/pci-host/q35: Fix contradicting .endianness assignment [03/12] hw/pci-host/q35: Use memory_region_set_address() also for tseg_blackhole [04/12] hw/pci-host/q35: Initialize PCMachineState::bus in board code [05/12] hw/pci-host/q35: Initialize "bypass-iommu" property from board code [06/12] hw/pci-host/q35: Initialize properties just once [07/12] hw/pci-host/q35: Initialize PCI hole boundaries just once [08/12] hw/pci-host/q35: Turn PCI hole properties into class properties [09/12] hw/pci-host/q35: Rename local variable to more idiomatic "phb" [10/12] hw/pci-host/q35: Propagate to errp rather than doing error_fatal [11/12] hw/pci-host/q35: Merge mch_realize() into q35_host_realize() [12/12] hw/pci-host/q35: Move MemoryRegion pointers to host device

Bernhard Beschow Feb. 14, 2023, 1:14 p.m. UTC

This series mostly cleans up QOM-related initialization code. It also performs
some modernization and fixing.

The first patch originates from "PC and ICH9 clanups" series [1] which has been
dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
needs more work, so bring the patch back here.

Patch 2 fixes a clangd warning and patch 3 modernizes usage of the memory API.

Patches 4-9 clean up initialization code.

The last four patches also clean up initialization code with the last patch
doing the actual cleanup.

Based-on: <20230213162004.2797-1-shentey@gmail.com>
         "[PATCH v4 0/9] PC cleanups"

Testing done:
* `make check`
* `make check-avocado`
* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
     manjaro-kde-21.3.2-220704-linux515.iso`

[1] https://lore.kernel.org/qemu-devel/20230131115326.12454-1-shentey@gmail.com/
[2] https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/

Bernhard Beschow (12):
  hw/i386/pc_q35: Resolve redundant q35_host variable
  hw/pci-host/q35: Fix contradicting .endianness assignment
  hw/pci-host/q35: Use memory_region_set_address() also for
    tseg_blackhole
  hw/pci-host/q35: Initialize PCMachineState::bus in board code
  hw/pci-host/q35: Initialize "bypass-iommu" property from board code
  hw/pci-host/q35: Initialize properties just once
  hw/pci-host/q35: Initialize PCI hole boundaries just once
  hw/pci-host/q35: Turn PCI hole properties into class properties
  hw/pci-host/q35: Rename local variable to more idiomatic "phb"
  hw/pci-host/q35: Propagate to errp rather than doing error_fatal
  hw/pci-host/q35: Merge mch_realize() into q35_host_realize()
  hw/pci-host/q35: Move MemoryRegion pointers to host device

 include/hw/pci-host/q35.h |  17 +-
 hw/i386/pc_q35.c          |  33 ++--
 hw/pci-host/q35.c         | 325 ++++++++++++++++++--------------------
 3 files changed, 178 insertions(+), 197 deletions(-)

Bernhard Beschow Feb. 21, 2023, 3:39 p.m. UTC | #1

Am 14. Februar 2023 13:14:29 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>This series mostly cleans up QOM-related initialization code. It also performs
>
>some modernization and fixing.
>
>
>
>The first patch originates from "PC and ICH9 clanups" series [1] which has been
>
>dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
>
>needs more work, so bring the patch back here.
>
>
>
>Patch 2 fixes a clangd warning and patch 3 modernizes usage of the memory API.
>
>
>
>Patches 4-9 clean up initialization code.
>
>
>
>The last four patches also clean up initialization code with the last patch
>
>doing the actual cleanup.
>

Ping

>
>
>Based-on: <20230213162004.2797-1-shentey@gmail.com>
>
>         "[PATCH v4 0/9] PC cleanups"
>
>
>
>Testing done:
>
>* `make check`
>
>* `make check-avocado`
>
>* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
>
>     manjaro-kde-21.3.2-220704-linux515.iso`
>
>
>
>[1] https://lore.kernel.org/qemu-devel/20230131115326.12454-1-shentey@gmail.com/
>
>[2] https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/
>
>
>
>Bernhard Beschow (12):
>
>  hw/i386/pc_q35: Resolve redundant q35_host variable
>
>  hw/pci-host/q35: Fix contradicting .endianness assignment
>
>  hw/pci-host/q35: Use memory_region_set_address() also for
>
>    tseg_blackhole
>
>  hw/pci-host/q35: Initialize PCMachineState::bus in board code
>
>  hw/pci-host/q35: Initialize "bypass-iommu" property from board code
>
>  hw/pci-host/q35: Initialize properties just once
>
>  hw/pci-host/q35: Initialize PCI hole boundaries just once
>
>  hw/pci-host/q35: Turn PCI hole properties into class properties
>
>  hw/pci-host/q35: Rename local variable to more idiomatic "phb"
>
>  hw/pci-host/q35: Propagate to errp rather than doing error_fatal
>
>  hw/pci-host/q35: Merge mch_realize() into q35_host_realize()
>
>  hw/pci-host/q35: Move MemoryRegion pointers to host device
>
>
>
> include/hw/pci-host/q35.h |  17 +-
>
> hw/i386/pc_q35.c          |  33 ++--
>
> hw/pci-host/q35.c         | 325 ++++++++++++++++++--------------------
>
> 3 files changed, 178 insertions(+), 197 deletions(-)
>
>
>
>-- >
>2.39.1
>
>
>

Michael S. Tsirkin March 1, 2023, 9:49 p.m. UTC | #2

On Tue, Feb 21, 2023 at 03:39:28PM +0000, Bernhard Beschow wrote:
> 
> 
> Am 14. Februar 2023 13:14:29 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
> >This series mostly cleans up QOM-related initialization code. It also performs
> >
> >some modernization and fixing.
> >
> >
> >
> >The first patch originates from "PC and ICH9 clanups" series [1] which has been
> >
> >dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
> >
> >needs more work, so bring the patch back here.
> >
> >
> >
> >Patch 2 fixes a clangd warning and patch 3 modernizes usage of the memory API.
> >
> >
> >
> >Patches 4-9 clean up initialization code.
> >
> >
> >
> >The last four patches also clean up initialization code with the last patch
> >
> >doing the actual cleanup.
> >
> 
> Ping


sent some comments. Philippe was reviewing related patches maybe
he wants to poke at these too.

> >
> >
> >Based-on: <20230213162004.2797-1-shentey@gmail.com>
> >
> >         "[PATCH v4 0/9] PC cleanups"
> >
> >
> >
> >Testing done:
> >
> >* `make check`
> >
> >* `make check-avocado`
> >
> >* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
> >
> >     manjaro-kde-21.3.2-220704-linux515.iso`
> >
> >
> >
> >[1] https://lore.kernel.org/qemu-devel/20230131115326.12454-1-shentey@gmail.com/
> >
> >[2] https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/
> >
> >
> >
> >Bernhard Beschow (12):
> >
> >  hw/i386/pc_q35: Resolve redundant q35_host variable
> >
> >  hw/pci-host/q35: Fix contradicting .endianness assignment
> >
> >  hw/pci-host/q35: Use memory_region_set_address() also for
> >
> >    tseg_blackhole
> >
> >  hw/pci-host/q35: Initialize PCMachineState::bus in board code
> >
> >  hw/pci-host/q35: Initialize "bypass-iommu" property from board code
> >
> >  hw/pci-host/q35: Initialize properties just once
> >
> >  hw/pci-host/q35: Initialize PCI hole boundaries just once
> >
> >  hw/pci-host/q35: Turn PCI hole properties into class properties
> >
> >  hw/pci-host/q35: Rename local variable to more idiomatic "phb"
> >
> >  hw/pci-host/q35: Propagate to errp rather than doing error_fatal
> >
> >  hw/pci-host/q35: Merge mch_realize() into q35_host_realize()
> >
> >  hw/pci-host/q35: Move MemoryRegion pointers to host device
> >
> >
> >
> > include/hw/pci-host/q35.h |  17 +-
> >
> > hw/i386/pc_q35.c          |  33 ++--
> >
> > hw/pci-host/q35.c         | 325 ++++++++++++++++++--------------------
> >
> > 3 files changed, 178 insertions(+), 197 deletions(-)
> >
> >
> >
> >-- >
> >2.39.1
> >
> >
> >

Michael S. Tsirkin March 1, 2023, 9:50 p.m. UTC | #3

On Tue, Feb 14, 2023 at 02:14:29PM +0100, Bernhard Beschow wrote:
> This series mostly cleans up QOM-related initialization code. It also performs
> some modernization and fixing.
> 
> The first patch originates from "PC and ICH9 clanups" series [1] which has been
> dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
> needs more work, so bring the patch back here.
> 
> Patch 2 fixes a clangd warning and patch 3 modernizes usage of the memory API.

what's the warning? commit log says nothing about it.

> Patches 4-9 clean up initialization code.
> 
> The last four patches also clean up initialization code with the last patch
> doing the actual cleanup.
> 
> Based-on: <20230213162004.2797-1-shentey@gmail.com>
>          "[PATCH v4 0/9] PC cleanups"
> 
> Testing done:
> * `make check`
> * `make check-avocado`
> * `qemu-system-x86_64 -M q35 -m 2G -cdrom \
>      manjaro-kde-21.3.2-220704-linux515.iso`
> 
> [1] https://lore.kernel.org/qemu-devel/20230131115326.12454-1-shentey@gmail.com/
> [2] https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/
> 
> Bernhard Beschow (12):
>   hw/i386/pc_q35: Resolve redundant q35_host variable
>   hw/pci-host/q35: Fix contradicting .endianness assignment
>   hw/pci-host/q35: Use memory_region_set_address() also for
>     tseg_blackhole
>   hw/pci-host/q35: Initialize PCMachineState::bus in board code
>   hw/pci-host/q35: Initialize "bypass-iommu" property from board code
>   hw/pci-host/q35: Initialize properties just once
>   hw/pci-host/q35: Initialize PCI hole boundaries just once
>   hw/pci-host/q35: Turn PCI hole properties into class properties
>   hw/pci-host/q35: Rename local variable to more idiomatic "phb"
>   hw/pci-host/q35: Propagate to errp rather than doing error_fatal
>   hw/pci-host/q35: Merge mch_realize() into q35_host_realize()
>   hw/pci-host/q35: Move MemoryRegion pointers to host device
> 
>  include/hw/pci-host/q35.h |  17 +-
>  hw/i386/pc_q35.c          |  33 ++--
>  hw/pci-host/q35.c         | 325 ++++++++++++++++++--------------------
>  3 files changed, 178 insertions(+), 197 deletions(-)
> 
> -- 
> 2.39.1
>

Bernhard Beschow March 2, 2023, 9:54 p.m. UTC | #4

Am 1. März 2023 21:49:37 UTC schrieb "Michael S. Tsirkin" <mst@redhat.com>:
>On Tue, Feb 21, 2023 at 03:39:28PM +0000, Bernhard Beschow wrote:
>> 
>> 
>> Am 14. Februar 2023 13:14:29 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>> >This series mostly cleans up QOM-related initialization code. It also performs
>> >
>> >some modernization and fixing.
>> >
>> >
>> >
>> >The first patch originates from "PC and ICH9 clanups" series [1] which has been
>> >
>> >dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
>> >
>> >needs more work, so bring the patch back here.
>> >
>> >
>> >
>> >Patch 2 fixes a clangd warning and patch 3 modernizes usage of the memory API.
>> >
>> >
>> >
>> >Patches 4-9 clean up initialization code.
>> >
>> >
>> >
>> >The last four patches also clean up initialization code with the last patch
>> >
>> >doing the actual cleanup.
>> >
>> 
>> Ping
>
>
>sent some comments.

I'll look into it over the weekend. I'm quite busy right now.

Best regards,
Bernhard

>Philippe was reviewing related patches maybe
>he wants to poke at these too.
>
>> >
>> >
>> >Based-on: <20230213162004.2797-1-shentey@gmail.com>
>> >
>> >         "[PATCH v4 0/9] PC cleanups"
>> >
>> >
>> >
>> >Testing done:
>> >
>> >* `make check`
>> >
>> >* `make check-avocado`
>> >
>> >* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
>> >
>> >     manjaro-kde-21.3.2-220704-linux515.iso`
>> >
>> >
>> >
>> >[1] https://lore.kernel.org/qemu-devel/20230131115326.12454-1-shentey@gmail.com/
>> >
>> >[2] https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/
>> >
>> >
>> >
>> >Bernhard Beschow (12):
>> >
>> >  hw/i386/pc_q35: Resolve redundant q35_host variable
>> >
>> >  hw/pci-host/q35: Fix contradicting .endianness assignment
>> >
>> >  hw/pci-host/q35: Use memory_region_set_address() also for
>> >
>> >    tseg_blackhole
>> >
>> >  hw/pci-host/q35: Initialize PCMachineState::bus in board code
>> >
>> >  hw/pci-host/q35: Initialize "bypass-iommu" property from board code
>> >
>> >  hw/pci-host/q35: Initialize properties just once
>> >
>> >  hw/pci-host/q35: Initialize PCI hole boundaries just once
>> >
>> >  hw/pci-host/q35: Turn PCI hole properties into class properties
>> >
>> >  hw/pci-host/q35: Rename local variable to more idiomatic "phb"
>> >
>> >  hw/pci-host/q35: Propagate to errp rather than doing error_fatal
>> >
>> >  hw/pci-host/q35: Merge mch_realize() into q35_host_realize()
>> >
>> >  hw/pci-host/q35: Move MemoryRegion pointers to host device
>> >
>> >
>> >
>> > include/hw/pci-host/q35.h |  17 +-
>> >
>> > hw/i386/pc_q35.c          |  33 ++--
>> >
>> > hw/pci-host/q35.c         | 325 ++++++++++++++++++--------------------
>> >
>> > 3 files changed, 178 insertions(+), 197 deletions(-)
>> >
>> >
>> >
>> >-- >
>> >2.39.1
>> >
>> >
>> >
>

Bernhard Beschow March 5, 2023, 7:41 a.m. UTC | #5

Am 2. März 2023 21:54:56 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>
>
>Am 1. März 2023 21:49:37 UTC schrieb "Michael S. Tsirkin" <mst@redhat.com>:
>>On Tue, Feb 21, 2023 at 03:39:28PM +0000, Bernhard Beschow wrote:
>>> 
>>> 
>>> Am 14. Februar 2023 13:14:29 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>>> >This series mostly cleans up QOM-related initialization code. It also performs
>>> >
>>> >some modernization and fixing.
>>> >
>>> >
>>> >
>>> >The first patch originates from "PC and ICH9 clanups" series [1] which has been
>>> >
>>> >dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
>>> >
>>> >needs more work, so bring the patch back here.
>>> >
>>> >
>>> >
>>> >Patch 2 fixes a clangd warning and patch 3 modernizes usage of the memory API.
>>> >
>>> >
>>> >
>>> >Patches 4-9 clean up initialization code.
>>> >
>>> >
>>> >
>>> >The last four patches also clean up initialization code with the last patch
>>> >
>>> >doing the actual cleanup.
>>> >
>>> 
>>> Ping
>>
>>
>>sent some comments.
>
>I'll look into it over the weekend. I'm quite busy right now.

Forgot to mention: v2 is out!

>
>Best regards,
>Bernhard
>
>>Philippe was reviewing related patches maybe
>>he wants to poke at these too.
>>
>>> >
>>> >
>>> >Based-on: <20230213162004.2797-1-shentey@gmail.com>
>>> >
>>> >         "[PATCH v4 0/9] PC cleanups"
>>> >
>>> >
>>> >
>>> >Testing done:
>>> >
>>> >* `make check`
>>> >
>>> >* `make check-avocado`
>>> >
>>> >* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
>>> >
>>> >     manjaro-kde-21.3.2-220704-linux515.iso`
>>> >
>>> >
>>> >
>>> >[1] https://lore.kernel.org/qemu-devel/20230131115326.12454-1-shentey@gmail.com/
>>> >
>>> >[2] https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/
>>> >
>>> >
>>> >
>>> >Bernhard Beschow (12):
>>> >
>>> >  hw/i386/pc_q35: Resolve redundant q35_host variable
>>> >
>>> >  hw/pci-host/q35: Fix contradicting .endianness assignment
>>> >
>>> >  hw/pci-host/q35: Use memory_region_set_address() also for
>>> >
>>> >    tseg_blackhole
>>> >
>>> >  hw/pci-host/q35: Initialize PCMachineState::bus in board code
>>> >
>>> >  hw/pci-host/q35: Initialize "bypass-iommu" property from board code
>>> >
>>> >  hw/pci-host/q35: Initialize properties just once
>>> >
>>> >  hw/pci-host/q35: Initialize PCI hole boundaries just once
>>> >
>>> >  hw/pci-host/q35: Turn PCI hole properties into class properties
>>> >
>>> >  hw/pci-host/q35: Rename local variable to more idiomatic "phb"
>>> >
>>> >  hw/pci-host/q35: Propagate to errp rather than doing error_fatal
>>> >
>>> >  hw/pci-host/q35: Merge mch_realize() into q35_host_realize()
>>> >
>>> >  hw/pci-host/q35: Move MemoryRegion pointers to host device
>>> >
>>> >
>>> >
>>> > include/hw/pci-host/q35.h |  17 +-
>>> >
>>> > hw/i386/pc_q35.c          |  33 ++--
>>> >
>>> > hw/pci-host/q35.c         | 325 ++++++++++++++++++--------------------
>>> >
>>> > 3 files changed, 178 insertions(+), 197 deletions(-)
>>> >
>>> >
>>> >
>>> >-- >
>>> >2.39.1
>>> >
>>> >
>>> >
>>

[00/12] Q35 PCI host fixes and QOM cleanup

Message

Comments