diff mbox series

[12/28] fs: Fix description of vfs_tmpfile()

Message ID 20230303181842.1087717-13-roberto.sassu@huaweicloud.com (mailing list archive)
State New, archived
Headers show
Series security: Move IMA and EVM to the LSM infrastructure | expand

Commit Message

Roberto Sassu March 3, 2023, 6:18 p.m. UTC 
From: Roberto Sassu <roberto.sassu@huawei.com>

Update the description of vfs_tmpfile() to match the current parameters of
that function.

Fixes: 9751b338656f ("vfs: move open right after ->tmpfile()")
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
---
 fs/namei.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Christian Brauner March 6, 2023, 10:28 a.m. UTC | #1 
On Fri, Mar 03, 2023 at 07:18:26PM +0100, Roberto Sassu wrote:
> From: Roberto Sassu <roberto.sassu@huawei.com>
> 
> Update the description of vfs_tmpfile() to match the current parameters of
> that function.
> 
> Fixes: 9751b338656f ("vfs: move open right after ->tmpfile()")
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> ---

Trivially correct. But this shouldn't need to be a part of this series
afaict. Please send a this separately to fsdevel so we can pick it up
right now,

Acked-by: Christian Brauner <brauner@kernel.org>
Roberto Sassu March 6, 2023, 10:31 a.m. UTC | #2 
On Mon, 2023-03-06 at 11:28 +0100, Christian Brauner wrote:
> On Fri, Mar 03, 2023 at 07:18:26PM +0100, Roberto Sassu wrote:
> > From: Roberto Sassu <roberto.sassu@huawei.com>
> > 
> > Update the description of vfs_tmpfile() to match the current parameters of
> > that function.
> > 
> > Fixes: 9751b338656f ("vfs: move open right after ->tmpfile()")
> > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> > ---
> 
> Trivially correct. But this shouldn't need to be a part of this series
> afaict. Please send a this separately to fsdevel so we can pick it up
> right now,
> 
> Acked-by: Christian Brauner <brauner@kernel.org>

Ok, thanks. I do the same for the EVM one.

Roberto
diff mbox series

Patch

diff --git a/fs/namei.c b/fs/namei.c
index 57727a1ae38..b4c52c4890b 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3574,9 +3574,9 @@  static int do_open(struct nameidata *nd,
 /**
  * vfs_tmpfile - create tmpfile
  * @idmap:	idmap of the mount the inode was found from
- * @dentry:	pointer to dentry of the base directory
+ * @parentpath:	pointer to the path of the base directory
+ * @file:	file descriptor of the new tmpfile
  * @mode:	mode of the new tmpfile
- * @open_flag:	flags
  *
  * Create a temporary file.
  *