| Message ID | 20230306224752.8417-1-afd@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kbuild: Disallow DTB overlays to built from .dts named source files | expand |
On Tue, Mar 7, 2023 at 7:48 AM Andrew Davis <afd@ti.com> wrote: > > As a follow up to the series allowing DTB overlays to built from .dtso > files. Now that all overlays have been renamed, remove the ability to > build from overlays from .dts files to prevent any files with the old > name from accidental being added. > > Signed-off-by: Andrew Davis <afd@ti.com> Acked-by: Masahiro Yamada <masahiroy@kernel.org> if Rob picks this up. > --- > scripts/Makefile.lib | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 100a386fcd71..68d0134bdbf9 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -418,9 +418,6 @@ endif > $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE > $(call if_changed_dep,dtb) > > -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE > - $(call if_changed_dep,dtc) > - > $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE > $(call if_changed_dep,dtc) > > -- > 2.39.2 >
On Mon, Mar 6, 2023 at 11:48 PM Andrew Davis <afd@ti.com> wrote: > As a follow up to the series allowing DTB overlays to built from .dtso > files. Now that all overlays have been renamed, remove the ability to > build from overlays from .dts files to prevent any files with the old > name from accidental being added. > > Signed-off-by: Andrew Davis <afd@ti.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Mon, Mar 06, 2023 at 04:47:52PM -0600, Andrew Davis wrote: > As a follow up to the series allowing DTB overlays to built from .dtso > files. Now that all overlays have been renamed, remove the ability to > build from overlays from .dts files to prevent any files with the old > name from accidental being added. Since in the past I had a problem with unnecessary rebuilding, this removes the rule, so should not bring a similar regression. Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com> Thank you. > Signed-off-by: Andrew Davis <afd@ti.com> > --- > scripts/Makefile.lib | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 100a386fcd71..68d0134bdbf9 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -418,9 +418,6 @@ endif > $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE > $(call if_changed_dep,dtb) > > -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE > - $(call if_changed_dep,dtc) > - > $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE > $(call if_changed_dep,dtc) > > -- > 2.39.2 >
On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote: > As a follow up to the series allowing DTB overlays to built from .dtso > files. Now that all overlays have been renamed, remove the ability to > build from overlays from .dts files to prevent any files with the old ^^^^ The first "from" sounds superfluous to me. Kind regards, Nicolas > name from accidental being added. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > scripts/Makefile.lib | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 100a386fcd71..68d0134bdbf9 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -418,9 +418,6 @@ endif > $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE > $(call if_changed_dep,dtb) > > -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE > - $(call if_changed_dep,dtc) > - > $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE > $(call if_changed_dep,dtc) > > -- > 2.39.2
On 3/8/23 10:56 AM, Nicolas Schier wrote: > On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote: >> As a follow up to the series allowing DTB overlays to built from .dtso >> files. Now that all overlays have been renamed, remove the ability to >> build from overlays from .dts files to prevent any files with the old > ^^^^ > > The first "from" sounds superfluous to me. > It is a typo, feel free to drop it locally whoever takes this patch. Thanks, Andrew > Kind regards, > Nicolas >> name from accidental being added. >> >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> scripts/Makefile.lib | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib >> index 100a386fcd71..68d0134bdbf9 100644 >> --- a/scripts/Makefile.lib >> +++ b/scripts/Makefile.lib >> @@ -418,9 +418,6 @@ endif >> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE >> $(call if_changed_dep,dtb) >> >> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE >> - $(call if_changed_dep,dtc) >> - >> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE >> $(call if_changed_dep,dtc) >> >> -- >> 2.39.2 >
On 3/8/23 9:01 AM, Andrew Davis wrote: > On 3/8/23 10:56 AM, Nicolas Schier wrote: >> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote: >>> As a follow up to the series allowing DTB overlays to built from .dtso >>> files. Now that all overlays have been renamed, remove the ability to >>> build from overlays from .dts files to prevent any files with the old >> ^^^^ >> >> The first "from" sounds superfluous to me. >> > > It is a typo, feel free to drop it locally whoever takes this patch. > Seems no one took this last cycle.. Still valid and applies for this one. Andrew > Thanks, > Andrew > >> Kind regards, >> Nicolas >>> name from accidental being added. >>> >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> --- >>> scripts/Makefile.lib | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib >>> index 100a386fcd71..68d0134bdbf9 100644 >>> --- a/scripts/Makefile.lib >>> +++ b/scripts/Makefile.lib >>> @@ -418,9 +418,6 @@ endif >>> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE >>> $(call if_changed_dep,dtb) >>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE >>> - $(call if_changed_dep,dtc) >>> - >>> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE >>> $(call if_changed_dep,dtc) >>> -- >>> 2.39.2 >>
On Tue, May 16, 2023 at 1:49 AM Andrew Davis <afd@ti.com> wrote: > > On 3/8/23 9:01 AM, Andrew Davis wrote: > > On 3/8/23 10:56 AM, Nicolas Schier wrote: > >> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote: > >>> As a follow up to the series allowing DTB overlays to built from .dtso > >>> files. Now that all overlays have been renamed, remove the ability to > >>> build from overlays from .dts files to prevent any files with the old > >> ^^^^ > >> > >> The first "from" sounds superfluous to me. > >> > > > > It is a typo, feel free to drop it locally whoever takes this patch. > > > > Seems no one took this last cycle.. Still valid and applies for this one. Seems it fell into a crack. Now applied to linux-kbuild. Thanks. > Andrew > > > Thanks, > > Andrew > > > >> Kind regards, > >> Nicolas > >>> name from accidental being added. > >>> > >>> Signed-off-by: Andrew Davis <afd@ti.com> > >>> --- > >>> scripts/Makefile.lib | 3 --- > >>> 1 file changed, 3 deletions(-) > >>> > >>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > >>> index 100a386fcd71..68d0134bdbf9 100644 > >>> --- a/scripts/Makefile.lib > >>> +++ b/scripts/Makefile.lib > >>> @@ -418,9 +418,6 @@ endif > >>> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE > >>> $(call if_changed_dep,dtb) > >>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE > >>> - $(call if_changed_dep,dtc) > >>> - > >>> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE > >>> $(call if_changed_dep,dtc) > >>> -- > >>> 2.39.2 > >>
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 100a386fcd71..68d0134bdbf9 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -418,9 +418,6 @@ endif $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE $(call if_changed_dep,dtb) -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE - $(call if_changed_dep,dtc) - $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE $(call if_changed_dep,dtc)
As a follow up to the series allowing DTB overlays to built from .dtso files. Now that all overlays have been renamed, remove the ability to build from overlays from .dts files to prevent any files with the old name from accidental being added. Signed-off-by: Andrew Davis <afd@ti.com> --- scripts/Makefile.lib | 3 --- 1 file changed, 3 deletions(-)