| Message ID | 20230307174627.23787-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm: fix PM_DEVFREQ kconfig dependency warning | expand |
On Tue, Mar 7, 2023 at 2:46 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter > should either be selected or DRM_MSM should depend on PM_DEVFREQ. > Since most drivers select PM_DEVFREQ instead of depending on it, > add a select here to satisfy kconfig. > > WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND > Depends on [n]: PM_DEVFREQ [=n] > Selected by [y]: > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n) > > Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: lore.kernel.org/r/202303071922.wJqDWQpe-lkp@intel.com > Cc: Rob Clark <robdclark@chromium.org> > Cc: Paul Gazzillo <paul@pgazz.com> > Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com> > Cc: Chia-I Wu <olvaffe@gmail.com> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org This fixes the warning after running 'make imx_v6_v7_defconfig', thanks: Tested-by: Fabio Estevam <festevam@gmail.com>
On Tue, Mar 7, 2023 at 10:48 AM Fabio Estevam <festevam@gmail.com> wrote: > > On Tue, Mar 7, 2023 at 2:46 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > > > Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter > > should either be selected or DRM_MSM should depend on PM_DEVFREQ. > > Since most drivers select PM_DEVFREQ instead of depending on it, > > add a select here to satisfy kconfig. > > > > WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND > > Depends on [n]: PM_DEVFREQ [=n] > > Selected by [y]: > > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n) > > > > Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Reported-by: kernel test robot <lkp@intel.com> > > Link: lore.kernel.org/r/202303071922.wJqDWQpe-lkp@intel.com > > Cc: Rob Clark <robdclark@chromium.org> > > Cc: Paul Gazzillo <paul@pgazz.com> > > Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com> > > Cc: Chia-I Wu <olvaffe@gmail.com> > > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Cc: linux-arm-msm@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: freedreno@lists.freedesktop.org > > This fixes the warning after running 'make imx_v6_v7_defconfig', thanks: > > Tested-by: Fabio Estevam <festevam@gmail.com> https://patchwork.freedesktop.org/patch/523353 is the fix we actually want.. I thought I'd already pulled that into msm-fixes but it seems like it got lost somewhere.. I'll rectify that BR, -R
diff -- a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -23,6 +23,7 @@ config DRM_MSM select SHMEM select TMPFS select QCOM_SCM + select PM_DEVFREQ select DEVFREQ_GOV_SIMPLE_ONDEMAND select WANT_DEV_COREDUMP select SND_SOC_HDMI_CODEC if SND_SOC
Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter should either be selected or DRM_MSM should depend on PM_DEVFREQ. Since most drivers select PM_DEVFREQ instead of depending on it, add a select here to satisfy kconfig. WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND Depends on [n]: PM_DEVFREQ [=n] Selected by [y]: - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n) Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Link: lore.kernel.org/r/202303071922.wJqDWQpe-lkp@intel.com Cc: Rob Clark <robdclark@chromium.org> Cc: Paul Gazzillo <paul@pgazz.com> Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com> Cc: Chia-I Wu <olvaffe@gmail.com> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+)