| Message ID | 20230302122708.73848-2-y.oudjana@protonmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MediaTek MT6735 SCPSYS support | expand |
Il 02/03/23 13:27, Yassine Oudjana ha scritto: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Add DT binding for MediaTek MT6735 SCPSYS power controller. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > .../bindings/power/mediatek,power-controller.yaml | 2 ++ > .../devicetree/bindings/soc/mediatek/scpsys.txt | 1 + > include/dt-bindings/power/mt6735-power.h | 14 ++++++++++++++ I know many others don't follow the right binding filenames and I am sure you named it like that looking at the other ones, but please rename this to mediatek,mt6735-power.h and resend. The rest looks good. > 3 files changed, 17 insertions(+) > create mode 100644 include/dt-bindings/power/mt6735-power.h > > diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > index c9acef80f452..710db61cab53 100644 > --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > @@ -23,6 +23,7 @@ properties: > > compatible: > enum: > + - mediatek,mt6735-power-controller > - mediatek,mt6795-power-controller > - mediatek,mt8167-power-controller > - mediatek,mt8173-power-controller > @@ -81,6 +82,7 @@ $defs: > reg: > description: | > Power domain index. Valid values are defined in: > + "include/dt-bindings/power/mt6735-power.h" - for MT6735 type power domain. P.S.: Don't forget to update this addition after the rename :-) After - and only after - renaming, Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 02/03/2023 13:27, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Add DT binding for MediaTek MT6735 SCPSYS power controller. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > .../bindings/power/mediatek,power-controller.yaml | 2 ++ > .../devicetree/bindings/soc/mediatek/scpsys.txt | 1 + > include/dt-bindings/power/mt6735-power.h | 14 ++++++++++++++ > 3 files changed, 17 insertions(+) > create mode 100644 include/dt-bindings/power/mt6735-power.h > > diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > index c9acef80f452..710db61cab53 100644 > --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > @@ -23,6 +23,7 @@ properties: > > compatible: > enum: > + - mediatek,mt6735-power-controller > - mediatek,mt6795-power-controller > - mediatek,mt8167-power-controller > - mediatek,mt8173-power-controller > @@ -81,6 +82,7 @@ $defs: > reg: > description: | > Power domain index. Valid values are defined in: > + "include/dt-bindings/power/mt6735-power.h" - for MT6735 type power domain. Isn't the comment obvious? Maybe let's stop adding them? > "include/dt-bindings/power/mt6795-power.h" - for MT8167 type power domain. > "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain. > "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain. > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > index 2bc367793aec..3530a6668b48 100644 > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > @@ -20,6 +20,7 @@ Required properties: > - compatible: Should be one of: > - "mediatek,mt2701-scpsys" > - "mediatek,mt2712-scpsys" > + - "mediatek,mt6735-scpsys" > - "mediatek,mt6765-scpsys" > - "mediatek,mt6797-scpsys" > - "mediatek,mt7622-scpsys" > diff --git a/include/dt-bindings/power/mt6735-power.h b/include/dt-bindings/power/mt6735-power.h > new file mode 100644 > index 000000000000..782b49a88773 > --- /dev/null > +++ b/include/dt-bindings/power/mt6735-power.h I am pretty sure we already discussed the file naming with some other patches... mediatek,mt6735-power-controller.h Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml index c9acef80f452..710db61cab53 100644 --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml @@ -23,6 +23,7 @@ properties: compatible: enum: + - mediatek,mt6735-power-controller - mediatek,mt6795-power-controller - mediatek,mt8167-power-controller - mediatek,mt8173-power-controller @@ -81,6 +82,7 @@ $defs: reg: description: | Power domain index. Valid values are defined in: + "include/dt-bindings/power/mt6735-power.h" - for MT6735 type power domain. "include/dt-bindings/power/mt6795-power.h" - for MT8167 type power domain. "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain. "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain. diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt index 2bc367793aec..3530a6668b48 100644 --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt @@ -20,6 +20,7 @@ Required properties: - compatible: Should be one of: - "mediatek,mt2701-scpsys" - "mediatek,mt2712-scpsys" + - "mediatek,mt6735-scpsys" - "mediatek,mt6765-scpsys" - "mediatek,mt6797-scpsys" - "mediatek,mt7622-scpsys" diff --git a/include/dt-bindings/power/mt6735-power.h b/include/dt-bindings/power/mt6735-power.h new file mode 100644 index 000000000000..782b49a88773 --- /dev/null +++ b/include/dt-bindings/power/mt6735-power.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ + +#ifndef _DT_BINDINGS_POWER_MT6735_POWER_H +#define _DT_BINDINGS_POWER_MT6735_POWER_H + +#define MT6735_POWER_DOMAIN_MD1 0 +#define MT6735_POWER_DOMAIN_CONN 1 +#define MT6735_POWER_DOMAIN_DIS 2 +#define MT6735_POWER_DOMAIN_MFG 3 +#define MT6735_POWER_DOMAIN_ISP 4 +#define MT6735_POWER_DOMAIN_VDE 5 +#define MT6735_POWER_DOMAIN_VEN 6 + +#endif