| Message ID | 20230201150815.409582-9-urezki@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 229f0f93ae7dfba10a82e7e9f7bd3e13658573aa |
| Headers | show |
| Series | Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep() | expand |
On Wed, Feb 01, 2023 at 04:08:14PM +0100, Uladzislau Rezki (Sony) wrote: > The kfree_rcu()'s single argument name is deprecated therefore > rename it to kfree_rcu_mightsleep() variant. The goal is explicitly > underline that it is for sleepable contexts. > > Cc: Ariel Levkovich <lariel@nvidia.com> > Cc: Saeed Mahameed <saeedm@nvidia.com> > Cc: Vlad Buslov <vladbu@nvidia.com> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Could you please add you reviwed-by or Acked-by tags so we can bring our series with renaming for the next merge window? Thanks! -- Uladzislau Rezki
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c index ca834bbcb44f..8afcec0c5d3c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c @@ -242,7 +242,7 @@ mlx5e_int_port_remove(struct mlx5e_tc_int_port_priv *priv, mlx5_del_flow_rules(int_port->rx_rule); mapping_remove(ctx, int_port->mapping); mlx5e_int_port_metadata_free(priv, int_port->match_metadata); - kfree_rcu(int_port); + kfree_rcu_mightsleep(int_port); priv->num_ports--; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 9369a580743e..5d32a8a5e5a4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -672,7 +672,7 @@ static int mlx5e_macsec_del_txsa(struct macsec_context *ctx) mlx5e_macsec_cleanup_sa(macsec, tx_sa, true); mlx5_destroy_encryption_key(macsec->mdev, tx_sa->enc_key_id); - kfree_rcu(tx_sa); + kfree_rcu_mightsleep(tx_sa); macsec_device->tx_sa[assoc_num] = NULL; out: @@ -851,7 +851,7 @@ static void macsec_del_rxsc_ctx(struct mlx5e_macsec *macsec, struct mlx5e_macsec xa_erase(&macsec->sc_xarray, rx_sc->sc_xarray_element->fs_id); metadata_dst_free(rx_sc->md_dst); kfree(rx_sc->sc_xarray_element); - kfree_rcu(rx_sc); + kfree_rcu_mightsleep(rx_sc); } static int mlx5e_macsec_del_rxsc(struct macsec_context *ctx)
The kfree_rcu()'s single argument name is deprecated therefore rename it to kfree_rcu_mightsleep() variant. The goal is explicitly underline that it is for sleepable contexts. Cc: Ariel Levkovich <lariel@nvidia.com> Cc: Saeed Mahameed <saeedm@nvidia.com> Cc: Vlad Buslov <vladbu@nvidia.com> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> --- drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)