| Message ID | 20230310200652.19926-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | power: reset: qcom-pon: drop of_match_ptr for ID table | expand |
On 10.03.2023 21:06, Krzysztof Kozlowski wrote: > The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends > on OF thus the driver is OF-only. It's of_device_id table is built > unconditionally, thus of_match_ptr() for ID table does not make sense. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/power/reset/qcom-pon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c > index 16bc01738be9..ebdcfb28c4a0 100644 > --- a/drivers/power/reset/qcom-pon.c > +++ b/drivers/power/reset/qcom-pon.c > @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = { > .probe = pm8916_pon_probe, > .driver = { > .name = "pm8916-pon", > - .of_match_table = of_match_ptr(pm8916_pon_id_table), > + .of_match_table = pm8916_pon_id_table, > }, > }; > module_platform_driver(pm8916_pon_driver);
On 2023-03-10 21:06:52, Krzysztof Kozlowski wrote: > The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends > on OF thus the driver is OF-only. It's of_device_id table is built Its* > unconditionally, thus of_match_ptr() for ID table does not make sense. Agreed. Searching for of_match_ptr on any *qcom* file yields 25 results on a few-weeks-old tree, are you planning on assessing those too? > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/power/reset/qcom-pon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c > index 16bc01738be9..ebdcfb28c4a0 100644 > --- a/drivers/power/reset/qcom-pon.c > +++ b/drivers/power/reset/qcom-pon.c > @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = { > .probe = pm8916_pon_probe, > .driver = { > .name = "pm8916-pon", > - .of_match_table = of_match_ptr(pm8916_pon_id_table), > + .of_match_table = pm8916_pon_id_table, > }, > }; > module_platform_driver(pm8916_pon_driver); > -- > 2.34.1 >
On 10/03/2023 21:48, Marijn Suijten wrote: > On 2023-03-10 21:06:52, Krzysztof Kozlowski wrote: >> The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends >> on OF thus the driver is OF-only. It's of_device_id table is built > > Its* > >> unconditionally, thus of_match_ptr() for ID table does not make sense. > > Agreed. Searching for of_match_ptr on any *qcom* file yields 25 results > on a few-weeks-old tree, are you planning on assessing those too? > There are just few incorrect usages, I'll fix these. Rest has proper maybe_unused or ifdef. Best regards, Krzysztof
Hi, On Fri, Mar 10, 2023 at 09:06:52PM +0100, Krzysztof Kozlowski wrote: > The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends > on OF thus the driver is OF-only. It's of_device_id table is built > unconditionally, thus of_match_ptr() for ID table does not make sense. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Thanks, queued to power-supply's for next branch. -- Sebastian > drivers/power/reset/qcom-pon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c > index 16bc01738be9..ebdcfb28c4a0 100644 > --- a/drivers/power/reset/qcom-pon.c > +++ b/drivers/power/reset/qcom-pon.c > @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = { > .probe = pm8916_pon_probe, > .driver = { > .name = "pm8916-pon", > - .of_match_table = of_match_ptr(pm8916_pon_id_table), > + .of_match_table = pm8916_pon_id_table, > }, > }; > module_platform_driver(pm8916_pon_driver); > -- > 2.34.1 >
diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c index 16bc01738be9..ebdcfb28c4a0 100644 --- a/drivers/power/reset/qcom-pon.c +++ b/drivers/power/reset/qcom-pon.c @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = { .probe = pm8916_pon_probe, .driver = { .name = "pm8916-pon", - .of_match_table = of_match_ptr(pm8916_pon_id_table), + .of_match_table = pm8916_pon_id_table, }, }; module_platform_driver(pm8916_pon_driver);
The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends on OF thus the driver is OF-only. It's of_device_id table is built unconditionally, thus of_match_ptr() for ID table does not make sense. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/power/reset/qcom-pon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)