| Message ID | 20230310203438.1585701-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
| Series | [RFC] arm64: dts: qcom: sm8350-hdk: enable IPA | expand |
On 3/10/23 2:34 PM, Dmitry Baryshkov wrote: > Although the HDK has no radio, the IPA part is still perfectly usable > (altough it doesn't register any real networking devices). Enable it to > make it possible to test IPA on this platform. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> I like that you've captured this, but I'm not sure I like the idea of enabling this if the modem is never expected to function as, you know, a modem. At a minimum I'd want to be sure we could exercise IPA in loopback mode before considering this seriously. I could work with you to experiment with doing that next week if you want. This isn't an outright "no" though; let's see if anyone else feels strongly one way or the other. -Alex > --- > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > index 09baf6959c71..60fbb2f49720 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > @@ -746,3 +746,10 @@ irq-pins { > }; > }; > }; > + > +&ipa { > + qcom,gsi-loader = "self"; > + memory-region = <&pil_ipa_fw_mem>; > + status = "okay"; > + firmware-name = "qcom/sm8350/ipa_fws.mbn"; > +};
On Fri, 10 Mar 2023 at 23:25, Alex Elder <elder@linaro.org> wrote: > > On 3/10/23 2:34 PM, Dmitry Baryshkov wrote: > > Although the HDK has no radio, the IPA part is still perfectly usable > > (altough it doesn't register any real networking devices). Enable it to > > make it possible to test IPA on this platform. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > I like that you've captured this, but I'm not sure I > like the idea of enabling this if the modem is never > expected to function as, you know, a modem. Ack. > At a minimum I'd want to be sure we could exercise > IPA in loopback mode before considering this seriously. > I could work with you to experiment with doing that > next week if you want. If it is an expected/reasonable feature, why not. > > This isn't an outright "no" though; let's see if anyone > else feels strongly one way or the other. > > -Alex > > > --- > > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > > index 09baf6959c71..60fbb2f49720 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > > @@ -746,3 +746,10 @@ irq-pins { > > }; > > }; > > }; > > + > > +&ipa { > > + qcom,gsi-loader = "self"; > > + memory-region = <&pil_ipa_fw_mem>; > > + status = "okay"; > > + firmware-name = "qcom/sm8350/ipa_fws.mbn"; > > +}; >
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts index 09baf6959c71..60fbb2f49720 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts @@ -746,3 +746,10 @@ irq-pins { }; }; }; + +&ipa { + qcom,gsi-loader = "self"; + memory-region = <&pil_ipa_fw_mem>; + status = "okay"; + firmware-name = "qcom/sm8350/ipa_fws.mbn"; +};
Although the HDK has no radio, the IPA part is still perfectly usable (altough it doesn't register any real networking devices). Enable it to make it possible to test IPA on this platform. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 7 +++++++ 1 file changed, 7 insertions(+)