| Message ID | 20230310221851.304657-1-vincenzopalazzodev@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ad4bf5f2406f6a2e29266bbad74e18f0d955ac4c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: socket: suppress unused warning | expand |
From: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> Date: Fri, 10 Mar 2023 23:18:51 +0100 > suppress unused warnings and fix the error that there is > with the W=1 enabled. > > Warning generated > > net/socket.c: In function ‘__sys_getsockopt’: > net/socket.c:2300:13: error: variable ‘max_optlen’ set but not used [-Werror=unused-but-set-variable] > 2300 | int max_optlen; > > Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Thanks, Kuniyuki > --- > net/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/socket.c b/net/socket.c > index 6bae8ce7059e..ad081c9b429f 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -2295,9 +2295,9 @@ INDIRECT_CALLABLE_DECLARE(bool tcp_bpf_bypass_getsockopt(int level, > int __sys_getsockopt(int fd, int level, int optname, char __user *optval, > int __user *optlen) > { > + int max_optlen __maybe_unused; > int err, fput_needed; > struct socket *sock; > - int max_optlen; > > sock = sockfd_lookup_light(fd, &err, &fput_needed); > if (!sock) > -- > 2.39.2
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 10 Mar 2023 23:18:51 +0100 you wrote: > suppress unused warnings and fix the error that there is > with the W=1 enabled. > > Warning generated > > net/socket.c: In function ‘__sys_getsockopt’: > net/socket.c:2300:13: error: variable ‘max_optlen’ set but not used [-Werror=unused-but-set-variable] > 2300 | int max_optlen; > > [...] Here is the summary with links: - [v2] net: socket: suppress unused warning https://git.kernel.org/netdev/net-next/c/ad4bf5f2406f You are awesome, thank you!
diff --git a/net/socket.c b/net/socket.c index 6bae8ce7059e..ad081c9b429f 100644 --- a/net/socket.c +++ b/net/socket.c @@ -2295,9 +2295,9 @@ INDIRECT_CALLABLE_DECLARE(bool tcp_bpf_bypass_getsockopt(int level, int __sys_getsockopt(int fd, int level, int optname, char __user *optval, int __user *optlen) { + int max_optlen __maybe_unused; int err, fput_needed; struct socket *sock; - int max_optlen; sock = sockfd_lookup_light(fd, &err, &fput_needed); if (!sock)
suppress unused warnings and fix the error that there is with the W=1 enabled. Warning generated net/socket.c: In function ‘__sys_getsockopt’: net/socket.c:2300:13: error: variable ‘max_optlen’ set but not used [-Werror=unused-but-set-variable] 2300 | int max_optlen; Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)