mbox series

[00/14] cros-ec-tests: fix some exceptions and clean-ups

Message ID 20230313094431.507952-1-tzungbi@kernel.org (mailing list archive)
Headers show
Series cros-ec-tests: fix some exceptions and clean-ups | expand

Message

Tzung-Bi Shih March 13, 2023, 9:44 a.m. UTC 
The series changes cros-ec-tests[1].

It applys some clean-ups and fixes obvious errors.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/cros-ec-tests.git/

Tzung-Bi Shih (14):
  lava_runner: rename to LavaTestResult
  lava_runner: use TextTestRunner
  lava_runner: use TextTestResult
  lava_runner: respect to verbosity flag from unittest framework
  helpers/sysfs: fix NameError
  helpers/mcu: fix ResourceWarning on /dev/cros_ec
  cros_ec_pwm: fix ResourceWarning on /sys/kernel/debug/pwm
  treewide: use context manager on file objects
  cros_ec_pwm: use RE to search EC backlight PWM
  helpers/mcu: fix packet too long error
  helpers/mcu: fix EC_CMD_GET_FEATURES usage
  treewide: remove "r" in open() if reading mode
  treewide: don't use "+" operator for constructing paths
  treewide: don't use "+" operator for concatenating strings

 cros/helpers/kernel.py       |  5 ++-
 cros/helpers/mcu.py          | 57 ++++++++++++++------------------
 cros/helpers/sysfs.py        | 16 ++++-----
 cros/runners/lava_runner.py  | 64 +++++++++++++++---------------------
 cros/tests/cros_ec_accel.py  | 13 ++++----
 cros/tests/cros_ec_extcon.py | 11 ++++---
 cros/tests/cros_ec_pwm.py    | 58 +++++++++++++-------------------
 cros/tests/cros_ec_rtc.py    |  8 ++---
 setup.py                     |  2 +-
 9 files changed, 99 insertions(+), 135 deletions(-)

Comments

Ricardo Cañuelo March 13, 2023, 11:53 a.m. UTC | #1 
Hi all,

On 13/3/23 10:44, Tzung-Bi Shih wrote:> The series changes cros-ec-tests[1].
> 
> It applys some clean-ups and fixes obvious errors.
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/cros-ec-tests.git/

FWIW, there's also this fork [1], that's a bit ahead of [2] and
it's the one we're currently using for KernelCI [3], since Enric
is not maintaining the old one anymore.

Benson, is the cros-ec repo at kernel.org still alive and
maintained? If so we'll sync it to [1] after this patch lands and
point KernelCI to it.

Cheers,
Ricardo

[1]: https://github.com/kernelci/cros-ec-tests
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/cros-ec-tests.git/
[3]: https://github.com/kernelci/kernelci-core/pull/1722
Tzung-Bi Shih March 14, 2023, 3:09 a.m. UTC | #2 
Hi Ricardo,

On Mon, Mar 13, 2023 at 12:53:01PM +0100, Ricardo Cañuelo wrote:
> On 13/3/23 10:44, Tzung-Bi Shih wrote:> The series changes cros-ec-tests[1].
> > 
> > It applys some clean-ups and fixes obvious errors.
> > 
> > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/cros-ec-tests.git/
> 
> FWIW, there's also this fork [1], that's a bit ahead of [2] and
> it's the one we're currently using for KernelCI [3], since Enric
> is not maintaining the old one anymore.

My original plan was refactoring and cleaning [2] first.  And then porting [4]
to the latest code base.

[4]: https://github.com/kernelci/cros-ec-tests/commit/f6c0dbf63842d5751000c5527808aca38354db55

> Benson, is the cros-ec repo at kernel.org still alive and
> maintained? If so we'll sync it to [1] after this patch lands and
> point KernelCI to it.

I have no strong preference for where to host the repo.  It would be fine if
we abandoned the cros-ec-tests repo at kernel.org.

I guess it would be easier to start from [1] as [3] already pointed to it.  If
it makes sense, I would rebase the series and send to [1].

> [1]: https://github.com/kernelci/cros-ec-tests
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/cros-ec-tests.git/
> [3]: https://github.com/kernelci/kernelci-core/pull/1722
Guillaume Tucker March 14, 2023, 6:47 a.m. UTC | #3 
On Tuesday, March 14, 2023 04:09 CET, Tzung-Bi Shih <tzungbi@kernel.org> wrote:

> Hi Ricardo,
> 
> On Mon, Mar 13, 2023 at 12:53:01PM +0100, Ricardo Cañuelo wrote:
> > On 13/3/23 10:44, Tzung-Bi Shih wrote:> The series changes cros-ec-tests[1].
> > > 
> > > It applys some clean-ups and fixes obvious errors.
> > > 
> > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/cros-ec-tests.git/
> > 
> > FWIW, there's also this fork [1], that's a bit ahead of [2] and
> > it's the one we're currently using for KernelCI [3], since Enric
> > is not maintaining the old one anymore.
> 
> My original plan was refactoring and cleaning [2] first.  And then porting [4]
> to the latest code base.
> 
> [4]: https://github.com/kernelci/cros-ec-tests/commit/f6c0dbf63842d5751000c5527808aca38354db55
> 
> > Benson, is the cros-ec repo at kernel.org still alive and
> > maintained? If so we'll sync it to [1] after this patch lands and
> > point KernelCI to it.
> 
> I have no strong preference for where to host the repo.  It would be fine if
> we abandoned the cros-ec-tests repo at kernel.org.
> 
> I guess it would be easier to start from [1] as [3] already pointed to it.  If
> it makes sense, I would rebase the series and send to [1].
> 
> > [1]: https://github.com/kernelci/cros-ec-tests
> > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/cros-ec-tests.git/
> > [3]: https://github.com/kernelci/kernelci-core/pull/1722

I believe it would be much better to have this on kernel.org as long as we have a maintainer available.

Guillaume