| Message ID | 20230307-topic-dsi_qcm-v3-8-8bd7e1add38a@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix DSI host idx detection on HW revision clash | expand |
On 2023-03-07 14:01:46, Konrad Dybcio wrote: > The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" > alone. This however didn't quite work out and the property became > undocumented instead of deprecated. Fix that. > > Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Yes. From the previous binding (prior to that patch) either qcom,mdss-dsi-ctrl _or_ qcom,dsi-ctrl-6g-qcm2290 was allowed, not a pair of both. Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index 2494817c1bd6..94f4cdf88c95 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -34,7 +34,7 @@ properties: > - items: > - enum: > - qcom,dsi-ctrl-6g-qcm2290 No comment that it was simply renamed? > - - const: qcom,mdss-dsi-ctrl > + - qcom,mdss-dsi-ctrl # This should always come with an SoC-specific compatible > deprecated: true > > reg: > > -- > 2.39.2 >
On 14.03.2023 01:15, Marijn Suijten wrote: > On 2023-03-07 14:01:46, Konrad Dybcio wrote: >> The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" >> alone. This however didn't quite work out and the property became >> undocumented instead of deprecated. Fix that. >> >> Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC") >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Yes. From the previous binding (prior to that patch) either > qcom,mdss-dsi-ctrl _or_ qcom,dsi-ctrl-6g-qcm2290 was allowed, not a pair > of both. > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > >> --- >> Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> index 2494817c1bd6..94f4cdf88c95 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> @@ -34,7 +34,7 @@ properties: >> - items: >> - enum: >> - qcom,dsi-ctrl-6g-qcm2290 > > No comment that it was simply renamed? That was mostly handled by Bryan's series. Konrad > >> - - const: qcom,mdss-dsi-ctrl >> + - qcom,mdss-dsi-ctrl # This should always come with an SoC-specific compatible >> deprecated: true >> >> reg: >> >> -- >> 2.39.2 >>
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index 2494817c1bd6..94f4cdf88c95 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -34,7 +34,7 @@ properties: - items: - enum: - qcom,dsi-ctrl-6g-qcm2290 - - const: qcom,mdss-dsi-ctrl + - qcom,mdss-dsi-ctrl # This should always come with an SoC-specific compatible deprecated: true reg:
The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" alone. This however didn't quite work out and the property became undocumented instead of deprecated. Fix that. Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC") Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)