| Message ID | 20230314065802.1532741-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net/sched: fix parsing of TCA_EXT_WARN_MSG for tc action | expand |
On Tue, Mar 14, 2023 at 02:58:00PM +0800, Hangbin Liu wrote: > In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG > to report tc extact message") I didn't notice the tc action use different > enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action. Reported-and-tested-by: Davide Caratti <dcaratti@redhat.com> thanks!
On Tue, Mar 14, 2023 at 10:20:24AM +0100, Davide Caratti wrote: > On Tue, Mar 14, 2023 at 02:58:00PM +0800, Hangbin Liu wrote: > > In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG > > to report tc extact message") I didn't notice the tc action use different > > enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action. > > Reported-and-tested-by: Davide Caratti <dcaratti@redhat.com> Thanks Davide, I forgot to add the Reported-by flag. Hangbin
In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG to report tc extact message") I didn't notice the tc action use different enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action. Let's rever the previous fix 923b2e30dc9c ("net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy") and add a new TCA_ACT_EXT_WARN_MSG for tc action specifically. Here is the tdc test result: 1..1119 ok 1 d959 - Add cBPF action with valid bytecode ok 2 f84a - Add cBPF action with invalid bytecode ok 3 e939 - Add eBPF action with valid object-file ok 4 282d - Add eBPF action with invalid object-file ok 5 d819 - Replace cBPF bytecode and action control ok 6 6ae3 - Delete cBPF action ok 7 3e0d - List cBPF actions ok 8 55ce - Flush BPF actions ok 9 ccc3 - Add cBPF action with duplicate index ok 10 89c7 - Add cBPF action with invalid index [...] ok 1115 2348 - Show TBF class ok 1116 84a0 - Create TEQL with default setting ok 1117 7734 - Create TEQL with multiple device ok 1118 34a9 - Delete TEQL with valid handle ok 1119 6289 - Show TEQL stats Hangbin Liu (2): Revert "net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy" net/sched: act_api: add specific EXT_WARN_MSG for tc action include/uapi/linux/rtnetlink.h | 1 + net/sched/act_api.c | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-)