| Message ID | 20230314104055.1475054-2-s-vadapalli@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable MCU CPSW2G on J7AHP | expand |
On 16:10-20230314, Siddharth Vadapalli wrote: > The "ti,sci-dev-id" property used to indicate the Device ID is missing > for mcu_navss device-tree node. Add it. > Needs a "Fixes:" ? > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > index 93952af618f6..52311da15579 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > @@ -212,6 +212,8 @@ mcu_navss: bus@28380000{ > dma-coherent; > dma-ranges; > > + ti,sci-dev-id = <323>; > + > mcu_ringacc: ringacc@2b800000 { > compatible = "ti,am654-navss-ringacc"; > reg = <0x00 0x2b800000 0x00 0x400000>, > -- > 2.25.1 >
On 16:10-20230314, Siddharth Vadapalli wrote: > The "ti,sci-dev-id" property used to indicate the Device ID is missing > for mcu_navss device-tree node. Add it. > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > index 93952af618f6..52311da15579 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > @@ -212,6 +212,8 @@ mcu_navss: bus@28380000{ > dma-coherent; > dma-ranges; > > + ti,sci-dev-id = <323>; > + > mcu_ringacc: ringacc@2b800000 { > compatible = "ti,am654-navss-ringacc"; > reg = <0x00 0x2b800000 0x00 0x400000>, > -- > 2.25.1 > Looks like https://lore.kernel.org/all/20230313104721.407071-2-j-choudhary@ti.com/ is another part of the Fixup? Why not squash the two as a missing ti,sci-dev-id for j784s4?
On 14/03/23 18:59, Nishanth Menon wrote: > On 16:10-20230314, Siddharth Vadapalli wrote: >> The "ti,sci-dev-id" property used to indicate the Device ID is missing >> for mcu_navss device-tree node. Add it. >> >> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> index 93952af618f6..52311da15579 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> @@ -212,6 +212,8 @@ mcu_navss: bus@28380000{ >> dma-coherent; >> dma-ranges; >> >> + ti,sci-dev-id = <323>; >> + >> mcu_ringacc: ringacc@2b800000 { >> compatible = "ti,am654-navss-ringacc"; >> reg = <0x00 0x2b800000 0x00 0x400000>, >> -- >> 2.25.1 >> > > Looks like > https://lore.kernel.org/all/20230313104721.407071-2-j-choudhary@ti.com/ > is another part of the Fixup? > > Why not squash the two as a missing ti,sci-dev-id for j784s4? Okay I will add this to my series and re-roll v2. -Jayesh > >
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi index 93952af618f6..52311da15579 100644 --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi @@ -212,6 +212,8 @@ mcu_navss: bus@28380000{ dma-coherent; dma-ranges; + ti,sci-dev-id = <323>; + mcu_ringacc: ringacc@2b800000 { compatible = "ti,am654-navss-ringacc"; reg = <0x00 0x2b800000 0x00 0x400000>,
The "ti,sci-dev-id" property used to indicate the Device ID is missing for mcu_navss device-tree node. Add it. Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> --- arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 ++ 1 file changed, 2 insertions(+)