diff mbox series

[2/3] net: mvpp2: parser fix QinQ

Message ID 20230311071005.enqji2btj35ewx53@Svens-MacBookPro.local (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series [1/3] net: mvpp2: classifier flow remove tagged | expand

Checks

Context Check Description
netdev/series_format warning Series does not have a cover letter; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 18 this patch: 18
netdev/cc_maintainers warning 2 maintainers not CCed: edumazet@google.com pabeni@redhat.com
netdev/build_clang success Errors and warnings before: 18 this patch: 18
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 18 this patch: 18
netdev/checkpatch warning CHECK: From:/Signed-off-by: email comments mismatch: 'From: Sven Auhagen <Sven.Auhagen@voleatech.de>' != 'Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>'
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Sven Auhagen March 11, 2023, 7:10 a.m. UTC 
The mvpp2 parser entry for QinQ has the inner and outer VLAN
in the wrong order.
Fix the problem by swapping them.

Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>

Comments

Jakub Kicinski March 15, 2023, 7 a.m. UTC | #1 
On Sat, 11 Mar 2023 08:10:05 +0100 Sven Auhagen wrote:
> The mvpp2 parser entry for QinQ has the inner and outer VLAN
> in the wrong order.
> Fix the problem by swapping them.
> 
> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>

Can we get a Fixes tag for this change?
Sven Auhagen March 15, 2023, 7:54 a.m. UTC | #2 
On Wed, Mar 15, 2023 at 12:00:02AM -0700, Jakub Kicinski wrote:
> On Sat, 11 Mar 2023 08:10:05 +0100 Sven Auhagen wrote:
> > The mvpp2 parser entry for QinQ has the inner and outer VLAN
> > in the wrong order.
> > Fix the problem by swapping them.
> > 
> > Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
> 
> Can we get a Fixes tag for this change?

Yes, I will add it in v2.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
index 75ba57bd1d46..ed8be396428b 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c
@@ -1539,8 +1539,8 @@  static int mvpp2_prs_vlan_init(struct platform_device *pdev, struct mvpp2 *priv)
 	if (!priv->prs_double_vlans)
 		return -ENOMEM;
 
-	/* Double VLAN: 0x8100, 0x88A8 */
-	err = mvpp2_prs_double_vlan_add(priv, ETH_P_8021Q, ETH_P_8021AD,
+	/* Double VLAN: 0x88A8, 0x8100 */
+	err = mvpp2_prs_double_vlan_add(priv, ETH_P_8021AD, ETH_P_8021Q,
 					MVPP2_PRS_PORT_MASK);
 	if (err)
 		return err;