| Message ID | 20230317124915.1263-3-sundongxu3@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: Use specific checking for TPIDR2 and some comments update | expand |
On Fri, Mar 17, 2023 at 08:49:13PM +0800, Dongxu Sun wrote: > Move tpidr2 sigframe allocation from under the checking of > system_supports_sme() to the checking of system_supports_tpidr2(). Reviewed-by: Mark Brown <broonie@kernel.org> I didn't check the context enough to confirm if this may reorder things in the sigframe but given that we don't have shipping hardware yet and the layout is generally subject to change I think that's fine.
diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c index 032e97f8cae0..2cfc810d0a5b 100644 --- a/arch/arm64/kernel/signal.c +++ b/arch/arm64/kernel/signal.c @@ -893,6 +893,13 @@ static int setup_sigframe_layout(struct rt_sigframe_user_layout *user, return err; } + if (system_supports_tpidr2()) { + err = sigframe_alloc(user, &user->tpidr2_offset, + sizeof(struct tpidr2_context)); + if (err) + return err; + } + if (system_supports_sme()) { unsigned int vl; unsigned int vq = 0; @@ -902,11 +909,6 @@ static int setup_sigframe_layout(struct rt_sigframe_user_layout *user, else vl = task_get_sme_vl(current); - err = sigframe_alloc(user, &user->tpidr2_offset, - sizeof(struct tpidr2_context)); - if (err) - return err; - if (thread_za_enabled(¤t->thread)) vq = sve_vq_from_vl(vl);
Move tpidr2 sigframe allocation from under the checking of system_supports_sme() to the checking of system_supports_tpidr2(). Signed-off-by: Dongxu Sun <sundongxu3@huawei.com> --- arch/arm64/kernel/signal.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)