| Message ID | 20230317155539.2552954-2-edumazet@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 94c540fbfc80ef95ec398fc77da1920de2946edb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: better const qualifier awareness | expand |
On Fri, Mar 17, 2023 at 03:55:30PM +0000, Eric Dumazet wrote: > We can change udp_sk() to propagate const qualifier of its argument, > thanks to container_of_const() > > This should avoid some potential errors caused by accidental > (const -> not_const) promotion. > > Signed-off-by: Eric Dumazet <edumazet@google.com> > Cc: Willem de Bruijn <willemb@google.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
diff --git a/include/linux/udp.h b/include/linux/udp.h index a2892e151644ec347ad52d426400678e4a53b359..43c1fb2d2c21afc01abdf20e4b9c03f04932c19b 100644 --- a/include/linux/udp.h +++ b/include/linux/udp.h @@ -97,10 +97,7 @@ struct udp_sock { #define UDP_MAX_SEGMENTS (1 << 6UL) -static inline struct udp_sock *udp_sk(const struct sock *sk) -{ - return (struct udp_sock *)sk; -} +#define udp_sk(ptr) container_of_const(ptr, struct udp_sock, inet.sk) static inline void udp_set_no_check6_tx(struct sock *sk, bool val) {
We can change udp_sk() to propagate const qualifier of its argument, thanks to container_of_const() This should avoid some potential errors caused by accidental (const -> not_const) promotion. Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Willem de Bruijn <willemb@google.com> --- include/linux/udp.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)