| Message ID | 20230318121828.739424-17-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Qualcomm PMIC TPCM support | expand |
On 18.03.2023 13:18, Bryan O'Donoghue wrote: > Switch on TCPM for the RB5. Here we declare as a source only not a sink > since qrb5165 doesn't support powering exclusively from the type-c port. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 25 ++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index 1ce88f0c31db2..965742a5be7ae 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -9,6 +9,7 @@ > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include <dt-bindings/sound/qcom,q6afe.h> > #include <dt-bindings/sound/qcom,q6asm.h> > +#include <dt-bindings/usb/pd.h> > #include "sm8250.dtsi" > #include "pm8150.dtsi" > #include "pm8150b.dtsi" > @@ -1339,8 +1340,32 @@ &qup_spi0_data_clk { > bias-disable; > }; > > +&pm8150b_typec { > + status = "okay"; > +}; > + > +&pm8150b_pdphy { > + status = "okay"; > +}; Swap these two ('p' < 't') > + > &pm8150b_vbus { > regulator-min-microamp = <500000>; > regulator-max-microamp = <3000000>; > status = "okay"; > }; > + > +&tcpm { > + status = "okay"; Add a newline before the child node, please With that: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > + connector { > + compatible = "usb-c-connector"; > + > + power-role = "source"; > + data-role = "dual"; > + self-powered; > + > + source-pdos = <PDO_FIXED(5000, 3000, > + PDO_FIXED_DUAL_ROLE | > + PDO_FIXED_USB_COMM | > + PDO_FIXED_DATA_SWAP)>; > + }; > +};
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index 1ce88f0c31db2..965742a5be7ae 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -9,6 +9,7 @@ #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include <dt-bindings/sound/qcom,q6afe.h> #include <dt-bindings/sound/qcom,q6asm.h> +#include <dt-bindings/usb/pd.h> #include "sm8250.dtsi" #include "pm8150.dtsi" #include "pm8150b.dtsi" @@ -1339,8 +1340,32 @@ &qup_spi0_data_clk { bias-disable; }; +&pm8150b_typec { + status = "okay"; +}; + +&pm8150b_pdphy { + status = "okay"; +}; + &pm8150b_vbus { regulator-min-microamp = <500000>; regulator-max-microamp = <3000000>; status = "okay"; }; + +&tcpm { + status = "okay"; + connector { + compatible = "usb-c-connector"; + + power-role = "source"; + data-role = "dual"; + self-powered; + + source-pdos = <PDO_FIXED(5000, 3000, + PDO_FIXED_DUAL_ROLE | + PDO_FIXED_USB_COMM | + PDO_FIXED_DATA_SWAP)>; + }; +};
Switch on TCPM for the RB5. Here we declare as a source only not a sink since qrb5165 doesn't support powering exclusively from the type-c port. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 25 ++++++++++++++++++++++++ 1 file changed, 25 insertions(+)