| Message ID | 20230316120826.14242-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a593a2fcfdfb92cfd0ffc54bc81b07e6bfaaaf46 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1,1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used | expand |
On Thu, Mar 16, 2023 at 02:08:26PM +0200, Andy Shevchenko wrote: > of_gpio.h in this driver is solely used as a proxy to other headers. > This is incorrect usage of the of_gpio.h. Replace it .h with what > indeed is used in the code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 16 Mar 2023 14:08:26 +0200 you wrote: > of_gpio.h in this driver is solely used as a proxy to other headers. > This is incorrect usage of the of_gpio.h. Replace it .h with what > indeed is used in the code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/net/phy/at803x.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Here is the summary with links: - [net-next,v1,1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used https://git.kernel.org/netdev/net-next/c/a593a2fcfdfb You are awesome, thank you!
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 22f4458274aa..656136628ffd 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -13,12 +13,11 @@ #include <linux/netdevice.h> #include <linux/etherdevice.h> #include <linux/ethtool_netlink.h> -#include <linux/of_gpio.h> #include <linux/bitfield.h> -#include <linux/gpio/consumer.h> #include <linux/regulator/of_regulator.h> #include <linux/regulator/driver.h> #include <linux/regulator/consumer.h> +#include <linux/of.h> #include <linux/phylink.h> #include <linux/sfp.h> #include <dt-bindings/net/qca-ar803x.h>
of_gpio.h in this driver is solely used as a proxy to other headers. This is incorrect usage of the of_gpio.h. Replace it .h with what indeed is used in the code. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/net/phy/at803x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)