Message ID | 20230310120553.60586-2-jack.zhu@starfivetech.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Add Starfive Camera Subsystem driver | expand |
Hi Jack, Thank you for the patch. On Fri, Mar 10, 2023 at 08:05:48PM +0800, Jack Zhu wrote: > Add the bindings documentation for Starfive JH7110 Camera Subsystem > which is used for handing image sensor data. > > Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com> > --- > .../bindings/media/starfive,jh7110-camss.yaml | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > new file mode 100644 > index 000000000000..3f348dd53441 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive SoC CAMSS ISP > + > +maintainers: > + - Jack Zhu <jack.zhu@starfivetech.com> > + - Changhuang Liang <changhuang.liang@starfivetech.com> > + > +description: > + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC.It s/.It/. It/ > + consists of a VIN controller(Video In Controller, a top-level control until) s/(/ (/ > + and an ISP. > + > +properties: > + compatible: > + const: starfive,jh7110-camss > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: syscon > + - const: isp > + > + clocks: > + maxItems: 7 > + > + clock-names: > + items: > + - const: apb_func > + - const: wrapper_clk_c > + - const: dvp_inv > + - const: axiwr > + - const: mipi_rx0_pxl > + - const: ispcore_2x > + - const: isp_axi > + > + resets: > + maxItems: 6 > + > + reset-names: > + items: > + - const: wrapper_p > + - const: wrapper_c > + - const: axird > + - const: axiwr > + - const: isp_top_n > + - const: isp_top_axi > + > + power-domains: > + items: > + - description: JH7110 ISP Power Domain Switch Controller. > + > + interrupts: > + maxItems: 4 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@1: Why port@1 if there is no port@0 ? > + $ref: /schemas/graph.yaml#/$defs/port-base I think you can use $ref: /schemas/graph.yaml#/properties/port here as you don't define any additional property for the port node. > + unevaluatedProperties: false > + description: > + Input port for receiving CSI data. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + required: > + - port@1 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - resets > + - reset-names > + - power-domains > + - interrupts The 'ports' node should be mandatory too. > + > +additionalProperties: false > + > +examples: > + - | > + stfcamss: isp@19840000 { You can drop the label as it's not used. > + compatible = "starfive,jh7110-camss"; > + reg = <0x19840000 0x10000>, > + <0x19870000 0x30000>; > + reg-names = "syscon", "isp"; > + clocks = <&ispcrg 0>, > + <&ispcrg 13>, > + <&ispcrg 2>, > + <&ispcrg 12>, > + <&ispcrg 1>, > + <&syscrg 51>, > + <&syscrg 52>; > + clock-names = "apb_func", > + "wrapper_clk_c", > + "dvp_inv", > + "axiwr", > + "mipi_rx0_pxl", > + "ispcore_2x", > + "isp_axi"; > + resets = <&ispcrg 0>, > + <&ispcrg 1>, > + <&ispcrg 10>, > + <&ispcrg 11>, > + <&syscrg 41>, > + <&syscrg 42>; > + reset-names = "wrapper_p", > + "wrapper_c", > + "axird", > + "axiwr", > + "isp_top_n", > + "isp_top_axi"; > + power-domains = <&pwrc 5>; > + interrupts = <92>, <87>, <88>, <90>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + vin_from_csi2rx: endpoint { > + remote-endpoint = <&csi2rx_to_vin>; > + }; > + }; > + }; > + };
On 10/03/2023 13:05, Jack Zhu wrote: > Add the bindings documentation for Starfive JH7110 Camera Subsystem > which is used for handing image sensor data. > > Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com> > --- > .../bindings/media/starfive,jh7110-camss.yaml | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > new file mode 100644 > index 000000000000..3f348dd53441 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive SoC CAMSS ISP > + > +maintainers: > + - Jack Zhu <jack.zhu@starfivetech.com> > + - Changhuang Liang <changhuang.liang@starfivetech.com> > + > +description: > + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC.It > + consists of a VIN controller(Video In Controller, a top-level control until) > + and an ISP. > + > +properties: > + compatible: > + const: starfive,jh7110-camss > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: syscon > + - const: isp > + > + clocks: > + maxItems: 7 > + > + clock-names: > + items: > + - const: apb_func > + - const: wrapper_clk_c > + - const: dvp_inv > + - const: axiwr > + - const: mipi_rx0_pxl > + - const: ispcore_2x > + - const: isp_axi > + > + resets: > + maxItems: 6 > + > + reset-names: > + items: > + - const: wrapper_p > + - const: wrapper_c > + - const: axird > + - const: axiwr > + - const: isp_top_n > + - const: isp_top_axi > + > + power-domains: > + items: > + - description: JH7110 ISP Power Domain Switch Controller. > + > + interrupts: > + maxItems: 4 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: You should have here port@0. The binding does not represent what is supported by Linux. Binding represents hardware and you said you have port@0 for the sensor. > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port for receiving CSI data. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + required: > + - port@1 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - resets > + - reset-names > + - power-domains > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + stfcamss: isp@19840000 { > + compatible = "starfive,jh7110-camss"; > + reg = <0x19840000 0x10000>, > + <0x19870000 0x30000>; > + reg-names = "syscon", "isp"; > + clocks = <&ispcrg 0>, > + <&ispcrg 13>, > + <&ispcrg 2>, > + <&ispcrg 12>, > + <&ispcrg 1>, > + <&syscrg 51>, > + <&syscrg 52>; > + clock-names = "apb_func", > + "wrapper_clk_c", > + "dvp_inv", > + "axiwr", > + "mipi_rx0_pxl", > + "ispcore_2x", > + "isp_axi"; > + resets = <&ispcrg 0>, > + <&ispcrg 1>, > + <&ispcrg 10>, > + <&ispcrg 11>, > + <&syscrg 41>, > + <&syscrg 42>; > + reset-names = "wrapper_p", > + "wrapper_c", > + "axird", > + "axiwr", > + "isp_top_n", > + "isp_top_axi"; > + power-domains = <&pwrc 5>; > + interrupts = <92>, <87>, <88>, <90>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + Same here, DTS describes the hardware, so you need port@0. Best regards, Krzysztof
On 2023/3/12 19:12, Laurent Pinchart wrote: > Hi Jack, > > Thank you for the patch. Thank you for your comments. > > On Fri, Mar 10, 2023 at 08:05:48PM +0800, Jack Zhu wrote: >> Add the bindings documentation for Starfive JH7110 Camera Subsystem >> which is used for handing image sensor data. >> >> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com> >> --- >> .../bindings/media/starfive,jh7110-camss.yaml | 144 ++++++++++++++++++ >> 1 file changed, 144 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml >> new file mode 100644 >> index 000000000000..3f348dd53441 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml >> @@ -0,0 +1,144 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> + >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Starfive SoC CAMSS ISP >> + >> +maintainers: >> + - Jack Zhu <jack.zhu@starfivetech.com> >> + - Changhuang Liang <changhuang.liang@starfivetech.com> >> + >> +description: >> + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC.It > > s/.It/. It/ OK, will fix > >> + consists of a VIN controller(Video In Controller, a top-level control until) > > s/(/ (/ OK, will fix > >> + and an ISP. >> + >> +properties: >> + compatible: >> + const: starfive,jh7110-camss >> + >> + reg: >> + maxItems: 2 >> + >> + reg-names: >> + items: >> + - const: syscon >> + - const: isp >> + >> + clocks: >> + maxItems: 7 >> + >> + clock-names: >> + items: >> + - const: apb_func >> + - const: wrapper_clk_c >> + - const: dvp_inv >> + - const: axiwr >> + - const: mipi_rx0_pxl >> + - const: ispcore_2x >> + - const: isp_axi >> + >> + resets: >> + maxItems: 6 >> + >> + reset-names: >> + items: >> + - const: wrapper_p >> + - const: wrapper_c >> + - const: axird >> + - const: axiwr >> + - const: isp_top_n >> + - const: isp_top_axi >> + >> + power-domains: >> + items: >> + - description: JH7110 ISP Power Domain Switch Controller. >> + >> + interrupts: >> + maxItems: 4 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@1: > > Why port@1 if there is no port@0 ? Will add port@0 node in the next version. port@0 is reserved for DVP sensor which is not currently supported. > >> + $ref: /schemas/graph.yaml#/$defs/port-base > > I think you can use > > $ref: /schemas/graph.yaml#/properties/port > > here as you don't define any additional property for the port node. OK, will alter it > >> + unevaluatedProperties: false >> + description: >> + Input port for receiving CSI data. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + required: >> + - port@1 >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - power-domains >> + - interrupts > > The 'ports' node should be mandatory too. OK, will fix. Thanks. > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + stfcamss: isp@19840000 { > > You can drop the label as it's not used. OK, will drop. > >> + compatible = "starfive,jh7110-camss"; >> + reg = <0x19840000 0x10000>, >> + <0x19870000 0x30000>; >> + reg-names = "syscon", "isp"; >> + clocks = <&ispcrg 0>, >> + <&ispcrg 13>, >> + <&ispcrg 2>, >> + <&ispcrg 12>, >> + <&ispcrg 1>, >> + <&syscrg 51>, >> + <&syscrg 52>; >> + clock-names = "apb_func", >> + "wrapper_clk_c", >> + "dvp_inv", >> + "axiwr", >> + "mipi_rx0_pxl", >> + "ispcore_2x", >> + "isp_axi"; >> + resets = <&ispcrg 0>, >> + <&ispcrg 1>, >> + <&ispcrg 10>, >> + <&ispcrg 11>, >> + <&syscrg 41>, >> + <&syscrg 42>; >> + reset-names = "wrapper_p", >> + "wrapper_c", >> + "axird", >> + "axiwr", >> + "isp_top_n", >> + "isp_top_axi"; >> + power-domains = <&pwrc 5>; >> + interrupts = <92>, <87>, <88>, <90>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@1 { >> + reg = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + vin_from_csi2rx: endpoint { >> + remote-endpoint = <&csi2rx_to_vin>; >> + }; >> + }; >> + }; >> + }; >
On 2023/3/12 19:16, Krzysztof Kozlowski wrote: > On 10/03/2023 13:05, Jack Zhu wrote: >> Add the bindings documentation for Starfive JH7110 Camera Subsystem >> which is used for handing image sensor data. >> >> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com> >> --- >> .../bindings/media/starfive,jh7110-camss.yaml | 144 ++++++++++++++++++ >> 1 file changed, 144 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml >> new file mode 100644 >> index 000000000000..3f348dd53441 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml >> @@ -0,0 +1,144 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> + >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Starfive SoC CAMSS ISP >> + >> +maintainers: >> + - Jack Zhu <jack.zhu@starfivetech.com> >> + - Changhuang Liang <changhuang.liang@starfivetech.com> >> + >> +description: >> + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC.It >> + consists of a VIN controller(Video In Controller, a top-level control until) >> + and an ISP. >> + >> +properties: >> + compatible: >> + const: starfive,jh7110-camss >> + >> + reg: >> + maxItems: 2 >> + >> + reg-names: >> + items: >> + - const: syscon >> + - const: isp >> + >> + clocks: >> + maxItems: 7 >> + >> + clock-names: >> + items: >> + - const: apb_func >> + - const: wrapper_clk_c >> + - const: dvp_inv >> + - const: axiwr >> + - const: mipi_rx0_pxl >> + - const: ispcore_2x >> + - const: isp_axi >> + >> + resets: >> + maxItems: 6 >> + >> + reset-names: >> + items: >> + - const: wrapper_p >> + - const: wrapper_c >> + - const: axird >> + - const: axiwr >> + - const: isp_top_n >> + - const: isp_top_axi >> + >> + power-domains: >> + items: >> + - description: JH7110 ISP Power Domain Switch Controller. >> + >> + interrupts: >> + maxItems: 4 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: > > You should have here port@0. The binding does not represent what is > supported by Linux. Binding represents hardware and you said you have > port@0 for the sensor. > OK, will add port@0. Thanks. > >> + port@1: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: >> + Input port for receiving CSI data. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + required: >> + - port@1 >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - power-domains >> + - interrupts >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + stfcamss: isp@19840000 { >> + compatible = "starfive,jh7110-camss"; >> + reg = <0x19840000 0x10000>, >> + <0x19870000 0x30000>; >> + reg-names = "syscon", "isp"; >> + clocks = <&ispcrg 0>, >> + <&ispcrg 13>, >> + <&ispcrg 2>, >> + <&ispcrg 12>, >> + <&ispcrg 1>, >> + <&syscrg 51>, >> + <&syscrg 52>; >> + clock-names = "apb_func", >> + "wrapper_clk_c", >> + "dvp_inv", >> + "axiwr", >> + "mipi_rx0_pxl", >> + "ispcore_2x", >> + "isp_axi"; >> + resets = <&ispcrg 0>, >> + <&ispcrg 1>, >> + <&ispcrg 10>, >> + <&ispcrg 11>, >> + <&syscrg 41>, >> + <&syscrg 42>; >> + reset-names = "wrapper_p", >> + "wrapper_c", >> + "axird", >> + "axiwr", >> + "isp_top_n", >> + "isp_top_axi"; >> + power-domains = <&pwrc 5>; >> + interrupts = <92>, <87>, <88>, <90>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + > > Same here, DTS describes the hardware, so you need port@0. OK, will add it. > > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml new file mode 100644 index 000000000000..3f348dd53441 --- /dev/null +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml @@ -0,0 +1,144 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Starfive SoC CAMSS ISP + +maintainers: + - Jack Zhu <jack.zhu@starfivetech.com> + - Changhuang Liang <changhuang.liang@starfivetech.com> + +description: + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC.It + consists of a VIN controller(Video In Controller, a top-level control until) + and an ISP. + +properties: + compatible: + const: starfive,jh7110-camss + + reg: + maxItems: 2 + + reg-names: + items: + - const: syscon + - const: isp + + clocks: + maxItems: 7 + + clock-names: + items: + - const: apb_func + - const: wrapper_clk_c + - const: dvp_inv + - const: axiwr + - const: mipi_rx0_pxl + - const: ispcore_2x + - const: isp_axi + + resets: + maxItems: 6 + + reset-names: + items: + - const: wrapper_p + - const: wrapper_c + - const: axird + - const: axiwr + - const: isp_top_n + - const: isp_top_axi + + power-domains: + items: + - description: JH7110 ISP Power Domain Switch Controller. + + interrupts: + maxItems: 4 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@1: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: + Input port for receiving CSI data. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + required: + - port@1 + +required: + - compatible + - reg + - reg-names + - clocks + - clock-names + - resets + - reset-names + - power-domains + - interrupts + +additionalProperties: false + +examples: + - | + stfcamss: isp@19840000 { + compatible = "starfive,jh7110-camss"; + reg = <0x19840000 0x10000>, + <0x19870000 0x30000>; + reg-names = "syscon", "isp"; + clocks = <&ispcrg 0>, + <&ispcrg 13>, + <&ispcrg 2>, + <&ispcrg 12>, + <&ispcrg 1>, + <&syscrg 51>, + <&syscrg 52>; + clock-names = "apb_func", + "wrapper_clk_c", + "dvp_inv", + "axiwr", + "mipi_rx0_pxl", + "ispcore_2x", + "isp_axi"; + resets = <&ispcrg 0>, + <&ispcrg 1>, + <&ispcrg 10>, + <&ispcrg 11>, + <&syscrg 41>, + <&syscrg 42>; + reset-names = "wrapper_p", + "wrapper_c", + "axird", + "axiwr", + "isp_top_n", + "isp_top_axi"; + power-domains = <&pwrc 5>; + interrupts = <92>, <87>, <88>, <90>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + + vin_from_csi2rx: endpoint { + remote-endpoint = <&csi2rx_to_vin>; + }; + }; + }; + };
Add the bindings documentation for Starfive JH7110 Camera Subsystem which is used for handing image sensor data. Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com> --- .../bindings/media/starfive,jh7110-camss.yaml | 144 ++++++++++++++++++ 1 file changed, 144 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml