| Message ID | 20230320100903.23588-2-nirmoy.das@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2:,1/3] drm/i915: Add a function to mmap framebuffer obj | expand |
On Mon, 20 Mar 2023, Nirmoy Das <nirmoy.das@intel.com> wrote: > Add a helper function to retrieve struct intel_fbdev from > struct drm_fb_helper. > > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_fbdev.c | 23 ++++++++++------------ > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > index 673bcdfb7ff6..8c3b3c3fd0e0 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > @@ -67,6 +67,11 @@ struct intel_fbdev { > struct mutex hpd_lock; > }; > > +static struct intel_fbdev *to_intel_fbdev(struct drm_fb_helper *fb_helper) > +{ > + return container_of(fb_helper, struct intel_fbdev, helper); > +} > + > static struct intel_frontbuffer *to_frontbuffer(struct intel_fbdev *ifbdev) > { > return ifbdev->fb->frontbuffer; > @@ -79,9 +84,7 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > > static int intel_fbdev_set_par(struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_set_par(info); > @@ -93,9 +96,7 @@ static int intel_fbdev_set_par(struct fb_info *info) > > static int intel_fbdev_blank(int blank, struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_blank(blank, info); > @@ -108,9 +109,7 @@ static int intel_fbdev_blank(int blank, struct fb_info *info) > static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_pan_display(var, info); > @@ -136,8 +135,7 @@ static const struct fb_ops intelfb_ops = { > static int intelfb_alloc(struct drm_fb_helper *helper, > struct drm_fb_helper_surface_size *sizes) > { > - struct intel_fbdev *ifbdev = > - container_of(helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(helper); > struct drm_framebuffer *fb; > struct drm_device *dev = helper->dev; > struct drm_i915_private *dev_priv = to_i915(dev); > @@ -193,8 +191,7 @@ static int intelfb_alloc(struct drm_fb_helper *helper, > static int intelfb_create(struct drm_fb_helper *helper, > struct drm_fb_helper_surface_size *sizes) > { > - struct intel_fbdev *ifbdev = > - container_of(helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(helper); > struct intel_framebuffer *intel_fb = ifbdev->fb; > struct drm_device *dev = helper->dev; > struct drm_i915_private *dev_priv = to_i915(dev);
On Mon, Mar 20, 2023 at 11:09:02AM +0100, Nirmoy Das wrote: > Add a helper function to retrieve struct intel_fbdev from > struct drm_fb_helper. > > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi > --- > drivers/gpu/drm/i915/display/intel_fbdev.c | 23 ++++++++++------------ > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > index 673bcdfb7ff6..8c3b3c3fd0e0 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > @@ -67,6 +67,11 @@ struct intel_fbdev { > struct mutex hpd_lock; > }; > > +static struct intel_fbdev *to_intel_fbdev(struct drm_fb_helper *fb_helper) > +{ > + return container_of(fb_helper, struct intel_fbdev, helper); > +} > + > static struct intel_frontbuffer *to_frontbuffer(struct intel_fbdev *ifbdev) > { > return ifbdev->fb->frontbuffer; > @@ -79,9 +84,7 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > > static int intel_fbdev_set_par(struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_set_par(info); > @@ -93,9 +96,7 @@ static int intel_fbdev_set_par(struct fb_info *info) > > static int intel_fbdev_blank(int blank, struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_blank(blank, info); > @@ -108,9 +109,7 @@ static int intel_fbdev_blank(int blank, struct fb_info *info) > static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_pan_display(var, info); > @@ -136,8 +135,7 @@ static const struct fb_ops intelfb_ops = { > static int intelfb_alloc(struct drm_fb_helper *helper, > struct drm_fb_helper_surface_size *sizes) > { > - struct intel_fbdev *ifbdev = > - container_of(helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(helper); > struct drm_framebuffer *fb; > struct drm_device *dev = helper->dev; > struct drm_i915_private *dev_priv = to_i915(dev); > @@ -193,8 +191,7 @@ static int intelfb_alloc(struct drm_fb_helper *helper, > static int intelfb_create(struct drm_fb_helper *helper, > struct drm_fb_helper_surface_size *sizes) > { > - struct intel_fbdev *ifbdev = > - container_of(helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(helper); > struct intel_framebuffer *intel_fb = ifbdev->fb; > struct drm_device *dev = helper->dev; > struct drm_i915_private *dev_priv = to_i915(dev); > -- > 2.39.0 >
On 20.03.2023 11:09, Nirmoy Das wrote: > Add a helper function to retrieve struct intel_fbdev from > struct drm_fb_helper. > > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Andi Shyti <andi.shyti@linux.intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > --- > drivers/gpu/drm/i915/display/intel_fbdev.c | 23 ++++++++++------------ > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > index 673bcdfb7ff6..8c3b3c3fd0e0 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > @@ -67,6 +67,11 @@ struct intel_fbdev { > struct mutex hpd_lock; > }; > > +static struct intel_fbdev *to_intel_fbdev(struct drm_fb_helper *fb_helper) > +{ > + return container_of(fb_helper, struct intel_fbdev, helper); > +} > + > static struct intel_frontbuffer *to_frontbuffer(struct intel_fbdev *ifbdev) > { > return ifbdev->fb->frontbuffer; > @@ -79,9 +84,7 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > > static int intel_fbdev_set_par(struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_set_par(info); > @@ -93,9 +96,7 @@ static int intel_fbdev_set_par(struct fb_info *info) > > static int intel_fbdev_blank(int blank, struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_blank(blank, info); > @@ -108,9 +109,7 @@ static int intel_fbdev_blank(int blank, struct fb_info *info) > static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > struct fb_info *info) > { > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); > int ret; > > ret = drm_fb_helper_pan_display(var, info); > @@ -136,8 +135,7 @@ static const struct fb_ops intelfb_ops = { > static int intelfb_alloc(struct drm_fb_helper *helper, > struct drm_fb_helper_surface_size *sizes) > { > - struct intel_fbdev *ifbdev = > - container_of(helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(helper); > struct drm_framebuffer *fb; > struct drm_device *dev = helper->dev; > struct drm_i915_private *dev_priv = to_i915(dev); > @@ -193,8 +191,7 @@ static int intelfb_alloc(struct drm_fb_helper *helper, > static int intelfb_create(struct drm_fb_helper *helper, > struct drm_fb_helper_surface_size *sizes) > { > - struct intel_fbdev *ifbdev = > - container_of(helper, struct intel_fbdev, helper); > + struct intel_fbdev *ifbdev = to_intel_fbdev(helper); > struct intel_framebuffer *intel_fb = ifbdev->fb; > struct drm_device *dev = helper->dev; > struct drm_i915_private *dev_priv = to_i915(dev);
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index 673bcdfb7ff6..8c3b3c3fd0e0 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.c +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c @@ -67,6 +67,11 @@ struct intel_fbdev { struct mutex hpd_lock; }; +static struct intel_fbdev *to_intel_fbdev(struct drm_fb_helper *fb_helper) +{ + return container_of(fb_helper, struct intel_fbdev, helper); +} + static struct intel_frontbuffer *to_frontbuffer(struct intel_fbdev *ifbdev) { return ifbdev->fb->frontbuffer; @@ -79,9 +84,7 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) static int intel_fbdev_set_par(struct fb_info *info) { - struct drm_fb_helper *fb_helper = info->par; - struct intel_fbdev *ifbdev = - container_of(fb_helper, struct intel_fbdev, helper); + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); int ret; ret = drm_fb_helper_set_par(info); @@ -93,9 +96,7 @@ static int intel_fbdev_set_par(struct fb_info *info) static int intel_fbdev_blank(int blank, struct fb_info *info) { - struct drm_fb_helper *fb_helper = info->par; - struct intel_fbdev *ifbdev = - container_of(fb_helper, struct intel_fbdev, helper); + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); int ret; ret = drm_fb_helper_blank(blank, info); @@ -108,9 +109,7 @@ static int intel_fbdev_blank(int blank, struct fb_info *info) static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, struct fb_info *info) { - struct drm_fb_helper *fb_helper = info->par; - struct intel_fbdev *ifbdev = - container_of(fb_helper, struct intel_fbdev, helper); + struct intel_fbdev *ifbdev = to_intel_fbdev(info->par); int ret; ret = drm_fb_helper_pan_display(var, info); @@ -136,8 +135,7 @@ static const struct fb_ops intelfb_ops = { static int intelfb_alloc(struct drm_fb_helper *helper, struct drm_fb_helper_surface_size *sizes) { - struct intel_fbdev *ifbdev = - container_of(helper, struct intel_fbdev, helper); + struct intel_fbdev *ifbdev = to_intel_fbdev(helper); struct drm_framebuffer *fb; struct drm_device *dev = helper->dev; struct drm_i915_private *dev_priv = to_i915(dev); @@ -193,8 +191,7 @@ static int intelfb_alloc(struct drm_fb_helper *helper, static int intelfb_create(struct drm_fb_helper *helper, struct drm_fb_helper_surface_size *sizes) { - struct intel_fbdev *ifbdev = - container_of(helper, struct intel_fbdev, helper); + struct intel_fbdev *ifbdev = to_intel_fbdev(helper); struct intel_framebuffer *intel_fb = ifbdev->fb; struct drm_device *dev = helper->dev; struct drm_i915_private *dev_priv = to_i915(dev);
Add a helper function to retrieve struct intel_fbdev from struct drm_fb_helper. Cc: Matthew Auld <matthew.auld@intel.com> Cc: Andi Shyti <andi.shyti@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Jani Nikula <jani.nikula@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/display/intel_fbdev.c | 23 ++++++++++------------ 1 file changed, 10 insertions(+), 13 deletions(-)