| Message ID | 20230316160324.78856-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2] platform: olpc: use SPI device ID data to bind device | expand |
Hi, On 3/16/23 17:03, Krzysztof Kozlowski wrote: > The driver defines spi_device_id table for module autoloading, but does > not use it in id_table which causes W=1 warning: > > drivers/platform/olpc/olpc-xo175-ec.c:737:35: error: ‘olpc_xo175_ec_id_table’ defined but not used [-Werror=unused-const-variable=] > > Reference the SPI device ID table, so it can be also used for device > binding. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > > --- > > Changes since v1: > 1. Rework the patch - reference the ID table instead of __maybe_unused. > --- > drivers/platform/olpc/olpc-xo175-ec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/olpc/olpc-xo175-ec.c b/drivers/platform/olpc/olpc-xo175-ec.c > index 4823bd2819f6..62ccbcb15c74 100644 > --- a/drivers/platform/olpc/olpc-xo175-ec.c > +++ b/drivers/platform/olpc/olpc-xo175-ec.c > @@ -746,6 +746,7 @@ static struct spi_driver olpc_xo175_ec_spi_driver = { > .of_match_table = olpc_xo175_ec_of_match, > .pm = &olpc_xo175_ec_pm_ops, > }, > + .id_table = olpc_xo175_ec_id_table, > .probe = olpc_xo175_ec_probe, > .remove = olpc_xo175_ec_remove, > };
diff --git a/drivers/platform/olpc/olpc-xo175-ec.c b/drivers/platform/olpc/olpc-xo175-ec.c index 4823bd2819f6..62ccbcb15c74 100644 --- a/drivers/platform/olpc/olpc-xo175-ec.c +++ b/drivers/platform/olpc/olpc-xo175-ec.c @@ -746,6 +746,7 @@ static struct spi_driver olpc_xo175_ec_spi_driver = { .of_match_table = olpc_xo175_ec_of_match, .pm = &olpc_xo175_ec_pm_ops, }, + .id_table = olpc_xo175_ec_id_table, .probe = olpc_xo175_ec_probe, .remove = olpc_xo175_ec_remove, };
The driver defines spi_device_id table for module autoloading, but does not use it in id_table which causes W=1 warning: drivers/platform/olpc/olpc-xo175-ec.c:737:35: error: ‘olpc_xo175_ec_id_table’ defined but not used [-Werror=unused-const-variable=] Reference the SPI device ID table, so it can be also used for device binding. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. Rework the patch - reference the ID table instead of __maybe_unused. --- drivers/platform/olpc/olpc-xo175-ec.c | 1 + 1 file changed, 1 insertion(+)