mbox series

[0/3] xfstests: make fscrypt-crypt-util self-tests work with OpenSSL 3.0

Message ID 20230319193847.106872-1-ebiggers@kernel.org (mailing list archive)
Headers show
Series xfstests: make fscrypt-crypt-util self-tests work with OpenSSL 3.0 | expand

Message

Eric Biggers March 19, 2023, 7:38 p.m. UTC 
This series makes the algorithm self-tests in fscrypt-crypt-util (which
are not compiled by default) work with OpenSSL 3.0.  Previously they
only worked with OpenSSL 1.1.

Eric Biggers (3):
  fscrypt-crypt-util: fix HKDF self-test with latest OpenSSL
  fscrypt-crypt-util: use OpenSSL EVP API for AES self-tests
  fscrypt-crypt-util: fix XTS self-test with latest OpenSSL

 src/fscrypt-crypt-util.c | 46 ++++++++++++++++++++++++++++++++--------
 1 file changed, 37 insertions(+), 9 deletions(-)

Comments

Zorro Lang March 20, 2023, 2:03 p.m. UTC | #1 
On Sun, Mar 19, 2023 at 12:38:44PM -0700, Eric Biggers wrote:
> This series makes the algorithm self-tests in fscrypt-crypt-util (which
> are not compiled by default) work with OpenSSL 3.0.  Previously they
> only worked with OpenSSL 1.1.
> 
> Eric Biggers (3):
>   fscrypt-crypt-util: fix HKDF self-test with latest OpenSSL
>   fscrypt-crypt-util: use OpenSSL EVP API for AES self-tests
>   fscrypt-crypt-util: fix XTS self-test with latest OpenSSL
> 
>  src/fscrypt-crypt-util.c | 46 ++++++++++++++++++++++++++++++++--------
>  1 file changed, 37 insertions(+), 9 deletions(-)
> 
> -- 

I'm not familiar with fscrypt changes, but from the commit log of 3 patches,
this patchset looks good to me. If there's not more review points from
linux-fscrypt@, I'll merge this patchset.

Just one tiny review point, I'd like to keep using same comment format, especially
in same source file. As src/fscrypt-crypt-util.c generally use "/* ... */", so
I'll change your "//..." to "/* ... */" when I merge it, if you don't mind.

Thanks,
Zorro

> 2.40.0
>
Eric Biggers March 20, 2023, 4:20 p.m. UTC | #2 
On Mon, Mar 20, 2023 at 10:03:50PM +0800, Zorro Lang wrote:
> Just one tiny review point, I'd like to keep using same comment format, especially
> in same source file. As src/fscrypt-crypt-util.c generally use "/* ... */", so
> I'll change your "//..." to "/* ... */" when I merge it, if you don't mind.

Yes that's fine.

- Eric