| Message ID | 20230319092641.41917-7-frank.li@vivo.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | None | expand |
On Sun, Mar 19, 2023 at 05:26:38PM +0800, Yangtao Li wrote: > Use kobject_del_and_put() to simplify code. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Signed-off-by: Yangtao Li <frank.li@vivo.com> Looks good to me, Acked-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/xfs_sysfs.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_sysfs.h b/fs/xfs/xfs_sysfs.h > index 148893ebfdef..e2ff063e2c29 100644 > --- a/fs/xfs/xfs_sysfs.h > +++ b/fs/xfs/xfs_sysfs.h > @@ -48,8 +48,7 @@ static inline void > xfs_sysfs_del( > struct xfs_kobj *kobj) > { > - kobject_del(&kobj->kobject); > - kobject_put(&kobj->kobject); > + kobject_del_and_put(&kobj->kobject); > wait_for_completion(&kobj->complete); > } > > -- > 2.35.1 >
diff --git a/fs/xfs/xfs_sysfs.h b/fs/xfs/xfs_sysfs.h index 148893ebfdef..e2ff063e2c29 100644 --- a/fs/xfs/xfs_sysfs.h +++ b/fs/xfs/xfs_sysfs.h @@ -48,8 +48,7 @@ static inline void xfs_sysfs_del( struct xfs_kobj *kobj) { - kobject_del(&kobj->kobject); - kobject_put(&kobj->kobject); + kobject_del_and_put(&kobj->kobject); wait_for_completion(&kobj->complete); }
Use kobject_del_and_put() to simplify code. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Signed-off-by: Yangtao Li <frank.li@vivo.com> --- fs/xfs/xfs_sysfs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)