| Message ID | 20230319172433.1708161-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a08df15eab0c572bc1d98c2392bcfcd744f26eda |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: cxgb3: remove unused fl_to_qset function | expand |
The 03/19/2023 13:24, Tom Rix wrote: Hi Tom, > > clang with W=1 reports > drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function > 'fl_to_qset' [-Werror,-Wunused-function] > static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) > ^ > This function is not used, so remove it. Don't forget to mention in the subject which tree is targeting this patch. Other than that looks OK. Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com> > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c > index 62dfbdd33365..efa7f401529e 100644 > --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c > +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c > @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = { > #endif > }; > > -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) > -{ > - return container_of(q, struct sge_qset, fl[qidx]); > -} > - > static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q) > { > return container_of(q, struct sge_qset, rspq); > -- > 2.27.0 >
On 3/19/23 10:45 AM, Horatiu Vultur wrote: > The 03/19/2023 13:24, Tom Rix wrote: > > Hi Tom, > >> clang with W=1 reports >> drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function >> 'fl_to_qset' [-Werror,-Wunused-function] >> static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) >> ^ >> This function is not used, so remove it. > Don't forget to mention in the subject which tree is targeting this > patch. This and all my similar fixes/cleanup are against -next. What prefix would you like to see ? Tom > Other than that looks OK. > > Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com> > >> Signed-off-by: Tom Rix <trix@redhat.com> >> --- >> drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c >> index 62dfbdd33365..efa7f401529e 100644 >> --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c >> +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c >> @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = { >> #endif >> }; >> >> -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) >> -{ >> - return container_of(q, struct sge_qset, fl[qidx]); >> -} >> - >> static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q) >> { >> return container_of(q, struct sge_qset, rspq); >> -- >> 2.27.0 >>
On Mon, Mar 20, 2023 at 05:29:51AM -0700, Tom Rix wrote: > > On 3/19/23 10:45 AM, Horatiu Vultur wrote: > > The 03/19/2023 13:24, Tom Rix wrote: > > > > Hi Tom, > > > > > clang with W=1 reports > > > drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function > > > 'fl_to_qset' [-Werror,-Wunused-function] > > > static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) > > > ^ > > > This function is not used, so remove it. > > Don't forget to mention in the subject which tree is targeting this > > patch. > > This and all my similar fixes/cleanup are against -next. > > What prefix would you like to see ? net-next Thanks > > Tom > > > Other than that looks OK. > > > > Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com> > > > > > Signed-off-by: Tom Rix <trix@redhat.com> > > > --- > > > drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 ----- > > > 1 file changed, 5 deletions(-) > > > > > > diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c > > > index 62dfbdd33365..efa7f401529e 100644 > > > --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c > > > +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c > > > @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = { > > > #endif > > > }; > > > > > > -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) > > > -{ > > > - return container_of(q, struct sge_qset, fl[qidx]); > > > -} > > > - > > > static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q) > > > { > > > return container_of(q, struct sge_qset, rspq); > > > -- > > > 2.27.0 > > > >
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sun, 19 Mar 2023 13:24:33 -0400 you wrote: > clang with W=1 reports > drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function > 'fl_to_qset' [-Werror,-Wunused-function] > static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) > ^ > This function is not used, so remove it. > > [...] Here is the summary with links: - net: cxgb3: remove unused fl_to_qset function https://git.kernel.org/netdev/net-next/c/a08df15eab0c You are awesome, thank you!
diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c index 62dfbdd33365..efa7f401529e 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = { #endif }; -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) -{ - return container_of(q, struct sge_qset, fl[qidx]); -} - static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q) { return container_of(q, struct sge_qset, rspq);
clang with W=1 reports drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function 'fl_to_qset' [-Werror,-Wunused-function] static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) ^ This function is not used, so remove it. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 ----- 1 file changed, 5 deletions(-)