| Message ID | 20230322135927.7668-1-peter.ujfalusi@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: SOF: ipc4/intel: Support for ChainDMA | expand |
On Wed, Mar 22, 2023 at 03:59:24PM +0200, Peter Ujfalusi wrote: > Hi, > > Changes since v1: > - Fix missed mutex unlocking in sof_ipc4_widget_free() > Reported by Dan Carpenter (thank you!) Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems for other users building on top of those commits so it's best practice to only change pubished git commits if absolutely essential.
On Wed, 2023-03-22 at 14:04 +0000, Mark Brown wrote: > On Wed, Mar 22, 2023 at 03:59:24PM +0200, Peter Ujfalusi wrote: > > Hi, > > > > Changes since v1: > > - Fix missed mutex unlocking in sof_ipc4_widget_free() > > Reported by Dan Carpenter (thank you!) > > Please do not submit new versions of already applied patches, please > submit incremental updates to the existing code. Modifying existing > commits creates problems for other users building on top of those > commits so it's best practice to only change pubished git commits if > absolutely essential. Hi Mark, Would a git fixup patch do at this phase, or should we do just a regular patch with Fixes: ca5ce0caa67fa9 ("ASoC: SOF: ipc4/intel: Add support for chained DMA") line? Best regards, Jyri --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
On Wed, Mar 22, 2023 at 03:15:23PM +0000, Sarha, Jyri wrote: > On Wed, 2023-03-22 at 14:04 +0000, Mark Brown wrote: > > Please do not submit new versions of already applied patches, please > > submit incremental updates to the existing code. Modifying existing > > commits creates problems for other users building on top of those > > commits so it's best practice to only change pubished git commits if > > absolutely essential. > Hi Mark, > Would a git fixup patch do at this phase, or should we do just a > regular patch with To repeat what's quoted above "please submit incremental updates to the existing code".
Hi Mark, On 22/03/2023 16:04, Mark Brown wrote: > On Wed, Mar 22, 2023 at 03:59:24PM +0200, Peter Ujfalusi wrote: >> Hi, >> >> Changes since v1: >> - Fix missed mutex unlocking in sof_ipc4_widget_free() >> Reported by Dan Carpenter (thank you!) > > Please do not submit new versions of already applied patches, please > submit incremental updates to the existing code. Modifying existing > commits creates problems for other users building on top of those > commits so it's best practice to only change pubished git commits if > absolutely essential. I'm aware of that and checked my mailbox several times that I don't have your applied notification mail. I would have sent a fix patch instead otherwise. Sorry for the inconvenience.
Hi, Changes since v1: - Fix missed mutex unlocking in sof_ipc4_widget_free() Reported by Dan Carpenter (thank you!) On a platform when the DSP is in use, we cannot select individual links to use or not use the DSP, it is either all or none. On some audio endpoint, like HDMI/DP, it is preferred to not use any processing in DSP to reduce the latency and to allow bytestream pass-through (DTS, DD, etc) IPC4 introduces a new type of end-to-end connection within the DSP which is using the host DMA and link DMA in a single buffer, working back-to-back, passing the received data without looking at it or trying to understand the format, content. This mode reduces the latency and allows non PCM streams to be sent from userspace. The feature is enabled per PCM bases, signalled in topology. Regards, Peter --- *** BLURB HERE *** Jyri Sarha (2): ASoC: SOF: ipc4: Add macros for chain-dma message bits ASoC: SOF: ipc4/intel: Add support for chained DMA Ranjani Sridharan (1): ASoC: SOF: topology: Set pipeline widget before updating IPC structures include/sound/sof/ipc4/header.h | 29 +++++++ include/uapi/sound/sof/tokens.h | 1 + sound/soc/sof/intel/hda-dai-ops.c | 18 ++++- sound/soc/sof/ipc4-pcm.c | 122 +++++++++++++++++++++++++++++- sound/soc/sof/ipc4-topology.c | 122 +++++++++++++++++++++++++++++- sound/soc/sof/ipc4-topology.h | 2 + sound/soc/sof/topology.c | 48 ++++++------ 7 files changed, 310 insertions(+), 32 deletions(-)