mbox series

[0/2] net: dsa: b53: mdio: add support for BCM53134

Message ID 20230323121804.2249605-1-noltari@gmail.com (mailing list archive)
Headers show
Series net: dsa: b53: mdio: add support for BCM53134 | expand

Message

Álvaro Fernández Rojas March 23, 2023, 12:18 p.m. UTC
This is based on the initial work from Paul Geurts that was sent to the
incorrect linux development lists and recipients.
I've modified it by removing BCM53134_DEVICE_ID from is531x5() and therefore
adding is53134() where needed.
I also added a separate RGMII handling block for is53134() since according to
Paul, BCM53134 doesn't support RGMII_CTRL_TIMING_SEL as opposed to is531x5().

Paul Geurts (1):
  net: dsa: b53: mdio: add support for BCM53134

Álvaro Fernández Rojas (1):
  dt-bindings: net: dsa: b53: add BCM53134 support

 .../devicetree/bindings/net/dsa/brcm,b53.yaml |  1 +
 drivers/net/dsa/b53/b53_common.c              | 53 ++++++++++++++++++-
 drivers/net/dsa/b53/b53_mdio.c                |  5 +-
 drivers/net/dsa/b53/b53_priv.h                |  9 +++-
 4 files changed, 65 insertions(+), 3 deletions(-)

Comments

Paul Geurts March 23, 2023, 7:58 p.m. UTC | #1
> -----Original Message-----
> From: Álvaro Fernández Rojas <noltari@gmail.com>
> Sent: donderdag 23 maart 2023 13:18
> To: Paul Geurts <paul.geurts@prodrive-technologies.com>;
> f.fainelli@gmail.com; jonas.gorski@gmail.com; andrew@lunn.ch;
> olteanv@gmail.com; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Álvaro Fernández Rojas <noltari@gmail.com>
> Subject: [PATCH 0/2] net: dsa: b53: mdio: add support for BCM53134
> 
> This is based on the initial work from Paul Geurts that was sent to the
> incorrect linux development lists and recipients.
> I've modified it by removing BCM53134_DEVICE_ID from is531x5() and
> therefore adding is53134() where needed.
> I also added a separate RGMII handling block for is53134() since according to
> Paul, BCM53134 doesn't support RGMII_CTRL_TIMING_SEL as opposed to
> is531x5().
> 
> Paul Geurts (1):
>   net: dsa: b53: mdio: add support for BCM53134
> 
> Álvaro Fernández Rojas (1):
>   dt-bindings: net: dsa: b53: add BCM53134 support
> 
>  .../devicetree/bindings/net/dsa/brcm,b53.yaml |  1 +
>  drivers/net/dsa/b53/b53_common.c              | 53 ++++++++++++++++++-
>  drivers/net/dsa/b53/b53_mdio.c                |  5 +-
>  drivers/net/dsa/b53/b53_priv.h                |  9 +++-
>  4 files changed, 65 insertions(+), 3 deletions(-)
> 
> --
> 2.30.2

Thank you for resending my patches! I didn't get to it yet. Any particular reason you didn't include the optional GPIO patch I had in my set?
---
Paul
Álvaro Fernández Rojas March 23, 2023, 10:10 p.m. UTC | #2
El jue, 23 mar 2023 a las 20:58, Paul Geurts
(<paul.geurts@prodrive-technologies.com>) escribió:
>
> > -----Original Message-----
> > From: Álvaro Fernández Rojas <noltari@gmail.com>
> > Sent: donderdag 23 maart 2023 13:18
> > To: Paul Geurts <paul.geurts@prodrive-technologies.com>;
> > f.fainelli@gmail.com; jonas.gorski@gmail.com; andrew@lunn.ch;
> > olteanv@gmail.com; davem@davemloft.net; edumazet@google.com;
> > kuba@kernel.org; pabeni@redhat.com; robh+dt@kernel.org;
> > krzysztof.kozlowski+dt@linaro.org; netdev@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> > Cc: Álvaro Fernández Rojas <noltari@gmail.com>
> > Subject: [PATCH 0/2] net: dsa: b53: mdio: add support for BCM53134
> >
> > This is based on the initial work from Paul Geurts that was sent to the
> > incorrect linux development lists and recipients.
> > I've modified it by removing BCM53134_DEVICE_ID from is531x5() and
> > therefore adding is53134() where needed.
> > I also added a separate RGMII handling block for is53134() since according to
> > Paul, BCM53134 doesn't support RGMII_CTRL_TIMING_SEL as opposed to
> > is531x5().
> >
> > Paul Geurts (1):
> >   net: dsa: b53: mdio: add support for BCM53134
> >
> > Álvaro Fernández Rojas (1):
> >   dt-bindings: net: dsa: b53: add BCM53134 support
> >
> >  .../devicetree/bindings/net/dsa/brcm,b53.yaml |  1 +
> >  drivers/net/dsa/b53/b53_common.c              | 53 ++++++++++++++++++-
> >  drivers/net/dsa/b53/b53_mdio.c                |  5 +-
> >  drivers/net/dsa/b53/b53_priv.h                |  9 +++-
> >  4 files changed, 65 insertions(+), 3 deletions(-)
> >
> > --
> > 2.30.2
>
> Thank you for resending my patches! I didn't get to it yet. Any particular reason you didn't include the optional GPIO patch I had in my set?

I'm using it for a Sercomm H500-s which doesn't seem to need it.
However, I've just realized that it's documented here as GPIO 18:
https://openwrt.org/toh/sercomm/h500-s#other
Anyway, I think that the GPIO patch can be added later...

> ---
> Paul

--
Álvaro