diff mbox series

[2/3] Input: xpad - remove unused field in VID/PID table

Message ID 20230225012147.276489-3-vi@endrift.com (mailing list archive)
State Accepted
Commit 907d73bc0b0a00a9cc3254d14351fc239899473f
Headers show
Series Input: xpad - Additional controller support | expand

Commit Message

Vicki Pfau Feb. 25, 2023, 1:21 a.m. UTC 
The list of specific VID/PID combinations for various controllers recently
added a new field "xtype". However, this field isn't used, nor filled in in the
table itself, and was likely added by mistake and overlooked during review.
Since this field isn't used, it's safe to remove.

Signed-off-by: Vicki Pfau <vi@endrift.com>
---
 drivers/input/joystick/xpad.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Torokhov March 24, 2023, 1:33 a.m. UTC | #1 
On Fri, Feb 24, 2023 at 05:21:47PM -0800, Vicki Pfau wrote:
> The list of specific VID/PID combinations for various controllers recently
> added a new field "xtype". However, this field isn't used, nor filled in in the
> table itself, and was likely added by mistake and overlooked during review.
> Since this field isn't used, it's safe to remove.
> 
> Signed-off-by: Vicki Pfau <vi@endrift.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 04af2213407f..d244ba22b85e 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -126,7 +126,6 @@  static const struct xpad_device {
 	char *name;
 	u8 mapping;
 	u8 xtype;
-	u8 packet_type;
 } xpad_device[] = {
 	{ 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 },
 	{ 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 },