| Message ID | 20230217155838.848403-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 45875db5cc91958af0e0ada3d8d27ad57ab7c8bb |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: sc7180-trogdor-pazquel360: drop incorrect RT5682S VBAT-supply | expand |
Hi, On Fri, Feb 17, 2023 at 7:58 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > It seems that the RT5682S codec does not use VBAT-supply: > > sc7180-trogdor-pazquel360-lte.dtb: codec@1a: Unevaluated properties are not allowed ('VBAT-supply' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I don't have access to datasheet. Driver still requests VBAT-supply but > other boards simply remove this property for RT5682S. I checked and I don't see the driver requesting VBAT. Specifically note that this is the "s" variant which seems to share no code with the old variants (the "i" variant and the SDW variant). > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi | 1 + > 1 file changed, 1 insertion(+) This seems right to me. Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Fri, 17 Feb 2023 16:58:36 +0100, Krzysztof Kozlowski wrote: > It seems that the RT5682S codec does not use VBAT-supply: > > sc7180-trogdor-pazquel360-lte.dtb: codec@1a: Unevaluated properties are not allowed ('VBAT-supply' was unexpected) > > Applied, thanks! [1/3] arm64: dts: qcom: sc7180-trogdor-pazquel360: drop incorrect RT5682S VBAT-supply commit: 45875db5cc91958af0e0ada3d8d27ad57ab7c8bb [2/3] arm64: dts: qcom: sc7280-herobrine-audio-rt5682: add missing supplies commit: 11c0d37d4c03ac8002d378cb814aca89118e7d35 [3/3] arm64: dts: qcom: sc7280: align RPMh regulator nodes with bindings commit: a93af4677e8c3db24eeeb0498bee83b6b7e341fe Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi index bc4f3b6c6634..273e2249f018 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi @@ -12,6 +12,7 @@ &alc5682 { compatible = "realtek,rt5682s"; realtek,dmic1-clk-pin = <2>; realtek,dmic-clk-rate-hz = <2048000>; + /delete-property/ VBAT-supply; }; ap_ts_pen_1v8: &i2c4 {
It seems that the RT5682S codec does not use VBAT-supply: sc7180-trogdor-pazquel360-lte.dtb: codec@1a: Unevaluated properties are not allowed ('VBAT-supply' was unexpected) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- I don't have access to datasheet. Driver still requests VBAT-supply but other boards simply remove this property for RT5682S. --- arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi | 1 + 1 file changed, 1 insertion(+)