| Message ID | 20230323053946.53094-1-lihuya@hust.edu.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: dwc3: remove dead code in dwc3_otg_get_irq | expand |
On Thu, Mar 23, 2023, lihuya wrote: > platform_get_irq() only return non-zero irq number on success, or > negative error number on failure. > > There is no need to check the return value of platform_get_irq() > to determine the return value of dwc3_otg_get_irq(), removing > them to solve this problem. > > Signed-off-by: lihuya <lihuya@hust.edu.cn> > --- > drivers/usb/dwc3/drd.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c > index 039bf241769a..c2e09700212d 100644 > --- a/drivers/usb/dwc3/drd.c > +++ b/drivers/usb/dwc3/drd.c > @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) > goto out; > > irq = platform_get_irq(dwc3_pdev, 0); > - if (irq > 0) > - goto out; > - > - if (!irq) > - irq = -EINVAL; > > out: > return irq; > -- > 2.34.1 > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Thanks, Thinh
> -----Original Messages----- > From: "Thinh Nguyen" <Thinh.Nguyen@synopsys.com> > Sent Time: 2023-03-25 02:28:56 (Saturday) > To: lihuya <lihuya@hust.edu.cn> > Cc: "Thinh Nguyen" <Thinh.Nguyen@synopsys.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "dzm91@hust.edu.cn" <dzm91@hust.edu.cn>, "hust-os-kernel-patches@googlegroups.com" <hust-os-kernel-patches@googlegroups.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH] usb: dwc3: remove dead code in dwc3_otg_get_irq > > On Thu, Mar 23, 2023, lihuya wrote: > > platform_get_irq() only return non-zero irq number on success, or > > negative error number on failure. > > > > There is no need to check the return value of platform_get_irq() > > to determine the return value of dwc3_otg_get_irq(), removing > > them to solve this problem. > > > > Signed-off-by: lihuya <lihuya@hust.edu.cn> > > --- > > drivers/usb/dwc3/drd.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c > > index 039bf241769a..c2e09700212d 100644 > > --- a/drivers/usb/dwc3/drd.c > > +++ b/drivers/usb/dwc3/drd.c > > @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) > > goto out; > > > > irq = platform_get_irq(dwc3_pdev, 0); > > - if (irq > 0) > > - goto out; > > - > > - if (!irq) > > - irq = -EINVAL; > > > > out: > > return irq; > > -- > > 2.34.1 > > > > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> > > Thanks, > Thinh Hi Thinh, I'm checking in about my patch submission for usb dwc3 that was "ack'ed" on 3/25, but hasn't been merged into the subtree yet. Could you please provide me with an update on its status and let me know if there are any issues or concerns that need to be addressed?
On Mon, Apr 24, 2023 at 04:45:14PM +0800, 梁宇航 wrote: > > -----Original Messages----- > > From: "Thinh Nguyen" <Thinh.Nguyen@synopsys.com> > > Sent Time: 2023-03-25 02:28:56 (Saturday) > > To: lihuya <lihuya@hust.edu.cn> > > Cc: "Thinh Nguyen" <Thinh.Nguyen@synopsys.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "dzm91@hust.edu.cn" <dzm91@hust.edu.cn>, "hust-os-kernel-patches@googlegroups.com" <hust-os-kernel-patches@googlegroups.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> > > Subject: Re: [PATCH] usb: dwc3: remove dead code in dwc3_otg_get_irq > > > > On Thu, Mar 23, 2023, lihuya wrote: > > > platform_get_irq() only return non-zero irq number on success, or > > > negative error number on failure. > > > > > > There is no need to check the return value of platform_get_irq() > > > to determine the return value of dwc3_otg_get_irq(), removing > > > them to solve this problem. > > > > > > Signed-off-by: lihuya <lihuya@hust.edu.cn> > > > --- > > > drivers/usb/dwc3/drd.c | 5 ----- > > > 1 file changed, 5 deletions(-) > > > > > > diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c > > > index 039bf241769a..c2e09700212d 100644 > > > --- a/drivers/usb/dwc3/drd.c > > > +++ b/drivers/usb/dwc3/drd.c > > > @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) > > > goto out; > > > > > > irq = platform_get_irq(dwc3_pdev, 0); > > > - if (irq > 0) > > > - goto out; > > > - > > > - if (!irq) > > > - irq = -EINVAL; > > > > > > out: > > > return irq; > > > -- > > > 2.34.1 > > > > > > > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> > > > > Thanks, > > Thinh > > Hi Thinh, > > I'm checking in about my patch submission for usb dwc3 that was > "ack'ed" on 3/25, but hasn't been merged into the subtree yet. > Could you please provide me with an update on its status and let > me know if there are any issues or concerns that need to be addressed? It's not in my queue anywhere, so it needs to be resent if anyone wants this applied. thanks, greg k-h
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c index 039bf241769a..c2e09700212d 100644 --- a/drivers/usb/dwc3/drd.c +++ b/drivers/usb/dwc3/drd.c @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc) goto out; irq = platform_get_irq(dwc3_pdev, 0); - if (irq > 0) - goto out; - - if (!irq) - irq = -EINVAL; out: return irq;
platform_get_irq() only return non-zero irq number on success, or negative error number on failure. There is no need to check the return value of platform_get_irq() to determine the return value of dwc3_otg_get_irq(), removing them to solve this problem. Signed-off-by: lihuya <lihuya@hust.edu.cn> --- drivers/usb/dwc3/drd.c | 5 ----- 1 file changed, 5 deletions(-)