| Message ID | 20230323194841.1431878-1-noltari@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 45977e58ce65ed0459edc9a0466d9dfea09463f5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: b53: mmap: add phy ops | expand |
On Thu, 23 Mar 2023 20:48:41 +0100 Álvaro Fernández Rojas wrote: > Implement phy_read16() and phy_write16() ops for B53 MMAP to avoid accessing > B53_PORT_MII_PAGE registers which hangs the device. > This access should be done through the MDIO Mux bus controller. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> Hi Florian, ack? Would be good for the record..
On 3/23/2023 12:48 PM, Álvaro Fernández Rojas wrote: > Implement phy_read16() and phy_write16() ops for B53 MMAP to avoid accessing > B53_PORT_MII_PAGE registers which hangs the device. > This access should be done through the MDIO Mux bus controller. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 23 Mar 2023 20:48:41 +0100 you wrote: > Implement phy_read16() and phy_write16() ops for B53 MMAP to avoid accessing > B53_PORT_MII_PAGE registers which hangs the device. > This access should be done through the MDIO Mux bus controller. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > drivers/net/dsa/b53/b53_mmap.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Here is the summary with links: - net: dsa: b53: mmap: add phy ops https://git.kernel.org/netdev/net/c/45977e58ce65 You are awesome, thank you!
diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c index e968322dfbf0..34f5804e449d 100644 --- a/drivers/net/dsa/b53/b53_mmap.c +++ b/drivers/net/dsa/b53/b53_mmap.c @@ -216,6 +216,18 @@ static int b53_mmap_write64(struct b53_device *dev, u8 page, u8 reg, return 0; } +static int b53_mmap_phy_read16(struct b53_device *dev, int addr, int reg, + u16 *value) +{ + return -EIO; +} + +static int b53_mmap_phy_write16(struct b53_device *dev, int addr, int reg, + u16 value) +{ + return -EIO; +} + static const struct b53_io_ops b53_mmap_ops = { .read8 = b53_mmap_read8, .read16 = b53_mmap_read16, @@ -227,6 +239,8 @@ static const struct b53_io_ops b53_mmap_ops = { .write32 = b53_mmap_write32, .write48 = b53_mmap_write48, .write64 = b53_mmap_write64, + .phy_read16 = b53_mmap_phy_read16, + .phy_write16 = b53_mmap_phy_write16, }; static int b53_mmap_probe_of(struct platform_device *pdev,
Implement phy_read16() and phy_write16() ops for B53 MMAP to avoid accessing B53_PORT_MII_PAGE registers which hangs the device. This access should be done through the MDIO Mux bus controller. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --- drivers/net/dsa/b53/b53_mmap.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)